Please make this repack without customs :) thank you .
Please make this repack without customs :) thank you .
it easy, but need more time. for first time i think need fix current bugs list.Originally Posted by xtreme17
- - - Updated - - -
Fix gens message, after kill gens player you have recieve message about like this ->"5 contribution point(s) would be lost"
Search for %d contribution point(s) would be lost
and change:
GCServerMsgStringSend(Text, lpObj->m_Index, 1);
to
GCServerMsgStringSend(Text, lpTargetObj->m_Index, 1);
since the switch case is DBCLASS, your code there is doing absolutely nothing. its like
I think that fist master is 98 and rage fighter 96, so code should be:Code:if (somevariable == 1) somevariable = 1;
that being said, count me in if you start a public repo.Code:case 98: lpObj->DbClass = 96; break;
Oh my carelessness :D
//PublicRepo:
Ok, today or tomorrow i create repo on github and give invites u and all Good Coders.
- - - Updated - - -
Hi guys i create repo
WebMonkey and topic creator i sent message, but if you learn c++ or good coder and think about fix this release please leave me message about it!
Last edited by quskevel; 29-08-14 at 01:33 PM.
if( g_PostChatColor < 1 || g_PostChatColor > 8 )
Post Chat Color Crash fix
Socket Seed fix drop:
Massive spam log fix (just delete following lines):Code:if ( this->m_SphereDropLevel[0] <= iMonsterLevel ) { iSphereLevel = 1; } else if( this->m_SphereDropLevel[1] <= iMonsterLevel ) { iSphereLevel = 2; } else if( this->m_SphereDropLevel[2] <= iMonsterLevel ) { iSphereLevel = 3; } else if( this->m_SphereDropLevel[3] <= iMonsterLevel ) { iSphereLevel = 4; } else if( this->m_SphereDropLevel[4] <= iMonsterLevel ) { iSphereLevel = 5; } else { return -1; } // ---- for( int i = 0; i < iSphereLevel; i++ ) { if(this->m_SphereDropRate[i] >= GetLargeRand() % MAX_SPHERE_DROP ) { iItemCode = i + ITEMGET(12, 70); } }
i see u use my "FIX":Code:if ( iTotalShieldDamage > 0 ) { LogAddTD("[PvP System] Victim:[%s][%s], Attacker:[%s][%s] - SD[%d] HP[%f] -> SD[%d] HP[%f]", lpTargetObj->AccountID, lpTargetObj->Name, lpObj->AccountID, lpObj->Name, lpTargetObj->iShield + iTotalShieldDamage, lpTargetObj->Life + AttackDamage, lpTargetObj->iShield, lpTargetObj->Life); }
But it dont fix offtrade for item. No recieve soul for sell item.Code:else if( !this->EmptyPointInventory(lpUser, lpUser->Inventory1[ItemPos].m_iPShopValue) ) //remove the !
OffExp Timer fix:
Code:#ifdef OFFEXP if ( lpObj->OffExp == 1 ) { OffExp.TickTimes(n); } #endif
Add To Bug list after this message gs block to join server:
with error:Code:if( this->CheckSync() == FALSE ) { LogAddC(2, "[CastleSiege] CCastleSiege::Init() - CheckSync() == FALSE"); MsgBox("[CastleSiege] CCastleSiege::Init() - CheckSync() == FALSE"); MsgOutput(iIndex, lMsg.Get(3202)); return; }
error-L2: header error (wsJoinServercli.cpp 295)lOfs:0, size:28
Last edited by quskevel; 30-08-14 at 03:13 AM.
In order to receive soul from buyer you need to recode a big chunk of the offtrade, currently it closes the client before updating inventory.
i think need add delay for closed user if item are sold.
but ofc we are fix it soon :D for me offtrade not needed function... only for trading (zen/wcoin).
Delay for PShop open, because you no have time for start offtrade or correct price you item.
This delay created only by me :D with my "true" skill xD
Test it:
search for:
and change this function to:Code:LogAddTD("[PShop] [%s][%s] is Receiving PShop List From [%s][%s]", gObj[aSourceIndex].AccountID, gObj[aSourceIndex].Name, lpObj->AccountID, lpObj->Name); gObj[aSourceIndex].m_bPShopWantDeal = true; gObj[aSourceIndex].m_iPShopDealerIndex = lpObj->m_Index; memcpy(gObj[aSourceIndex].m_szPShopDealerName, lpObj->Name, MAX_ACCOUNT_LEN); ::CGPShopAnsBuyList(aSourceIndex, lpObj->m_Index, 1, false);
search for lpObj->OffExpSpeed = 0;Code:if ( gOpenDelay > lpObj->gOpenDelayTick ) { int Delay = gOpenDelay - lpObj->gOpenDelayTick; char Text[100]; sprintf(Text, "Protect disabled after: %dsecond(s)", Delay); GCServerMsgStringSend(Text, aSourceIndex, 1); ::CGPShopAnsBuyList(aSourceIndex, -1, 3, 0); return; } else { LogAddTD("[PShop] [%s][%s] is Receiving PShop List From [%s][%s]", gObj[aSourceIndex].AccountID, gObj[aSourceIndex].Name, lpObj->AccountID, lpObj->Name); gObj[aSourceIndex].m_bPShopWantDeal = true; gObj[aSourceIndex].m_iPShopDealerIndex = lpObj->m_Index; memcpy(gObj[aSourceIndex].m_szPShopDealerName, lpObj->Name, MAX_ACCOUNT_LEN); ::CGPShopAnsBuyList(aSourceIndex, lpObj->m_Index, 1, false); }
and after add this:
lpObj->gOpenDelayTick = 0;
in user.cpp search:
if(lpObj->Connected > PLAYER_LOGGED && lpObj->Type == OBJ_USER)
in this function u see check OffExp,TickTimes(n)
after this check add this:
in user.h add:Code:if( lpObj->m_bPShopOpen ) { lpObj->gOpenDelayTick++; } else { lpObj->gOpenDelayTick = 0; }
int gOpenDelayTick;
after
DWORD m_PotionTick;
ofc need create config variable:
in GameMain.cpp add:
int gOpenDelay;
after
BOOL gDoPShopOpen;
in next u need search 3xTimes
gDoPShopOpen = GetPrivateProfileInt("GameServerInfo","PersonalShopOpen", 0, gDirPath.GetNewPath("commonserver.cfg"));
and add this after (in all of 3x):
gOpenDelay = GetPrivateProfileInt("GameServerInfo","PersonalShopDelay", 0, gDirPath.GetNewPath("commonserver.cfg"));
search for:
extern BOOL gDoPShopOpen;
and add after:
extern int gOpenDelay;
if you do this u need add in CommonServer.cfg
PersonalShopDelay = 60 //-> Personal shop open delay [0-65535]
i dont think this will work
anyway the idea is correct, we need some kind of delay
now for the other post u made:
1. the chat fix u added, can u explain more? i dont know whats wrong with chat
2. sphere drop, whats wrong? explain pls, I dont see anything different between ur fix and original code
3. offexp fix I will add, i remember that u posted it before but I didnt bother adding it cause i am not using it, but i will add it now
4. the bug u want me to add to the list is not a bug I think, if u setup the cs this doesnt appear, and even if u dont setup cs and this appears, it does nothing really to affect GS
send me ur skype id
Last edited by ftewegw1; 30-08-14 at 10:18 AM.
2. -> try to setup drop and u see drop from spiders seed (but lvl for +1 110+ (/spider 1lvl)) for example.
2. -> with my fix this problem solved and seed sphere not droped from small then in config level.
1. -> i small dont understand.. quote me(fix) for understand you.
4. -> it serious bug because if you dont setup CS you dont login to server and ofc on account. This bug knows Nam4 and he promised help me with it.
About Offtrade i maybe know how to fix fast bug with not save souls....it's a bit like my fix from steal pshop items if you do off trade..
and ofc i sent u and webmonkey invite to repo, need sync this current repository and apply all fix. Today i not sleep and now i go to sleep XD
No need to add all that. A delay is not needed, just a smarter way to deal with empty offtraders.
Last edited by webmonkey; 30-08-14 at 08:28 PM.
if i right you mean no dc from server after items are sold?
ok offtrade fixed, agility bug will be fixed as soon as webmonkey posts it
few more fixes and this is bugless, not that anyone helped with tests...
New Bug i found when DL kill selupan the drop will not be 100% some time he will drop items and some time he will not
if you use summon selupan he will drop items if you use sm or dk but try to go to event and kill selupan and you will see but use DL and skill beards :)
no such bug #tested
yea, tested no bug found.
Reply With Quote