[Help] News System Problem

[MrCrazy]

i'm trying to use that http://forum.ragezone.com/f427/add-n...system-743848/ news system
but when i click the NPC i get error, everything else is fine, the command adding the column and everything is fine,but when i click the NPC i get error.

using v83 MapleSolstice source

[MentaL]

[Tyler1q1q]

i'm trying to use that http://forum.ragezone.com/f427/add-n...system-743848/ news system
but when i click the NPC i get error, everything else is fine, the command adding the column and everything is fine,but when i click the NPC i get error.

using v83 MapleSolstice source

It would be great if you could post the error you get.

[MrCrazy]

It would be great if you could post the error you get.

This just says in bat
Error npc: NPC ID

[vTim]

@MrCrazy post a screenshot of your error. Also, read the release. People added stuff for it to work it looks like. Maybe I suggest you do the same and read the comments on the release.

[MrCrazy]

@MrCrazy post a screenshot of your error. Also, read the release. People added stuff for it to work it looks like. Maybe I suggest you do the same and read the comments on the release.

i tried what other people post, and there is nothing to picture, i'm saying it's only says " NPC Error: ID 2001004 "

[Fraysa]

Find out in your source where it shows the following message: "NPC Error: ID" and print the exception instead so you know what's wrong with it.

[MrCrazy]

Find out in your source where it shows the following message: "NPC Error: ID" and print the exception instead so you know what's wrong with it.

'Exception.StackTrace' for being exact, and be sure to post it here if you'd like us to help.

[CODE]public void start(MapleClient c, int npc, String filename, MapleCharacter chr) {
        c.getPlayer().setLastNpc(npc);
        try {
            NPCConversationManager cm = new NPCConversationManager(c, npc);
            if (cms.containsKey(c)) {
                return;
            }
            cms.put(c, cm);
            Invocable iv = null;
            if (filename != null) {
                iv = getInvocable("npc/" + filename + ".js", c);
            }
            if (iv == null) {
                iv = getInvocable("npc/" + npc + ".js", c);
            }
            if (iv == null || NPCScriptManager.getInstance() == null) {
                dispose(c);
                return;
            }
            engine.put("cm", cm);
            NPCScript ns = iv.getInterface(NPCScript.class);
            scripts.put(c, ns);
            if (chr == null) {
                ns.start();
            } else {
                ns.start(chr);
            }
        } catch (UndeclaredThrowableException ute) {
            ute.printStackTrace();
            System.out.println("Error: NPC " + npc + ". UndeclaredThrowableException.");
            dispose(c);
            cms.remove(c);
            notice(c);
        } catch (Exception e) {
            System.out.println("Error: NPC " + npc + ".");
            e.printStackTrace();
            e.printStackTrace(System.out);
            dispose(c);
            cms.remove(c);
            notice(c);
        }
    }


    public void action(MapleClient c, byte mode, byte type, int selection) {
        NPCScript ns = scripts.get(c);
        if (ns != null) {
            try {
                ns.action(mode, type, selection);
            } catch (UndeclaredThrowableException ute) {
                ute.printStackTrace();
                //System.out.println("Error: NPC " + getCM(c).getNpc() + ". UndeclaredThrowableException.");
                System.out.println("Error executing NPC script. " + c.getPlayer().getLastNpc() + ".js");// My Change
                dispose(c);
                notice(c);
            } catch (Exception e) {
                //System.out.println("Error: NPC " + getCM(c).getNpc() + ".");
                System.out.println("Error executing NPC script. " + c.getPlayer().getLastNpc() + ".js");// My Change
                e.printStackTrace();
                e.printStackTrace(System.out);
                dispose(c);
                notice(c);
            }
        }
    }
[/CODE] 

[MrCrazy]

there i posted the error, and now nobody helps

[xStr0nGx]

What's on line 69?

[NPCScriptManager class]

[MrCrazy]

What's on line 69?

[NPCScriptManager class]

ns.start(); 

all start function

46:public void start(MapleClient c, int npc, String filename, MapleCharacter chr) {        47:c.getPlayer().setLastNpc(npc);
        48:try {
            49:NPCConversationManager cm = new NPCConversationManager(c, npc);
           50: if (cms.containsKey(c)) {
               51: return;
           52: }
            53:cms.put(c, cm);
            54:Invocable iv = null;
            55:if (filename != null) {
                56:iv = getInvocable("npc/" + filename + ".js", c);
            57:}
            58:if (iv == null) {
                59:iv = getInvocable("npc/" + npc + ".js", c);
            60:}
            61:if (iv == null || NPCScriptManager.getInstance() == null) {
                62:dispose(c);
                63:return;
            64:}
            65:engine.put("cm", cm);
            66:NPCScript ns = iv.getInterface(NPCScript.class);
            67:scripts.put(c, ns);
            68:if (chr == null) {
                69:ns.start();
            70:} else {
                71:ns.start(chr);
            82:}
        83:} catch (UndeclaredThrowableException ute) {
            84:ute.printStackTrace();
            85:System.out.println("Error: NPC " + npc + ". UndeclaredThrowableException.");
            86:dispose(c);
            87:cms.remove(c);
            88:notice(c);
        89:} catch (Exception e) {
            90:System.out.println("Error: NPC " + npc + ".");
            91:e.printStackTrace();
            92:e.printStackTrace(System.out);
            93:dispose(c);
            94:cms.remove(c);
            95:notice(c);
        96:}
    97:} 

[xStr0nGx]

Try changing the method to this:

public void start(MapleClient c, int npc, String filename, MapleCharacter chr) {
try {
NPCConversationManager cm = new NPCConversationManager(c, npc);
if (cms.containsKey(c)) {
dispose(c);
return;
}
cms.put(c, cm);
Invocable iv = null;
if (filename != null) {
iv = getInvocable("npc/world" + c.getWorld() + "/" + filename + ".js", c);
}
if (iv == null) {
iv = getInvocable("npc/world" + c.getWorld() + "/" + npc + ".js", c);
}
if (iv == null || NPCScriptManager.getInstance() == null) {
dispose(c);
return;
}
engine.put("cm", cm);
scripts.put(c, iv);
try {
iv.invokeFunction("start");
} catch (final NoSuchMethodException nsme) {
try {
iv.invokeFunction("start", chr);
} catch (final NoSuchMethodException nsma) {
iv.invokeFunction("action", (byte) 1, (byte) 0, 0);
}
}
} catch (final UndeclaredThrowableException | ScriptException ute) {
FilePrinter.printError(FilePrinter.NPC + npc + ".txt", ute);
notice(c, npc);
dispose(c);
} catch (final Exception e) {
FilePrinter.printError(FilePrinter.NPC + npc + ".txt", e);
notice(c, npc);
dispose(c);
}
}

It seems to be more completed. Taken from MoopleDEV.

[Eric]

Try changing the method to this:



It seems to be more completed. Taken from MoopleDEV.

that'd break it. he doesn't even have multi worlds so using "scripts/npc/world0" would already throw a new error.

@OP I'd like to see your current NPC script you're attempting to use in the first place, post that please.

[xStr0nGx]

that'd break it. he doesn't even have multi worlds so using "scripts/npc/world0" would already throw a new error.

@OP I'd like to see your current NPC script you're attempting to use in the first place, post that please.

Didn't noticed this part, it shouldn't be a problem if he knows what he is doing.


Anyways the problem is that

iv.getInterface(NPCScript.class);

returns null,

which means it should be removed and replaced by:

scripts.put(c, iv);

instead of the ns variable.

Or if it works differently, then the problem could be laying somewhere else, I don't know.


@OP, is the problem occurs only for this specific NPC? if so then please post the script as Chunkarama said.

[MrCrazy]

that'd break it. He doesn't even have multi worlds so using "scripts/npc/world0" would already throw a new error.

@op i'd like to see your current npc script you're attempting to use in the first place, post that please.

function start() {
    cm.sendok("dfhdf");
    cm.dispose();
}

didn't noticed this part, it should be a problem if he knows what he is doing.


Anyways the problem is that returns null,

which means it should be removed and replaced by: Instead of the ns variable.

Or if it works differently, then the problem could be laying somewhere else, i don't know.


@op, is the problem occurs only for this specific npc? If so then please post the script as chunkarama said.

your fix

NPCScript ns = scripts.put(c, (NPCScript) iv);//iv.getInterface(NPCScript.class);

[Fraysa]

The problem is with your script, not with your scripting interface. Remove the script suggested by xStr0nGx and read the error again to see what's wrong with your script.