Mobs & battleship

[iwtLive]

Hello!

I'm using moopledev rev120, where all the skills should work!
I'm not sure why but when someone uses the skill battleship he gets disconnected from the game with no error and im not even getting a log of the error so I really don't know what to do.

In addition to that problem I there is a problem where monsters (like the blue mobs that zakum spawns)
don't die even after reaching 0 HP.

I will be still trying to fix thsese problems as I'm waiting for clues x;

- update -

and if anyone could tell me whats the problem here i'll love him forever -_- trying to make it so u dont need to log off to vote, basically adding a command that will claim it.

    public void claimVote() {
        MapleCharacter ty = new MapleCharacter();
        int claimvote = 0;
        try { // recieving the data
            PreparedStatement ps = DatabaseConnection.getConnection().prepareStatement("SELECT claimvote FROM accounts WHERE id = ?");
            ps.setInt(1, ty.accountid);
            ResultSet rs = ps.executeQuery();
            if (rs.next()) {
                claimvote = rs.getInt("claimvote");
            }
            rs.close();
            ps.close();
        } catch (Exception e) {
            System.out.print(name + " has recieved an error while trying to claim a vote.");
        }
        
        
        if (claimvote > 0) { // positive number claim rewards, negative don't do anything
            gainVotePoints(1);
            claimvote -= 1;
            getCashShop().getCash(5000);
            dropMessage("You have recieved 1 vote point and 5000 nx.");
        } else {
            dropMessage("You don't have vote points to be claimed.");
        }
        Connection con = DatabaseConnection.getConnection();
        
        
        try { // sending back the new data
            con.setTransactionIsolation(Connection.TRANSACTION_READ_UNCOMMITTED);
            con.setAutoCommit(false);
            PreparedStatement ps;
            ps = con.prepareStatement("UPDATE accounts SET `claimvote` = ? WHERE id = ?");
            ps.setInt(1, claimvote);
            ps.setInt(2, client.getAccID());
            ps.executeUpdate();
            ps.close();
        } catch (SQLException se) {
            System.out.print(name + " has recieved an error while trying to claim a vote.");
        }
    } 

[MentaL]

[iwtLive]

beep boop

[iwtLive]

boop beep

[QuietCrystal]

You need to tell us the problem with the vote function ._. Errors? Wut?

[PHP]Also why not,
gainVotePoints(claimvote);
getCashShop().getCash(5000 * claimvote);[\PHP]

[iwtLive]

You need to tell us the problem with the vote function ._. Errors? Wut?

[PHP]Also why not,
gainVotePoints(claimvote);
getCashShop().getCash(5000 * claimvote);[\PHP]

oh opsie, the problem is that im recieving the 0 into the claimvote instead of the actual number I put there.
so basically the value if claimvote is not changing.
and yar I should have made it this way o-oo

[Diamondo25]

MapleCharacter ty = new MapleCharacter();
int claimvote = 0;
try { // recieving the data
PreparedStatement ps = DatabaseConnection.getConnection().prepareStatement("SELECT claimvote FROM accounts WHERE id = ?");
ps.setInt(1, ty.accountid);


You are getting the accountid from a new MapleCharacter, not the one you are updating...

[QuietCrystal]

MapleCharacter ty = new MapleCharacter();
int claimvote = 0;
try { // recieving the data
PreparedStatement ps = DatabaseConnection.getConnection().prepareStatement("SELECT claimvote FROM accounts WHERE id = ?");
ps.setInt(1, ty.accountid);


You are getting the accountid from a new MapleCharacter, not the one you are updating...

Oh wow was focused on the database statements so much that I didn't see the obvious declaration there ._______. *Feels dumb*

Edit: By the way, if it's already 0, then don't bother executing the update statement. Pretty wasteful.

[kevintjuh93]

I will fix those errors in rev 121. Let me check them now, so I can post a fix here.

[iwtLive]

sorry I was on a vacation for 3 days, and I was unable to answer with my crappy phone..

Oh wow was focused on the database statements so much that I didn't see the obvious declaration there ._______. *Feels dumb*

Edit: By the way, if it's already 0, then don't bother executing the update statement. Pretty wasteful.

so do you basically mean I should do it like this?

int claimvote = 0;
try { // recieving the data
PreparedStatement ps = DatabaseConnection.getConnection().prepareStatement("SELECT claimvote FROM accounts WHERE id = ?");
ps.setInt(1, accountid); 

I will fix those errors in rev 121. Let me check them now, so I can post a fix here.

How do I let you check them? would you like to come on the server?

[Diamondo25]

sorry I was on a vacation for 3 days, and I was unable to answer with my crappy phone..


so do you basically mean I should do it like this?

int claimvote = 0;
try { // recieving the data
PreparedStatement ps = DatabaseConnection.getConnection().prepareStatement("SELECT claimvote FROM accounts WHERE id = ?");
ps.setInt(1, accountid); 

How do I let you check them? would you like to come on the server?

use client.getAccID(), like you do in the other query

[iwtLive]

use client.getAccID(), like you do in the other query

thanks that worked,
now i only need to find solutions for my other 2 problems xD