my !randomplayer command

[yarden]

This is the code :

} else if (splitted[0].equals("randomplayer")) {
            List<String> list = new ArrayList<String>();
            for (MapleCharacter chr : player.getMap().getCharacters()) {
                if (chr != null && !chr.isSGM()) {
                list.add(chr.getName());
            }
            String[] availableChar = list.toArray(new String[list.size()]);
            int chosenChar = Randomizer.rand(0, availableChar.length);
            player.getMap().broadcastMessage(MaplePacketCreator.sendYellowTip("The chosen player was " + availableChar[chosenChar] + ".")); 
            } 

Ok the the problem is that everytime i use it,It doesn't work very well
It either sends the message "The chosen player was.." Twice or doesnt work at all..
What can i do??or what's wrong with that code?

[MentaL]

[hecari]

Oh god ._. Why List<String> ?
Do you know that player.getMap().getCharacters() return List<MapleCharacter> data type? Use a List<MapleCharacter> variableName to hold the data return from player.getMap().getCharacters().

public static class randomPlayer extends CommandExecute {
        
        public int execute(MapleClient c, String[] splitted) {
            List<MapleCharacter> charactersz = c.getPlayer().getMap().getCharacters();
            int amount = charactersz.size();
            int random = (int) Randomizer.rand(0, amount);
            MapleCharacter characterInList = charactersz.get(random);
            String nameOfCharacter = characterInList.getName();
            for (MapleCharacter chr : charactersz) {
                   chr.dropMessage(1, nameOfCharacter); // int messageType, string
            }
            return 1;
        }
    } 

Port it to your source . The above code is based on Lithium .

[yarden]

Oh god ._. Why List<String> ?
Do you know that player.getMap().getCharacters() return List<MapleCharacter> data type? Use a List<MapleCharacter> variableName to hold the data return from player.getMap().getCharacters().

public static class randomPlayer extends CommandExecute {
        
        public int execute(MapleClient c, String[] splitted) {
            List<MapleCharacter> charactersz = c.getPlayer().getMap().getCharacters();
            int amount = charactersz.size();
            int random = (int) Randomizer.rand(0, amount);
            MapleCharacter characterInList = charactersz.get(random);
            String nameOfCharacter = characterInList.getName();
            for (MapleCharacter chr : charactersz) {
                   chr.dropMessage(1, nameOfCharacter); // int messageType, string
            }
            return 1;
        }
    } 

Port it to your source . The above code is based on Lithium .

:S What do u mean port it to your source..?
Sorry I'm trying to learn lol

[Firzen66]

availableChar[chosenChar] 

refers to MapleCharacter class, this class has getName() method, you shall use it that way:

availableChar[chosenChar].getName() 

btw, use chr.isGM() instead of chr.isSGM()

[yarden]

availableChar[chosenChar] 

refers to MapleCharacter class, this class has getName() method, you shall use it that way:

availableChar[chosenChar].getName() 

btw, use chr.isGM() instead of chr.isSGM()

isGM also reffers to donors so i'd rather use isSGM (:
I know you can change it but it doesnt metter XD

anyways
where do you see availableChar[chosenChar] in the code? :O

[Firzen66]

why won't you make a isDonator() instead of naming a donator as a GM?
nvm, just change this line:

player.getMap().broadcastMessage(MaplePacketCreator.sendYellowTip("The chosen player was " + availableChar[chosenChar] + ".")); 

to:

player.getMap().broadcastMessage(MaplePacketCreator.sendYellowTip("The chosen player was " + availableChar[chosenChar].getName() + ".")); 

[yarden]

why won't you make a isDonator() instead of naming a donator as a GM?
nvm, just change this line:

player.getMap().broadcastMessage(MaplePacketCreator.sendYellowTip("The chosen player was " + availableChar[chosenChar] + ".")); 

to:

player.getMap().broadcastMessage(MaplePacketCreator.sendYellowTip("The chosen player was " + availableChar[chosenChar].getName() + ".")); 

Umm it says cannot find symbol

[Firzen66]

I didn't see you added the name of the character, thought you added the character himself.
does it show you an error in your bat files?

[yarden]

I didn't see you added the name of the character, thought you added the character himself.
does it show you an error in your bat files?

um no.
The command does work but it's just that sometimes it sends the message twice with 2 different players like
The chosen player was yarden
the chosen player was firzen66

instead of sending it once.
and sometimes the ocmmand doesnt work at all

[Firzen66]

lol, try this one:

} else if (splitted[0].equals("randomplayer")) { 
            List<String> list = new ArrayList<String>();
            for (MapleCharacter chr : player.getMap().getCharacters()) { 
                if (chr != null && !chr.isSGM()) { 
                    list.add(chr.getName()); 
                } 
            }
            String[] availableChar = list.toArray(new String[list.size()]); 
            int chosenChar = Randomizer.rand(0, availableChar.length); 
            player.getMap().broadcastMessage(MaplePacketCreator.sendYellowTip("The chosen player was " + availableChar[chosenChar] + "."));  
        } 

seems like you missed one bracket haha

[yarden]

lol, try this one:

} else if (splitted[0].equals("randomplayer")) { 
            List<String> list = new ArrayList<String>();
            for (MapleCharacter chr : player.getMap().getCharacters()) { 
                if (chr != null && !chr.isSGM()) { 
                    list.add(chr.getName()); 
                } 
            }
            String[] availableChar = list.toArray(new String[list.size()]); 
            int chosenChar = Randomizer.rand(0, availableChar.length); 
            player.getMap().broadcastMessage(MaplePacketCreator.sendYellowTip("The chosen player was " + availableChar[chosenChar] + "."));  
        } 

seems like you missed one bracket haha

Actaully with that extra bracket i get tons of errors XD

[hecari]

Actaully with that extra bracket i get tons of errors XD

1) Technically, player.getMap().getCharacters() return a MapleCharacter type of ArrayList. So why not use

List<MapleCharacter> listOfCharacter = player.getMap().getCharacters(); 

2)Why do you even bothering converting it to array if you can get element based on the arrangement of the array.

MapleCharacter characterInList = charactersz.get(random); 

3) Randomising

int random = (int) Randomizer.rand(0, listOfCharacter.size()); 

4) For the broadcasting, just use a for loop to output to everyone to be safe. (the problem might be your broadcastMessage), debug it to get the problem.

for(MapleCharacter chr : player.getMap().getCharacters()) {
     chr.dropMessage("lalalala");
} 

5) As on getting the name

characterInList.getName();