OdinMS v55 getPet params inconsistent?

[al4nw31]

Hi,

I'm rewriting OdinMS v55 and want to release a more finished version, but I have no clue why it's called as getPet(void), while it's implemented in the class as getPet(int index)?

And I'm not familiar enough with how to get the current pet to rewrite the entire getPet function.

I'm also updating the whole source to use Apache Mina 2.0.16, and SLF4J 1.7.25.

Hopefully I can release a more robust version of OdinMS v55 for all of us to enjoy.

After I fix all of the errors I will try to fix most of the memory issues and write some more quests... Perhaps even re-code parts that have issues.

P.S. I'm working with IntelliJ IDEA 2017.1.1, but I'm pretty sure that doesn't matter.

[MentaL]

[sunnyboy]

Hi,

I'm rewriting OdinMS v55 and want to release a more finished version, but I have no clue why it's called as getPet(void), while it's implemented in the class as getPet(int index)?

And I'm not familiar enough with how to get the current pet to rewrite the entire getPet function.

I'm also updating the whole source to use Apache Mina 2.0.16, and SLF4J 1.7.25.

Hopefully I can release a more robust version of OdinMS v55 for all of us to enjoy.

After I fix all of the errors I will try to fix most of the memory issues and write some more quests... Perhaps even re-code parts that have issues.

P.S. I'm working with IntelliJ IDEA 2017.1.1, but I'm pretty sure that doesn't matter.

lol. my src is perfect for me.

You should use netty also

[al4nw31]

lol. my src is perfect for me.

You should use netty also

I mean, I've done a bunch of Java dev before, so I don't need tutorials to get around the IDE, so I'd prefer not to use NetBeans.

Does anyone have another copy of OdinMS v55 Rev 988 that I can look at? Maybe the one I got is bad?

[ExtremeDevilz]

I mean, I've done a bunch of Java dev before, so I don't need tutorials to get around the IDE, so I'd prefer not to use NetBeans.

Does anyone have another copy of OdinMS v55 Rev 988 that I can look at? Maybe the one I got is bad?

the odin rev988 never did pets coded, it was Danner the creator of OdinTeh who wrote Pets, the original odinms lack quite afew stuff, if you can you should write it yourself.

if you attempting to recreate a full odinms v55 experience, I would suggest probably best bet is to write your own, and you can do what you want with it, example afew of the original code was bad but back that was in 2008 which is like 9 years old. most of the veteran developer have either move on or retired. probably ask yourself what you really want to do with it ? if you want improve it I suggest tearing it apart and see what can be improve.

cheers.

[al4nw31]

the odin rev988 never did pets coded, it was Danner the creator of OdinTeh who wrote Pets, the original odinms lack quite afew stuff, if you can you should write it yourself.

if you attempting to recreate a full odinms v55 experience, I would suggest probably best bet is to write your own, and you can do what you want with it, example afew of the original code was bad but back that was in 2008 which is like 9 years old. most of the veteran developer have either move on or retired. probably ask yourself what you really want to do with it ? if you want improve it I suggest tearing it apart and see what can be improve.

cheers.

Is v62 architecture similar to v55? I can probably just look at LeaderMS and copy a lot of the language over since it's based off of Odin too. I can do a lot of adaptations too.

I was always planning on re-writing hundreds/thousands of lines of code.

[ExtremeDevilz]

Is v62 architecture similar to v55? I can probably just look at LeaderMS and copy a lot of the language over since it's based off of Odin too. I can do a lot of adaptations too.

I was always planning on re-writing hundreds/thousands of lines of code.

if you plan to do that, I suggest take a look at odinteh cause it was the direct fork of odinms before it died and before all the source went to shit, it is v75 but most of the development tools are available for that version

https://github.com/DannerrQ/OdinTeh

for the client you can find it around other developments. it depends on what you want to do with the source, either rewrite to use netty, removal of xml reading or use binary reading (in terms of speed) or mcdb ? maybe if you plan to really work on it you can always open source the project so people who are interested can contribute.

remember the best is to write your own code, since you will how it works and it wont cause any issues in the future :) given the seriousness you put in.

[al4nw31]

if you plan to do that, I suggest take a look at odinteh cause it was the direct fork of odinms before it died and before all the source went to shit, it is v75 but most of the development tools are available for that version

https://github.com/DannerrQ/OdinTeh

for the client you can find it around other developments. it depends on what you want to do with the source, either rewrite to use netty, removal of xml reading or use binary reading (in terms of speed) or mcdb ? maybe if you plan to really work on it you can always open source the project so people who are interested can contribute.

remember the best is to write your own code, since you will how it works and it wont cause any issues in the future :) given the seriousness you put in.

I've never done binary reading, and I'm not too familiar with mcdb, is there any resource you would recommend? I can do most of the coding, but once I hit databases and external data, I'm going to have to do some learning.

I will probably re-code big portions, but the problem is that the project is huge to re-write for one person, especially since I don't have a complete understanding of how everything works (yet).

- - - Updated - - -

if you plan to do that, I suggest take a look at odinteh cause it was the direct fork of odinms before it died and before all the source went to shit, it is v75 but most of the development tools are available for that version

https://github.com/DannerrQ/OdinTeh

for the client you can find it around other developments. it depends on what you want to do with the source, either rewrite to use netty, removal of xml reading or use binary reading (in terms of speed) or mcdb ? maybe if you plan to really work on it you can always open source the project so people who are interested can contribute.

remember the best is to write your own code, since you will how it works and it wont cause any issues in the future :) given the seriousness you put in.

Hm... It also seems that one big downside of Netty is that it's not as simple in UDP connections. Ah well, I suppose I will try to figure it out.

[ExtremeDevilz]

MCDB is a collection of data used by Private Servers inserted into SQL format, split into categories (tables) and loaded from the MapleStory WZ Files. MCDB can also be used as an alternative to the XML data loading done in OdinMS Java Based private servers, which compared to it is new, innovative and fast.

Or

NX (PKG4) Format Specification

The NX file format was designed with speediness and ease of reading in mind, to speed up loading times for anything that uses a node-tree-based data file format.

https://github.com/angelsl/ms-reNX <- C#

you can write your own for Java Version

0.75 MCDB -> https://mega.nz/#!G98mBJyT!D4isK2Rd2Dmzc2qQOC3dUkqZMie36DGhx3Hiqrzn6Dk

[al4nw31]

MCDB is a collection of data used by Private Servers inserted into SQL format, split into categories (tables) and loaded from the MapleStory WZ Files. MCDB can also be used as an alternative to the XML data loading done in OdinMS Java Based private servers, which compared to it is new, innovative and fast.

Or

NX (PKG4) Format Specification

The NX file format was designed with speediness and ease of reading in mind, to speed up loading times for anything that uses a node-tree-based data file format.

https://github.com/angelsl/ms-reNX <- C#

you can write your own for Java Version

0.75 MCDB -> https://mega.nz/#!G98mBJyT!D4isK2Rd2Dmzc2qQOC3dUkqZMie36DGhx3Hiqrzn6Dk

I'm very uneasy about switching from XML, simply because these other methods are not very well documented. I could very well end up running into issues that would lead me to scrap the whole project.

MCDB seems to be better, but I'm still not sure how easy it will be to dig up all the documentation, since it has been years since anyone has developed it.

[ExtremeDevilz]

I'm very uneasy about switching from XML, simply because these other methods are not very well documented. I could very well end up running into issues that would lead me to scrap the whole project.

MCDB seems to be better, but I'm still not sure how easy it will be to dig up all the documentation, since it has been years since anyone has developed it.

http://forum.ragezone.com/f427/relea...g-mcdb-634765/
http://forum.ragezone.com/f427/relea...g-mcdb-634764/
http://forum.ragezone.com/f427/relea...g-mcdb-634763/

Something to read about :

http://forum.ragezone.com/f683/lol-o...g-xmls-806634/

it is just loading from sql rather then xml using the mcdb, this are some that was written, you still have to do for maps,mobs and skills to notice some difference in your source.

[al4nw31]

http://forum.ragezone.com/f427/relea...g-mcdb-634765/
http://forum.ragezone.com/f427/relea...g-mcdb-634764/
http://forum.ragezone.com/f427/relea...g-mcdb-634763/

Something to read about :

http://forum.ragezone.com/f683/lol-o...g-xmls-806634/

it is just loading from sql rather then xml using the mcdb, this are some that was written, you still have to do for maps,mobs and skills to notice some difference in your source.

Well, the data is for v75, and I'm building a v55 source, and I have absolutely no idea what the difference in data should be...

- - - Updated - - -

http://forum.ragezone.com/f427/relea...g-mcdb-634765/
http://forum.ragezone.com/f427/relea...g-mcdb-634764/
http://forum.ragezone.com/f427/relea...g-mcdb-634763/

Something to read about :

http://forum.ragezone.com/f683/lol-o...g-xmls-806634/

it is just loading from sql rather then xml using the mcdb, this are some that was written, you still have to do for maps,mobs and skills to notice some difference in your source.

Also, I've just spent a day looking over the source, and because it uses so much stuff that isn't easy to rewrite, if I were to switch from MINA to Netty I would have to completely rewrite the packet handling.

- - - Updated - - -

http://forum.ragezone.com/f427/relea...g-mcdb-634765/
http://forum.ragezone.com/f427/relea...g-mcdb-634764/
http://forum.ragezone.com/f427/relea...g-mcdb-634763/

Something to read about :

http://forum.ragezone.com/f683/lol-o...g-xmls-806634/

it is just loading from sql rather then xml using the mcdb, this are some that was written, you still have to do for maps,mobs and skills to notice some difference in your source.

Alright, after thinking about this for a long time, I think I'm going to try to slowly recode the majority of the game. I'm going to have to do a lot of studying on packet work and how everything currently works, and how to implement MCDB and Netty properly.

[ExtremeDevilz]

yeah take your time to see what you can recode better :) all the best mate. cheers, would love to see some progress in the future..

[Fraysa]

Well, the data is for v75, and I'm building a v55 source, and I have absolutely no idea what the difference in data should be...

Data load shouldn't be your prime goal if you're aiming to fix OdinMS. Don't worry about it, @ExtremeDevilz is just butthurt it as he's been over 5 years ago.



Many people come and go with big promises but they tend to leave after a few weeks without any sign of activity so I wouldn't be surprised if that happens. Nevertheless, good luck to you and I hope you learn a thing or two from this. If you need any help - we're at your service.