Styler not able to change character into selected female hair

[Xelvos]

hi

so when someone choose a female hair (new one/known as fuck) it doesnt change their hair

i am not sure what i am doing wrong. may someone be able to help me fix it?

/*    This file is part of the OdinMS Maple Story Server
    Copyright (C) 2008 Patrick Huy <patrick.huy@frz.cc>
               Matthias Butz <matze@odinms.de>
               Jan Christian Meyer <vimes@odinms.de>


    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU Affero General Public License as
    published by the Free Software Foundation version 3 as published by
    the Free Software Foundation. You may not use, modify or distribute
    this program under any other version of the GNU Affero General Public
    License.


    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU Affero General Public License for more details.


    You should have received a copy of the GNU Affero General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
*/
/*
 * @Name         NimaKIN
 * @Author:      Signalize 
 * @Edited By:   Chilly
 * @NPC:         9900000
 * @Purpose:     Hair/Face/Eye Changer -- May set job as GM too
 * @GMSPurpose:  Sets one's job as a GM.
 * @Map:         180000000
 */
var status = 0;
var beauty = 0;
var haircolor = Array();
var skin = [0, 1, 2, 3, 4, 5, 9, 10];
var fhair= [31000, 31010, 31020, 31030, 31040, 31050, 31060, 31070, 31080, 31090, 31100, 31110, 31120, 31130, 31140, 31150, 31160, 31170, 31180, 31190, 31200, 31210, 31220, 31230, 31240, 31250, 31260, 31270, 31280, 31290, 31300, 31310, 31320, 31330, 31340, 31350, 31400, 31410, 31420, 31440, 31450, 31460, 31470, 31480, 31490, 31510, 31520, 31530, 31540, 31550, 31560, 31570, 31580, 31590, 31600, 31610, 31620, 31630, 31640, 31650, 31670, 31680, 31690, 31700, 31710, 31720, 31730, 31740, 31750, 31760, 31770, 31780, 31790, 31800, 31810, 31820, 31830, 31840, 31850, 31860, 31870, 31880, 31890, 31910, 31920, 31930, 31940, 31950, 34000, 34010, 34020, 34030, 34050, 34110];
var hair = [30000, 30010, 30020, 30030, 30040, 30050, 30060, 30100, 30110, 30120, 30130, 30140, 30150, 30160, 30170, 30180, 30190, 30200, 30210, 30220, 30230, 30240, 30250, 30260, 30270, 30280, 30290, 30300, 30310, 30320, 30330, 30340, 30350, 30360, 30370, 30400, 30410, 30420, 30440, 30450, 30460, 30470, 30480, 30490, 30510, 30520, 30530, 30540, 30550, 30560, 30570, 30580, 30590, 30600, 30610, 30620, 30630, 30640, 30650, 30660, 30670, 30680, 30690, 30700, 30710, 30720, 30730, 30740, 30750, 30760, 30770, 30780, 30790, 30800, 30810, 30820, 30830, 30840, 30850, 30860, 30870, 30880, 30890, 30900, 30910, 30920, 30930, 30940, 30950, 30990, 33000, 33040, 33100];
var hairnew = Array();
var hair2 = [34120, 34130, 34140, 34150, 34160, 34170, 34180, 34190, 34200, 34210, 34220, 34230, 34240, 34250, 34260, 34270, 34280, 34290, 34300, 34310, 34320, 34330, 34340, 34350, 34360, 34370, 34380, 34390, 34400, 34410, 34420, 34430, 34440, 34450, 34460, 34470, 34480, 34490, 34510, 34540, 34560, 34580, 34590, 34600, 34610, 34620, 34630, 34640, 34650, 34660, 34670, 34680, 34690, 34700, 34710, 34720, 34730, 34740, 34750, 34760, 34770, 34780, 34790, 34800, 34810, 34820, 34830, 34840, 34850, 34860, 34870, 34880, 34890, 34900, 34910, 34940, 34950, 34960, 34970, 34980, 34990];
var fuck = [33110, 33120, 33130, 33140, 33150, 33160, 33170, 33180, 33190, 33200, 33210, 33220, 33230, 33240, 33250, 33260, 33270, 33280, 33290, 33300, 33310, 33320, 33330, 33340, 33350, 33360, 33370, 33380, 33390, 33400, 33410, 33420, 33430, 33440, 33450, 33460, 33470, 33480, 33490, 33500, 33510, 33520, 33530, 33540, 33550, 33580, 33590, 33600, 33610, 33620, 33630, 33640, 33650, 33660, 33670, 33680, 33690, 33700, 33710, 33720, 33730, 33740, 33750, 33760, 33770, 33780, 33790, 33800, 33810, 33820, 33830, 33930, 33940, 33950, 33960, 33970, 33980, 33990];
var hairnew2 = Array();
var face = [20000, 20001, 20002, 20003, 20004, 20005, 20006, 20007, 20008, 20009, 20010, 20011, 20012, 20013, 20014, 20016, 20017, 20018, 20019, 20020, 20021, 20022, 20023, 20024, 20026, 20027, 20028, 20029, 20031, 20032, 20033, 20035, 20036, 20037, 20038, 20039, 20040, 20043, 20044, 20045, 20046, 20047, 20048, 20049, 20050, 20051, 20052, 20053, 20054, 20055, 20056, 20057, 20058, 20059, 20060, 20061, 20062, 20063, 20064, 20065, 20066, 20067, 20068, 20069, 20070, 20071, 20072, 20073, 20074, 20075, 20076, 20077, 20078, 20079, 20080, 20081, 20082, 20083, 20084, 20085, 20086, 20087, 20088, 20089, 20090, 20091, 20092, 20093, 20094, 20095, 20097, 20098, 20099];
var fface = [21000, 21001, 21002, 21003, 21004, 21005, 21006, 21007, 21008, 21009, 21010, 21011, 21012, 21013, 21014, 21016, 21017, 21018, 21019, 21020, 21021, 21022, 21024, 21025, 21026, 21027, 21029, 21030, 21031, 21033, 21034, 21035, 21036, 21037, 21038, 21041, 21042, 21043, 21044, 21045, 21046, 21047, 21048, 21049, 21050, 21051, 21052, 21053, 21054, 21055, 21056, 21057, 21058, 21059, 21060, 21061, 21062, 21063, 21064, 21065, 21066, 21067, 21068, 21069, 21070, 21071, 21072, 21073, 21074, 21075, 21076, 21077, 21078, 21079, 21080, 21081, 21082, 21083, 21084, 21085, 21086, 21087, 21088, 21089, 21090, 21091, 21092, 21093, 21094, 21095, 21096, 21097, 21098, 21099];
var facenew = Array();
var colors = Array();


function start() {
    cm.sendSimple("Hey there, I am the #eStylist#n of Distinctive. What would you like to change?\r\n#r#L0# Skin#l\r\n#L1# Male Hair#l\r\n#L5# Female Hair#l\r\n#L7# New Male Hair#l\r\n#L8# New Female Hair#l\r\n#L2# Hair Color#l\r\n#L3# Male Eyes#l\r\n#L6# Female Eyes#l\r\n#L4# Eye Color#l");
}


function action(mode, type, selection) {
    status++;
    if (mode != 1 || cm.getPlayer().gmLevel() < 1){
        cm.dispose();
        return;
    }
    if (status == 1) {
        beauty = selection + 1;
        if (selection == 0)
            cm.sendStyle("Pick one?", skin);
        else if (selection == 1 || selection == 5) {
            for each(var i in selection == 1 ? hair : fhair)
                hairnew.push(i);
            cm.sendStyle("Pick one?", hairnew);
        } else if (selection == 7 || selection == 8) {
            for each(var i in selection == 7 ? fuck : hair2)
                hairnew.push(i);
            cm.sendStyle("Pick one?", hairnew);            
        } else if (selection == 2) {
            for(var k = 0; k < 8; k++)
                haircolor.push(cm.getPlayer().getHair() + k);
            cm.sendStyle("Pick one?", haircolor);
        } else if (selection == 3 || selection == 6) {
            for each(var j in selection == 3 ? face : fface)
                facenew.push(j);
            cm.sendStyle("Pick one?", facenew);
        } else if (selection == 4) {
            for(var i = 0; i < 9; i++)
                colors.push(cm.getPlayer().getFace() + (i*100));
            cm.sendStyle("Pick one?", colors);
        } else if (selection == 10) {
            cm.getPlayer().changeJobById(910);
            cm.dispose();
        }
    } else if (status == 2){
        if (beauty == 1)
            cm.setSkin(skin[selection]);
        if (beauty == 2 || beauty == 5)
            cm.setHair(hairnew[selection]);
        if (beauty == 7 || beauty == 8)
            cm.setHair(hairnew2[selection]);            
        if (beauty == 3)
            cm.setHair(haircolor[selection]);
        if (beauty == 4 || beauty == 6)
            cm.setFace(facenew[selection]);
        if (beauty == 5)
            cm.setFace(colors[selection]);
        cm.dispose();
    }
}

[MentaL]

[Drum]

SORRY4LONGPOST. BUT LEARNING>LEECHING :D

I think your main problem was not knowing which variable/array you're referring to. You know what could help with that though, USE PROPER/INFORMATIVE NAMING CONVENTIONS! hehe.

In status 1, when you're testing selection == 7 || selection == 8, everything's fine there, but just remember that you've built the array called hairnew with all the male or female hair ids. Remember, it's called 'hairnew'.

In status 1, under beauty == 7 || beauty == 8, you tried referring to hairnew2, which is still a null array, so you need to use hairnew as your array to index out of.

Also, in status 1, remember beauty has been set to selection + 1. So in status 2, to deal with your new hair styles, I think you mean to test beauty == 8 || beauty == 9.

P.S. Really not sure about the method you're using to generate your colors, and haircolor array. I understand why you've done it this way (so the player always starts at their current hair color, yeah?), but from looking at ids online, it looks like it could break sometimes.
Here's a breaking case for haircolor; say cm.getPlayer().getHair() returns 30057. So hair color would be generated as haircolor = [30057, 30058, 30059, and so on...]. I don't have to write all of that out, I can already see that 30058 is an invalid ID, so it will crash the player.

It would be a little ridiculous to store all of these values for every different color in one file, so I'd advise you have a really good look at the IDs for different colors and styles, and see whether any reliable patterns exist. Few other random things in this script that seem a bit weird, but I won't bother, since it doesn't have anything to do with it's functionality. Good luck!

[Xelvos]

SORRY4LONGPOST. BUT LEARNING>LEECHING :D

I think your main problem was not knowing which variable/array you're referring to. You know what could help with that though, USE PROPER/INFORMATIVE NAMING CONVENTIONS! hehe.

In status 1, when you're testing selection == 7 || selection == 8, everything's fine there, but just remember that you've built the array called hairnew with all the male or female hair ids. Remember, it's called 'hairnew'.

In status 1, under beauty == 7 || beauty == 8, you tried referring to hairnew2, which is still a null array, so you need to use hairnew as your array to index out of.

Also, in status 1, remember beauty has been set to selection + 1. So in status 2, to deal with your new hair styles, I think you mean to test beauty == 8 || beauty == 9.

P.S. Really not sure about the method you're using to generate your colors, and haircolor array. I understand why you've done it this way (so the player always starts at their current hair color, yeah?), but from looking at ids online, it looks like it could break sometimes.
Here's a breaking case for haircolor; say cm.getPlayer().getHair() returns 30057. So hair color would be generated as haircolor = [30057, 30058, 30059, and so on...]. I don't have to write all of that out, I can already see that 30058 is an invalid ID, so it will crash the player.

It would be a little ridiculous to store all of these values for every different color in one file, so I'd advise you have a really good look at the IDs for different colors and styles, and see whether any reliable patterns exist. Few other random things in this script that seem a bit weird, but I won't bother, since it doesn't have anything to do with it's functionality. Good luck!

thanks man! i got it working cus of u :D

[Drum]

thanks man! i got it working cus of u :D

Sweet man! I'm curious, how did you solve the issue of generating invalid hair/eye color ids?