[V.117]Error with Auto-Register

[GoTSkillzInIT]

What's wrong with this auto-register?

package handling.login.handler;

import client.LoginCrypto;
import client.MapleClient;
import database.DatabaseConnection;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;






public class AutoRegister {
        private static final int ACCOUNTS_PER_IP = 100; //change the value to the amount of accounts you want allowed for each ip
        public static final boolean autoRegister = true; //enable = true or disable = false


        public static boolean success = false; // DONT CHANGE
        
        public static boolean getAccountExists(String login) {
                boolean accountExists = false;
                Connection con = DatabaseConnection.getConnection();
                try {
                        PreparedStatement ps = con.prepareStatement("SELECT name FROM accounts WHERE name = ?");
                        ps.setString(1, login);
                        ResultSet rs = ps.executeQuery();
                        if(rs.first()) {
                        accountExists = true;
                    }
                } catch (Exception ex) {
                      System.out.println(ex);
                }
                return accountExists;
        }


        public static void createAccount(String login, String pwd, String eip) {
                String sockAddr = eip;
                Connection con;


                //connect to database or halt
                try {
                        con = DatabaseConnection.getConnection();
                } catch (Exception ex) {
                        System.out.println(ex);
                        return;
                }


                try {
            ResultSet rs;
            try (PreparedStatement ipc = con.prepareStatement("SELECT SessionIP FROM accounts WHERE SessionIP = ?")) {
                ipc.setString(1, sockAddr.substring(1, sockAddr.lastIndexOf(':')));
                rs = ipc.executeQuery();
                if (rs.first() == false || rs.last() == true && rs.getRow() < ACCOUNTS_PER_IP) {
                        try {
                        try (PreparedStatement ps = con.prepareStatement("INSERT INTO accounts (name, password, email, birthday, macs, SessionIP) VALUES (?, ?, ?, ?, ?, ?)")) {
                            ps.setString(1, login);
                            ps.setString(2, LoginCrypto.hexSha1(pwd));
                            ps.setString(3, "no@email.provided");
                            ps.setString(4, "2008-04-07");
                            ps.setString(5, "00-00-00-00-00-00");
                          ///  ps.setInt(6, 123456);
                            ps.setString(6, sockAddr.substring(1, sockAddr.lastIndexOf(':')));
                            ps.executeUpdate();
                        }


                                success = true;
                        } catch (SQLException ex) {
                                System.out.println(ex);
                                return;
                        }
                }
            }
                        rs.close();
                } catch (SQLException ex) {
                        System.out.println(ex);
                }
        }
}

[MentaL]

[Ambition]

What's the error?

[GoTSkillzInIT]

"This is not a registered ID" when trying to make new accounts with auto-register.

[Ambition]

"This is not a registered ID" when trying to make new accounts with auto-register.

Did you modify your CharLoginHandler.java?

[GoTSkillzInIT]

You mean this ?

if (AutoRegister.getAccountExists(login)) { loginok = c.login(login, pwd, isBanned);
} else if (AutoRegister.autoRegister != true && !isBanned) {
AutoRegister.createAccount(login, pwd, c.getSession().getRemoteAddress().toString());
if (AutoRegister.success) {
loginok = c.login(login, pwd, isBanned);
}
}

[Ambition]

You mean this ?

Yeah, replace that with:

Spoiler:

if (AutoRegister.autoRegister && !AutoRegister.getAccountExists(login) && (!c.hasBannedIP() || !c.hasBannedMac())) {            AutoRegister.createAccount(login, pwd, c.getSession().getRemoteAddress().toString());
            if (AutoRegister.success) {
                c.getSession().write(CWvsContext.serverNotice(1, "Your account has been successfully created!\r\nPlease login again to enter your new account."));
                c.getSession().write(LoginPacket.getLoginFailed(1)); //Shows no message, used for unstuck the login button
                return;
            }
        } else {
            loginok = c.login(login, pwd, ipBan || macBan);
        }

Ripped from JudoMS Source

[GoTSkillzInIT]

Cannot Find Symbol

Symbol : Variable ip ban
location class charloginhandler

and same thing for macban

EDIT ~~ Added the symbols, testing.

[Ambition]

Cannot Find Symbol

Symbol : Variable ip ban
location class charloginhandler

and same thing for macban

Replace:

loginok = c.login(login, pwd, ipBan || macBan);

With:

loginok = c.login(login, pwd, c.hasBannedIP() || c.hasBannedMac());

[GoTSkillzInIT]

Still the same error , "This is not a registered ID"

[Ambition]

Still the same error , "This is not a registered ID"

That's weird, mine is working perfectly fine with same codes. Can you do me a favor a post your entire CharLoginHandler.java?

[GoTSkillzInIT]

Sure , here it is.

/* This file is part of the OdinMS Maple Story Server
Copyright (C) 2008 ~ 2010 Patrick Huy <patrick.huy@frz.cc>
Matthias Butz <matze@odinms.de>
Jan Christian Meyer <vimes@odinms.de>


This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Affero General Public License version 3
as published by the Free Software Foundation. You may not use, modify
or distribute this program under any other version of the
GNU Affero General Public License.


This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Affero General Public License for more details.


You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package handling.login.handler;


import client.*;
import client.inventory.Item;
import client.inventory.MapleInventory;
import client.inventory.MapleInventoryType;
import constants.GameConstants;
import database.DatabaseConnection;
import handling.channel.ChannelServer;
import handling.channel.PlayerStorage;
import handling.login.LoginInformationProvider;
import handling.login.LoginInformationProvider.JobType;
import handling.login.LoginServer;
import handling.login.LoginWorker;
import handling.world.World;
import java.net.InetAddress;
import java.net.UnknownHostException;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.util.*;
import java.util.Map.Entry;
import java.util.logging.Level;
import java.util.logging.Logger;
import server.MapleItemInformationProvider;
import server.Timer.EtcTimer;
import server.quest.MapleQuest;
import tools.FileoutputUtil;
import tools.Pair;
import tools.data.LittleEndianAccessor;
import tools.packet.CField;
import tools.packet.CWvsContext;
import tools.packet.LoginPacket;
import tools.packet.LoginPacket.Server;
import tools.packet.PacketHelper;


public class CharLoginHandler {
public static String fakeBan = "";
public static Server world = Server.Bera;


private static boolean loginFailCount(final MapleClient c) {
c.loginAttempt++;
if (c.loginAttempt > 5) {
return true;
}
return false;
}


public static void login(final LittleEndianAccessor slea, final MapleClient c) {
int loginok = 0;
String login = slea.readMapleAsciiString();
String pwd = slea.readMapleAsciiString();
String unstuck = "unstuckme";
boolean isBanned = c.hasBannedIP() || c.hasBannedMac();
// final Calendar tempbannedTill = c.getTempBanCalendar();
final boolean ipBan = c.hasBannedIP();
final boolean macBan = c.hasBannedMac();


if (!AutoRegister.getAccountExists(login)) {
c.getSession().write(LoginPacket.getLoginFailed(5));
return;
}
if (AutoRegister.autoRegister && !AutoRegister.getAccountExists(login) && (!c.hasBannedIP() || !c.hasBannedMac())) { AutoRegister.createAccount(login, pwd, c.getSession().getRemoteAddress().toString());
if (AutoRegister.success) {
c.getSession().write(CWvsContext.serverNotice(1, "Your account has been successfully created!\r\nPlease login again to enter your new account."));
c.getSession().write(LoginPacket.getLoginFailed(1)); //Shows no message, used for unstuck the login button
return;
}
} else {
loginok = c.login(login, pwd, c.hasBannedIP() || c.hasBannedMac());
}
if (loginok == 0 && isBanned) { // just incase? o.o
loginok = 3;
MapleCharacter.ban(c.getSession().getRemoteAddress().toString().split(":")[0], "Enforcing account ban, account ", false);
}
/*if (!c.hasAcceptedToS()) {
c.getSession().write(LoginPacket.getLoginFailed(23));
//c.acceptedToS();
return;
}*/
if ((pwd == null ? unstuck == null : pwd.equals(unstuck)) || (pwd == unstuck)) {
c.disconnect(true, true); // wtf is removeinchannelserver..?
int uid = 0;
try {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("UPDATE accounts SET loggedin = ? WHERE name = ?");
ps.setString(2, login);
ps.setInt(1, uid);
ps.executeUpdate();
ps.close();
c.announce(CWvsContext.serverNotice(1, "Your account has been unstuck!"));
c.getSession().write(LoginPacket.getLoginFailed(1)); //Shows no message, used for unstuck the login button
return;
} catch (SQLException ex) {
Logger.getLogger(CharLoginHandler.class.getName()).log(Level.SEVERE, null, ex);
}
}
if (loginok != 0) {
if (!loginFailCount(c)) {
c.clearInformation();
c.getSession().write(LoginPacket.getLoginFailed(loginok));
} else {
c.getSession().close(true);
}
} else if (isBanned) {
c.announce(LoginPacket.getLoginFailed(3));
/*
// this is broken #remove
} else if (tempbannedTill.getTimeInMillis() != 0) {
if (!loginFailCount(c)) {
c.clearInformation();
c.getSession().write(LoginPacket.getTempBan(PacketHelper.getTime(tempbannedTill.getTimeInMillis()), c.getBanReason()));
} else {
c.getSession().close(true);
}*/
} else {
c.loginAttempt = 0;
LoginWorker.registerClient(c);
}
}


public static void ServerListRequest(final MapleClient c) {
c.getSession().write(LoginPacket.getLoginWelcome());
for (World iWorld : LoginServer.getWorlds()) {
c.getSession().write(LoginPacket.getServerList(iWorld.getWorldId(), Server.getById(iWorld.getWorldId()).toString(), iWorld.getFlag(), iWorld.getEventMessage(), iWorld.getChannels()));
}
c.getSession().write(LoginPacket.getEndOfServerList());
c.getSession().write(LoginPacket.selectWorld(1)); // TODO: last world selected
String eventMessage = LoginServer.getInstance().getWorld(0).getEventMessage();
eventMessage = eventMessage.replaceAll("#b", "");
eventMessage = eventMessage.replaceAll("#r", "");
eventMessage = eventMessage.replaceAll("#k", "");
c.getSession().write(LoginPacket.sendRecommended(world.getId(), eventMessage));
}


public static void ServerStatusRequest(final LittleEndianAccessor slea, final MapleClient c) {
// 0 = Select world normally
// 1 = "Since there are many users, you may encounter some..."
// 2 = "The concurrent users in this world have reached the max"
final int worldId = slea.readByte();
final List<Integer> count = new ArrayList<>();
PlayerStorage strg = LoginServer.getInstance().getWorld(worldId).getPlayerStorage();
for (MapleCharacter chrs : strg.getAllCharacters()) {
if (chrs.getClient().getWorld() == worldId) {
count.add(chrs.getId());
}
}
final int numPlayer = count.size();
final int userLimit = LoginServer.getInstance().getWorld(worldId).getUserLimit();
if (numPlayer >= userLimit) {
c.getSession().write(LoginPacket.getServerStatus(2));
} else if (numPlayer * 2 >= userLimit) {
c.getSession().write(LoginPacket.getServerStatus(1));
} else {
c.getSession().write(LoginPacket.getServerStatus(0));
}
}


public static void CharlistRequest(final LittleEndianAccessor slea, final MapleClient c) {
if (!c.isLoggedIn()) {
c.getSession().close(true);
return;
}

if (GameConstants.GMS) {
slea.readByte(); //2?
}
final int server = slea.readByte();
world = Server.getById(server);
final int channel = slea.readByte() + 1;
//System.out.println("Client " + c.getSession().getRemoteAddress().toString().split(":")[0] + " is connecting to server " + server + " channel " + channel + "");
FileoutputUtil.log("LogIPs.txt","\r\nIP Address : " + c.getSession().getRemoteAddress().toString().split(":")[0] + " | Account : " + c.getAccountName() + "\r\n");


final List<MapleCharacter> chars = c.loadCharacters(server);
if (chars != null && ChannelServer.getInstance(server, channel) != null) {
c.setWorld(server);
c.setChannel(channel);
c.getSession().write(LoginPacket.getSecondAuthSuccess(c));
c.getSession().write(LoginPacket.getCharList(c.getSecondPassword(), chars, 15));
} else {
c.getSession().close(true);
}
}


public static void CheckCharName(final String name, final MapleClient c) {
c.getSession().write(LoginPacket.charNameResponse(name, !(MapleCharacterUtil.canCreateChar(name, c.isGm()) && (!LoginInformationProvider.getInstance().isForbiddenName(name) || c.isGm()))));
}


public static void CreateChar(final LittleEndianAccessor slea, final MapleClient c) {
if (!c.isLoggedIn()) {
c.getSession().close(true);
return;
}
final String name = slea.readMapleAsciiString();
final JobType jobType = JobType.getByType(slea.readInt()); // BIGBANG: 0 = Resistance, 1 = Adventurer, 2 = Cygnus, 3 = Aran, 4 = Evan, 5 = mercedes
final short db = slea.readShort(); //whether dual blade = 1 or adventurer = 0
final byte gender = slea.readByte(); //??idk corresponds with the thing in addCharStats
byte skinColor = slea.readByte(); // 01
int hairColor = 0;
int weapon3 = 0;
final byte unk2 = slea.readByte(); // 08
boolean jettPhantom = (jobType == LoginInformationProvider.JobType.Phantom);
final int face = slea.readInt();
final boolean mercedes = (jobType == JobType.Mercedes);
final boolean demon = (jobType == JobType.Demon);
final int hair = slea.readInt();
if (!jettPhantom && !mercedes && !demon) { //mercedes/demon dont need hair color since its already in the hair
hairColor = slea.readInt();
skinColor = (byte) slea.readInt();
}
final int demonMark = demon ? slea.readInt() : 0;
final int top = slea.readInt();
final int bottom = slea.readInt();
final int shoes = slea.readInt();
final int weapon = slea.readInt();
if (jettPhantom) {
weapon3 = slea.readInt();
}


int shield = jobType == LoginInformationProvider.JobType.Phantom ? 1352100 : mercedes ? 1352000 : demon ? slea.readInt() : 0;
if (jobType == JobType.Demon) {
if (!LoginInformationProvider.getInstance().isEligibleItem(gender, 0, jobType.type, face) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 1, jobType.type, hair)
|| !LoginInformationProvider.getInstance().isEligibleItem(gender, 2, jobType.type, demonMark) || (skinColor != 0 && skinColor != 13)
|| !LoginInformationProvider.getInstance().isEligibleItem(gender, 3, jobType.type, top) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 4, jobType.type, shoes)
|| !LoginInformationProvider.getInstance().isEligibleItem(gender, 5, jobType.type, weapon) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 6, jobType.type, shield)) {
return;
}
} else if (jobType == JobType.Mercedes) {
if (!LoginInformationProvider.getInstance().isEligibleItem(gender, 0, jobType.type, face) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 1, jobType.type, hair)
|| !LoginInformationProvider.getInstance().isEligibleItem(gender, 2, jobType.type, top) || (skinColor != 0 && skinColor != 12)
|| !LoginInformationProvider.getInstance().isEligibleItem(gender, 3, jobType.type, shoes) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 4, jobType.type, weapon)) {
return;
}
} else if (jobType != JobType.Phantom) {
if (!LoginInformationProvider.getInstance().isEligibleItem(gender, 0, jobType.type, face) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 1, jobType.type, hair)
|| !LoginInformationProvider.getInstance().isEligibleItem(gender, 2, jobType.type, hairColor) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 3, jobType.type, skinColor)
|| !LoginInformationProvider.getInstance().isEligibleItem(gender, 4, jobType.type, top) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 5, jobType.type, bottom)
|| !LoginInformationProvider.getInstance().isEligibleItem(gender, 6, jobType.type, shoes) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 7, jobType.type, weapon)) {
return;
}
}
MapleCharacter newchar = MapleCharacter.getDefault(c, jobType);
newchar.setWorld((byte) world.getId());
newchar.setFace(face);
newchar.setHair(hair + hairColor);
newchar.setGender(gender);
newchar.setName(name);
newchar.setSkinColor(skinColor);
newchar.setDemonMarking(demonMark);


if (newchar.getCustomFace() || newchar.getCustomHair()) {
World.Broadcast.broadcastMessage(newchar.getWorld(), CWvsContext.serverNotice(6, "[AutoBan] Hahaha some new player tried packet editing their eyes! Let's laugh at their ban!"));
c.banMacs(); //Cheat custom faces/hairs..
c.getSession().close();
return;
}

final MapleItemInformationProvider li = MapleItemInformationProvider.getInstance();
final MapleInventory equip = newchar.getInventory(MapleInventoryType.EQUIPPED);


Item item = li.getEquipById(top);
item.setPosition((byte) -5);
equip.addFromDB(item);


if (bottom > 0) { //resistance have overall
item = li.getEquipById(bottom);
item.setPosition((byte) (jettPhantom ? -5 : -6));
equip.addFromDB(item);
}


item = li.getEquipById(shoes);
item.setPosition((byte) (jettPhantom ? -9 : -7));
equip.addFromDB(item);


item = li.getEquipById(weapon);
item.setPosition((byte) (jettPhantom ? -7 : -11));
equip.addFromDB(item);


if (weapon3 > 0) {
item = li.getEquipById(weapon3);
item.setPosition((byte) (-11));
equip.addFromDB(item);
}


if (shield > 0) {
item = li.getEquipById(shield);
item.setPosition((byte) -10);
equip.addFromDB(item);
}


newchar.getInventory(MapleInventoryType.USE).addItem(new Item(2000013, (byte) 0, (short) 100, (byte) 0));
newchar.getInventory(MapleInventoryType.USE).addItem(new Item(2000014, (byte) 0, (short) 100, (byte) 0));


// if ((!newchar.hasEquipped(top)) && (!newchar.hasEquipped(weapon))) {
// World.Broadcast.broadcastMessage(CWvsContext.serverNotice(6, "[AutoBan] Hahaha some new player tried packet editing their equips! Let's laugh at there ban!"));
// c.banMacs();
// c.getSession().close();
// return;
// }

if (MapleCharacterUtil.canCreateChar(name, c.isGm()) && (!LoginInformationProvider.getInstance().isForbiddenName(name) || c.isGm()) && (c.isGm() || c.canMakeCharacter(c.getWorld()))) {
MapleCharacter.saveNewCharToDB(newchar, jobType, db);
c.getSession().write(LoginPacket.addNewCharEntry(newchar, true));
c.createdChar(newchar.getId());
} else {
c.getSession().write(LoginPacket.addNewCharEntry(newchar, false));
}
c.changeSecondPassword();
c.updateSecondPassword();
}


public static final void CreateUltimate(final LittleEndianAccessor slea, final MapleClient c) {
if (!c.isLoggedIn() || c.getPlayer() == null || c.getPlayer().getLevel() < 120 || c.getPlayer().getMapId() != 130000000 || !GameConstants.isKOC(c.getPlayer().getJob()) || !c.canMakeCharacter(c.getPlayer().getWorld())) {
c.getPlayer().dropMessage(1, "You have no character slots.");
c.getSession().write(CField.createUltimate(1));
return;
}
//System.out.println(slea.toString());
final String name = slea.readMapleAsciiString();
final int job = slea.readInt(); //job ID

final int face = slea.readInt();
final int hair = slea.readInt();


final int hat = slea.readInt();
final int top = slea.readInt();
final int glove = slea.readInt();
final int shoes = slea.readInt();
final int weapon = slea.readInt();


final byte gender = c.getPlayer().getGender();
JobType jobType = JobType.Adventurer;
//if (!LoginInformationProvider.getInstance().isEligibleItem(gender, 0, jobType.type, face) || !LoginInformationProvider.getInstance().isEligibleItem(gender, 1, jobType.type, hair)) {
// c.getPlayer().dropMessage(1, "An error occurred.");
// c.getSession().write(CField.createUltimate(0));
// return;
//}


jobType = JobType.UltimateAdventurer;



MapleCharacter newchar = MapleCharacter.getDefault(c, jobType);
newchar.setJob(job);
newchar.setWorld((byte) c.getPlayer().getWorld());
newchar.setFace(face);
newchar.setHair(hair);
newchar.setGender(gender);
newchar.setName(name);
newchar.setSkinColor((byte) 3); //troll
newchar.setLevel((short) 50);
newchar.getStat().str = (short) 4;
newchar.getStat().dex = (short) 4;
newchar.getStat().int_ = (short) 4;
newchar.getStat().luk = (short) 4;
newchar.setRemainingAp((short) 254); //49*5 + 25 - 16
newchar.setRemainingSp(job / 100 == 2 ? 128 : 122); //2 from job advancements. 120 from leveling. (mages get +6)
newchar.getStat().maxhp += 150; //Beginner 10 levels
newchar.getStat().maxmp += 125;
newchar.getStat().hp += 150; //Beginner 10 levels
newchar.getStat().mp += 125;
switch (job) {
case 110:
case 120:
case 130:
newchar.getStat().maxhp += 600; //Job Advancement
newchar.getStat().maxhp += 2000; //Levelup 40 times
newchar.getStat().maxmp += 200;
newchar.getStat().hp += 600; //Job Advancement
newchar.getStat().hp += 2000; //Levelup 40 times
newchar.getStat().mp += 200;
break;
case 210:
case 220:
case 230:
newchar.getStat().maxmp += 600;
newchar.getStat().maxhp += 500; //Levelup 40 times
newchar.getStat().maxmp += 2000;
newchar.getStat().mp += 600;
newchar.getStat().hp += 500; //Levelup 40 times
newchar.getStat().mp += 2000;
break;
case 310:
case 320:
case 410:
case 420:
case 520:
newchar.getStat().maxhp += 500;
newchar.getStat().maxmp += 250;
newchar.getStat().maxhp += 900; //Levelup 40 times
newchar.getStat().maxmp += 600;
newchar.getStat().maxhp += 500;
newchar.getStat().mp += 250;
newchar.getStat().hp += 900; //Levelup 40 times
newchar.getStat().mp += 600;
break;
case 510:
newchar.getStat().maxhp += 500;
newchar.getStat().maxmp += 250;
newchar.getStat().maxhp += 450; //Levelup 20 times
newchar.getStat().maxmp += 300;
newchar.getStat().maxhp += 800; //Levelup 20 times
newchar.getStat().maxmp += 400;
newchar.getStat().hp += 500;
newchar.getStat().mp += 250;
newchar.getStat().hp += 450; //Levelup 20 times
newchar.getStat().mp += 300;
newchar.getStat().hp += 800; //Levelup 20 times
newchar.getStat().mp += 400;
break;
default:
return;
}
for (int i = 2490; i < 2507; i++) {
newchar.setQuestAdd(MapleQuest.getInstance(i), (byte) 2, null);
}
newchar.setQuestAdd(MapleQuest.getInstance(29947), (byte) 2, null);
newchar.setQuestAdd(MapleQuest.getInstance(GameConstants.ULT_EXPLORER), (byte) 0, c.getPlayer().getName());


final Map<Skill, SkillEntry> ss = new HashMap<>();
ss.put(SkillFactory.getSkill(1074 + (job / 100)), new SkillEntry((byte) 5, (byte) 5, -1));
ss.put(SkillFactory.getSkill(1195 + (job / 100)), new SkillEntry((byte) 5, (byte) 5, -1));
ss.put(SkillFactory.getSkill(80), new SkillEntry((byte) 1, (byte) 1, -1));
newchar.changeSkillLevel_Skip(ss, false);
final MapleItemInformationProvider li = MapleItemInformationProvider.getInstance();


int[] items = new int[]{1142257, hat, top, shoes, glove, weapon, hat + 1, top + 1, shoes + 1, glove + 1, weapon + 1}; //brilliant = fine+1
for (byte i = 0; i < items.length; i++) {
Item item = li.getEquipById(items[i]);
item.setPosition((byte) (i + 1));
newchar.getInventory(MapleInventoryType.EQUIP).addFromDB(item);
}
newchar.getInventory(MapleInventoryType.USE).addItem(new Item(2000004, (byte) 0, (short) 100, (byte) 0));
newchar.getInventory(MapleInventoryType.USE).addItem(new Item(2000004, (byte) 0, (short) 100, (byte) 0));
c.getPlayer().fakeRelog();
if (MapleCharacterUtil.canCreateChar(name, c.isGm()) && (!LoginInformationProvider.getInstance().isForbiddenName(name) || c.isGm()) && (c.isGm() || c.canMakeCharacter(c.getWorld()))) {
MapleCharacter.saveNewCharToDB(newchar, jobType, (short) 0);
c.createdChar(newchar.getId());
MapleQuest.getInstance(20734).forceComplete(c.getPlayer(), 1101000);
c.getSession().write(CField.createUltimate(0));
} else {
c.getSession().write(CField.createUltimate(1));
}
}


public static void DeleteChar(final LittleEndianAccessor slea, final MapleClient c) {
String Secondpw_Client = GameConstants.GMS ? slea.readMapleAsciiString() : null;
if (Secondpw_Client == null) {
if (slea.readByte() > 0) { // Specific if user have second password or not
Secondpw_Client = slea.readMapleAsciiString();
}
slea.readMapleAsciiString();
}


final int Character_ID = slea.readInt();


if (!c.login_Auth(Character_ID) || !c.isLoggedIn() || loginFailCount(c)) {
c.getSession().close(true);
return; // Attempting to delete other character
}
byte state = 0;


if (c.getSecondPassword() != null) { // On the server, there's a second password
if (Secondpw_Client == null) { // Client's hacking
c.getSession().close(true);
return;
} else {
if (!c.CheckSecondPassword(Secondpw_Client)) { // Wrong Password
state = 20;
}
}
}


if (state == 0) {
state = (byte) c.deleteCharacter(Character_ID);
}
c.getSession().write(LoginPacket.deleteCharResponse(Character_ID, state));
}


public static final void Character_WithoutSecondPassword(final LittleEndianAccessor slea, final MapleClient c, final boolean haspic, final boolean view) {
slea.readByte(); // 1?
slea.readByte(); // 1?
final int charId = slea.readInt();
if (view) {
c.setChannel(1);
c.setWorld(slea.readInt());
}
final String currentpw = c.getSecondPassword();
if (!c.isLoggedIn() || loginFailCount(c) || (currentpw != null && (!currentpw.equals("") || haspic)) || !c.login_Auth(charId) || ChannelServer.getInstance(c.getWorld(), c.getChannel()) == null || c.getWorld() != world.getId()) { // TODOO: MULTI WORLDS
c.getSession().close();
return;
}
c.updateMacs(slea.readMapleAsciiString());
slea.readMapleAsciiString();
if (slea.available() != 0) {
final String setpassword = slea.readMapleAsciiString();


if (setpassword.length() >= 6 && setpassword.length() <= 16) {
c.setSecondPassword(setpassword);
c.updateSecondPassword();
} else {
c.getSession().write(LoginPacket.secondPwError((byte) 0x14));
return;
}
} else if (GameConstants.GMS && haspic) {
return;
}
if (c.getIdleTask() != null) {
c.getIdleTask().cancel(true);
}
final String s = c.getSessionIPAddress();
LoginServer.putLoginAuth(charId, s.substring(s.indexOf('/') + 1, s.length()), c.getTempIP());
c.updateLoginState(MapleClient.LOGIN_SERVER_TRANSITION, s);
String[] socket = LoginServer.getInstance().getIP(c.getWorld(), c.getChannel()).split(":");
try {
c.announce(CField.getServerIP(c, InetAddress.getByName(socket[0]), Integer.parseInt(socket[1]), charId));
} catch (UnknownHostException | NumberFormatException e) {
}
}


public static final void Character_WithSecondPassword(final LittleEndianAccessor slea, final MapleClient c, final boolean view) {
final String password = slea.readMapleAsciiString();
final int charId = slea.readInt();
if (view) {
c.setChannel(1);
c.setWorld(slea.readInt());
}
if (!c.isLoggedIn() || loginFailCount(c) || c.getSecondPassword() == null || !c.login_Auth(charId) || ChannelServer.getInstance(c.getWorld(), c.getChannel()) == null || c.getWorld() != world.getId()) { // TODOO: MULTI WORLDS
c.getSession().close();
return;
}
if (GameConstants.GMS) {
c.updateMacs(slea.readMapleAsciiString());
}
if (c.CheckSecondPassword(password) && password.length() >= 6 && password.length() <= 16) {
if (c.getIdleTask() != null) {
c.getIdleTask().cancel(true);
}
final String s = c.getSessionIPAddress();
LoginServer.putLoginAuth(charId, s.substring(s.indexOf('/') + 1, s.length()), c.getTempIP());
c.updateLoginState(MapleClient.LOGIN_SERVER_TRANSITION, s);

String[] socket = LoginServer.getInstance().getIP(c.getWorld(), c.getChannel()).split(":");
try {
c.announce(CField.getServerIP(c, InetAddress.getByName(socket[0]), Integer.parseInt(socket[1]), charId));
} catch (UnknownHostException | NumberFormatException e) {
}
} else {
c.getSession().write(LoginPacket.secondPwError((byte) 0x14));
}
}


/* */ public static void PartTimeJob(LittleEndianAccessor slea, MapleClient c) {
/* 234 */ boolean complete = slea.readByte() == 2;
/* 235 */ int charId = slea.readInt();
/* 236 */ int type = slea.readByte();


/* 241 */ Pair info = c.getPartTimeJob(charId);
/* 242 */ if (complete) {
/* 243 */ if ((((Byte) info.getLeft()).byteValue() <= 0) || (((Long) info.getRight()).longValue() <= -2)) {
System.out.println("7");
/* 244 */ c.getSession().write(LoginPacket.partTimeJobRequest(charId, 3, 0, 0, false, false));
/* 245 */ return;
/* */ }
/* 247 */ int hoursFromLogin = Math.min((int) ((System.currentTimeMillis() - ((Long) info.getRight()).longValue()) / 3600000L), 6);
/* 248 */ boolean insert = c.updatePartTimeJob(charId, (byte) (hoursFromLogin > 0 ? -((Byte) info.getLeft()).byteValue() : 0), hoursFromLogin > 0 ? -hoursFromLogin - 10 : -2);
/* 249 */ if (insert) {
System.out.println("6");
c.getSession().write(LoginPacket.partTimeJobRequest(charId, 0, 0, ((Long) info.getRight()).longValue(), hoursFromLogin != 0, hoursFromLogin == 6));
} /* */ else {
System.out.println("5");
c.getSession().write(LoginPacket.partTimeJobRequest(charId, 2, 0, 0, false, false));
}
/* */ } /* */ else {
/* 255 */ if ((((Byte) info.getLeft()).byteValue() > 0) || (((Long) info.getRight()).longValue() > 0L) || (!c.canMakePartTimeJob())) {
System.out.println("1");
/* 256 */ c.getSession().write(LoginPacket.partTimeJobRequest(charId, 3, 0, 0, false, false));
/* 257 */ return;
/* */ }
/* 259 */ if (((Byte) info.getLeft()).byteValue() < 0) {
System.out.println("2");
/* 260 */ c.getSession().write(LoginPacket.partTimeJobRequest(charId, 1, 0, 0, false, false));
/* 261 */ return;
/* */ }
/* 263 */ long start = System.currentTimeMillis();
/* 264 */ boolean insert = c.updatePartTimeJob(charId, (byte) type, start);
/* 265 */ if (insert) {
System.out.println("3");
c.getSession().write(LoginPacket.partTimeJobRequest(charId, 0, type, start, false, false));
} /* */ else {
System.out.println("4");
c.getSession().write(LoginPacket.partTimeJobRequest(charId, 2, 0, 0, false, false));
}
/* */ }
/* */ }


public static void ViewChar(LittleEndianAccessor slea, MapleClient c) {
Map<Byte, ArrayList<MapleCharacter>> worlds = new HashMap<>();
List<MapleCharacter> chars = c.loadCharacters(world.getId()); //TODO multi world
c.getSession().write(LoginPacket.showAllCharacter(chars.size()));
for (MapleCharacter chr : chars) {
if (chr != null) {
ArrayList<MapleCharacter> chrr;
if (!worlds.containsKey(chr.getWorld())) {
chrr = new ArrayList<>();
worlds.put(chr.getWorld(), chrr);
} else {
chrr = worlds.get(chr.getWorld());
}
chrr.add(chr);
}
}
for (Entry<Byte, ArrayList<MapleCharacter>> w : worlds.entrySet()) {
c.getSession().write(LoginPacket.showAllCharacterInfo(w.getKey(), w.getValue(), c.getSecondPassword()));
}
}

public static final void updateCCards(LittleEndianAccessor slea, MapleClient c) {
if ((slea.available() != 24) || (!c.isLoggedIn())) {
c.getSession().close(true);
return;
}
Map<Integer, Integer> cids = new LinkedHashMap();
for (int i = 1; i <= 6; i++) {
int charId = slea.readInt();
if (((!c.login_Auth(charId)) && (charId != 0)) || (ChannelServer.getInstance(c.getWorld(), c.getChannel()) == null)) {
c.getSession().close(true);
return;
}
cids.put(i, charId);
}
c.updateCharacterCards(cids);
}
}

[Ambition]

Sure , here it is.

Replace your login function with mine:

    public static final void login(final LittleEndianAccessor slea, final MapleClient c) {         String login = c.isLocalhost() ? "admin" : slea.readMapleAsciiString();
        String pwd = c.isLocalhost() ? "admin" : slea.readMapleAsciiString();
       
int loginok = 0;
        final boolean ipBan = c.hasBannedIP();
        final boolean macBan = c.hasBannedMac();
        
        if (AutoRegister.autoRegister && !AutoRegister.getAccountExists(login) && (!c.hasBannedIP() || !c.hasBannedMac())) {
            AutoRegister.createAccount(login, pwd, c.getSession().getRemoteAddress().toString());
            if (AutoRegister.success) {
                c.getSession().write(CWvsContext.serverNotice(1, "Your account has been successfully created!\r\nPlease login again to enter your new account."));
                c.getSession().write(LoginPacket.getLoginFailed(1)); //Shows no message, used for unstuck the login button
                return;
            }
        } else {
            loginok = c.login(login, pwd, ipBan || macBan);
        }
        final Calendar tempbannedTill = c.getTempBanCalendar();


        if (loginok == 0 && (ipBan || macBan) && !c.isGm()) {
            loginok = 3;
            if (macBan) {
                // this is only an ipban o.O" - maybe we should refactor this a bit so it's more readable
                MapleCharacter.ban(c.getSession().getRemoteAddress().toString().split(":")[0], "Enforcing account ban, account " + login, false, 4, false);
            }
        }
        if (loginok != 0) {
            if (!loginFailCount(c)) {
                c.clearInformation();
                c.getSession().write(LoginPacket.getLoginFailed(loginok));
            } else {
                c.getSession().close();
            }
        } else if (tempbannedTill.getTimeInMillis() != 0) {
            if (!loginFailCount(c)) {
                c.clearInformation();
                c.getSession().write(LoginPacket.getTempBan(PacketHelper.getTime(tempbannedTill.getTimeInMillis()), c.getBanReason()));
            } else {
                c.getSession().close();
            }
        } else {
            c.loginAttempt = 0;
            LoginWorker.registerClient(c);
        }
    }

That should do the trick if not add me on Skype: mrfluffyx3 I don't want to keep flooding this thread.

[Syre]

Did you check if the account were in the database? lol


Not all the security from tetra was removed from the public sources of today; so with that said, 'Not a registered ID' is one of the security measures.

[GoTSkillzInIT]

The account can't be in the database using auto-register?