V114 Skill Maxer

[FrostByte]

I've tried ripping the skill maxer from v111 Lithium out and putting it into Xephyr, it just screws up players HP/MP and makes it go over 30K and bugs the bars out. Does anyone got a working one that doesn't mind sharing? I would make my own but i'm not sure how to make it
Anyway, help would be great, thanks.

[MentaL]

[pauljeki]

just use Xephyr scripts? :O

[FrostByte]

Whatchu mean? :O
If you mean the Nimakin skill maxer NPC, it bugs out your health when you use it.

[noodleacc]

Whatchu mean? :O
If you mean the Nimakin skill maxer NPC, it bugs out your health when you use it.

Its like that in EVERY server with skill maxer.
Due to the fact that almost every job has some sort of like hp+ passive skill. The only way is to rebirth like 30 times or changed to a gm job.

[Riven1]

Lol. Easy.

Spoiler:

 function start() {
cm.sendYesNo("Do you want to max your skills?"); // Riven1
cm.maxSkillsByJob; //cm.maxAllSkills might work too.
cm.safedispose;
} 

Max stat if you need.

Spoiler:

 function start() {
cm.sendYesNo("Do you want to max your stats?"); //Riven1
cm.maxStats;
cm.sendOk("Remember to relog !"); 
cm.safedispose;
} 

[MrAgent]

Lol. Easy.

Spoiler:

 function start() {
cm.sendYesNo("Do you want to max your skills?"); // Riven1
cm.maxSkillsByJob; //cm.maxAllSkills might work too.
cm.safedispose;
} 

Max stat if you need.

Spoiler:

 function start() {
cm.sendYesNo("Do you want to max your stats?"); //Riven1
cm.maxStats;
cm.sendOk("Remember to relog !"); 
cm.safedispose;
} 

umm... No that won't work at all. Clearly not easy for you.
You need to code the actual method yourself.

[Riven1]

It's inside for me well, place this in NPCConversationManager.

 public final void maxAllSkills() {
        HashMap<Skill, SkillEntry> sa = new HashMap<>();
        for (Skill skil : SkillFactory.getAllSkills()) {
            if (GameConstants.isApplicableSkill(skil.getId()) && skil.getId() < 90000000) { //no db/additionals/resistance skills
                sa.put(skil, new SkillEntry((byte) skil.getMaxLevel(), (byte) skil.getMaxLevel(), SkillFactory.getDefaultSExpiry(skil)));
            }
        }
        getPlayer().changeSkillsLevel(sa);
    }

    public final void maxSkillsByJob() {
        HashMap<Skill, SkillEntry> sa = new HashMap<>();
        for (Skill skil : SkillFactory.getAllSkills()) {
            if (GameConstants.isApplicableSkill(skil.getId()) && skil.canBeLearnedBy(getPlayer().getJob())) { //no db/additionals/resistance skills
                sa.put(skil, new SkillEntry((byte) skil.getMaxLevel(), (byte) skil.getMaxLevel(), SkillFactory.getDefaultSExpiry(skil)));
            }
        }
        getPlayer().changeSkillsLevel(sa);
    } 

[FrostByte]

I this gonna screw up my HP though?
Btw this didnt work:

function start() {
cm.sendYesNo("Do you want to max your skills?"); // Riven1
cm.maxSkillsByJob; //cm.maxAllSkills might work too.
cm.safedispose;
}

even after adding the functions.
error in bat:

no such method: action

[Liv3]

Lol. Easy.

Spoiler:

 function start() {
cm.sendYesNo("Do you want to max your skills?"); // Riven1
cm.maxSkillsByJob; //cm.maxAllSkills might work too.
cm.safedispose;
} 

Max stat if you need.

Spoiler:

 function start() {
cm.sendYesNo("Do you want to max your stats?"); //Riven1
cm.maxStats;
cm.sendOk("Remember to relog !"); 
cm.safedispose;
} 

Clearly, it is not easy for you because the NPC wouldn't work because you are missing brackets for some functions used (maxSkillsByJob, safeDispose, maxStats)...
Also, you need the function action since you are using sendYesNo. Your NPC Scripting skills are horrible. Please read up on some guides please. Look at Shawn's NPC scripting guide perhaps.

Just because I have time, here is the working NPC scripts:

function start() {
     cm.sendYesNo("Do you want to max your stats?"); 
}

function action(mode, type, selection) {
    if (mode > 0) {
        cm.maxStats();
        cm.sendOk("Remember to relog !"); // Rather than that, you should just reload the character.
        //cm.safeDispose();
    }
    cm.dispose(); // disposes anyway
} 

function start() {
    cm.sendYesNo("Do you want to max your skills?"); 
}

function action(mode, type, selection) {
     if (mode > 0) {
        cm.maxSkillsByJob(); //cm.maxAllSkills might work too.
        //cm.safeDispose();
     }
     cm.dispose();
} 

Or, rather than putting it in two NPCs, put it in one:

function start() {
    cm.sendSimple("Would you like to max your skills or stats?\r\n#L0#Max my skills#l\r\n#L1#Max my stats#l\r\n");
}

function action(mode, type, selection) {
    if (selection == 0) {
        cm.sendOk("Your skills have been maxed.");
        cm.maxSkillsByJob();
    } else if (selection == 1) {
        cm.sendOk("Your stats have been maxed.");
        cm.maxStats();
    }
    cm.dispose();
} 

[FrostByte]

Clearly, it is not easy for you because the NPC wouldn't work because you are missing brackets for some functions used (maxSkillsByJob, safeDispose, maxStats)...
Also, you need the function action since you are using sendYesNo. Your NPC Scripting skills are horrible. Please read up on some guides please. Look at Shawn's NPC scripting guide perhaps.

Just because I have time, here is the working NPC scripts:

function start() {
     cm.sendYesNo("Do you want to max your stats?"); 
}

function action(mode, type, selection) {
    if (mode > 0) {
        cm.maxStats();
        cm.sendOk("Remember to relog !"); // Rather than that, you should just reload the character.
        //cm.safeDispose();
    }
    cm.dispose(); // disposes anyway
} 

function start() {
    cm.sendYesNo("Do you want to max your skills?"); 
}

function action(mode, type, selection) {
     if (mode > 0) {
        cm.maxSkillsByJob(); //cm.maxAllSkills might work too.
        //cm.safeDispose();
     }
     cm.dispose();
} 

Or, rather than putting it in two NPCs, put it in one:

function start() {
    cm.sendSimple("Would you like to max your skills or stats?\r\n#L0#Max my skills#l\r\n#L1#Max my stats#l\r\n");
}

function action(mode, type, selection) {
    if (selection == 0) {
        cm.sendOk("Your skills have been maxed.");
        cm.maxSkillsByJob();
    } else if (selection == 1) {
        cm.sendOk("Your stats have been maxed.");
        cm.maxStats();
    }
    cm.dispose();
} 

If people max their skills and they are job 4 without maxing their skills before, it bugs out their HP/MP.

It shows their Max HP/MP is a lot higher then their actual Max HP/MP. But it isnt. Healing pots dont fix it either.
Thanks for the help either way.

[Liv3]

Well, that is part of the methods inside NPCConversationManager (or the problem may be somewhere else!), not the NPCs.

[FrostByte]

Yeah I know it's not in the NPC's. It's the methods, I just don't know how to max the skills without bugging it out :S

public void changeSkillsLevel(final Map<Skill, SkillEntry> ss) {
        if (ss.isEmpty()) {
            return;
        }
        final Map<Skill, SkillEntry> list = new HashMap<>();
        boolean hasRecovery = false, recalculate = false;
        for (final Entry<Skill, SkillEntry> data : ss.entrySet()) {
            if (changeSkillData(data.getKey(), data.getValue().skillevel, data.getValue().masterlevel, data.getValue().expiration)) {
                list.put(data.getKey(), data.getValue());
                if (GameConstants.isRecoveryIncSkill(data.getKey().getId())) {
                    hasRecovery = true;
                }
                if (data.getKey().getId() < 80000000) {
                    recalculate = true;
                }
            }
        }
        if (list.isEmpty()) { // nothing is changed
            return;
        }
        client.getSession().write(CWvsContext.updateSkills(list));
        reUpdateStat(hasRecovery, recalculate);
    }

This is the changeskillsmethod

[Riven1]

oh fuck yeah. I forgotten the brackets.