Fiesta 2015 Bugs (known at the current time)

[Evildarkang]

If you are/have use/d the 2015 files you will notice a few issues and i'm trying to figure out solutions to the ones shown below - most of them are mild but some are like WTH!

The first is that if you purchase a Premium item from the NPC (example: EXP Freeze/Scrolls/etc...) it will NOT work (except the fireworks - they work but you don't get any down) also note after a relog you'll get the item with 0 another words nothing there! (solution could be to use the production method but that means you'll need to have a static one)

Tutorial isn't working either; but that can easily be skipped (with the database)

I'll update this when the solutions are around.

[MentaL]

[PraFett]

The NPC issue has to do with stacks, if you make them single items, they work just fine. Bracelets work, if you use the correct client.bin. The messed up procedures can be found in the CN DBs (some of them, and some need to be edited).

[Evildarkang]

While i have found that the bug lies with the procedure it took a while to narrow down however i've found it and repaired it by FORCE it doesn't necessarily mean its a good method nor will i stand and say "it works 100%"

USE [w00_Character]
GO
/****** Object:  StoredProcedure [dbo].[p_Item_SetOption]    Script Date: 12/15/2018 2:04:31 PM ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[p_Item_SetOption]
/*
Item Set Option
2004.8 By CJC
 input:
	see SQL
 output:
	@nRet	0 = OK, 
	        ? = Error code
*/ @NitemKey bigint,
@nOptionType smallint,
@nOptionData bigint,
-- Output var
@nRet int OUTPUT
AS
SET NOCOUNT ON
UPDATE tItemOptions SET	nOptionData = @nOptionData
WHERE nItemKey = @NitemKey AND nOptionType = @nOptionType
IF @@ERROR <> 0 OR @@ROWCOUNT = 0
BEGIN
	INSERT tItemOptions (  nItemKey,  nOptionType,   nOptionData )
	VALUES				( @NitemKey, @nOptionType,  255 )
END
SET @nRet = @@ERROR
-- end
RETURN

To fix the NPC issue.

[RenegadeBenny]

I can't recommend this fix - Armor or Weapons bought at NPC's got even more bugged, and if you relog before using a bought stack, you can't even use (at least) scrolls anymore, because the MaxLot is still on 50, but after relog, the stack is on 255.

This also affects Items created by makeitem and mob drops

Edit:

Okay, I managed to get this working, more or less. Here is my procedure:

USE [Character]
GO
/****** Object:  StoredProcedure [dbo].[p_Item_SetOption]    Script Date: 16.12.2018 02:43:34 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[p_Item_SetOption]
/*
Item Set Option
2004.8 By CJC
 input:
    see SQL
 output:
    @nRet    0 = OK, 
            ? = Error code
*/  @NitemKey bigint,
@nOptionType smallint,
@nOptionData bigint,
-- Output var
@nRet int OUTPUT
AS
SET NOCOUNT ON
UPDATE tItemOptions SET    nOptionData = @nOptionData
WHERE nItemKey = @NitemKey AND nOptionType = @nOptionType


IF @@ERROR <> 0 OR @@ROWCOUNT = 0
BEGIN
--Custom Start
--THIS OPTION WILL FORCE EVERY WEAPON TO 3 SOCKETS AFTER RELOG! IN MY CASE, EVERY WEAPON GOT 255 SOCKETS AND CRASHED BY LOOKING
IF @nOptionType = 523 OR @nOptionType = 524
SET @nOptiondata = 3
IF RIGHT(@nOptionType, 2) = 01
--START PUT YOUR CUSTOM AMOUNT HERE
SET @nOptionData = 50
--END PUT YOUR CUSTOM AMOUNT HERE
--Custom End
IF RIGHT(@nOptionType,2) <> 21 
    INSERT tItemOptions (  nItemKey,  nOptionType,   nOptionData )
    VALUES                ( @NitemKey, @nOptionType, @nOptiondata)
END
SET @nRet = @@ERROR
-- end
RETURN

This isn't the best solution, too. And there is one thing I still didn't got rid of it. I'll show it in the following screenshot. It's the Creator-thing. But anyway, have fun! Maybe you should put every stackable item (at least these you can buy) to 50 or your desired amount with a mass editor. Sockets still don't seem to work.

[Evildarkang]

I can't recommend this fix - Armor or Weapons bought at NPC's got even more bugged, and if you relog before using a bought stack, you can't even use (at least) scrolls anymore, because the MaxLot is still on 50, but after relog, the stack is on 255.

This also affects Items created by makeitem and mob drops

Edit:

Okay, I managed to get this working, more or less. Here is my procedure:

USE [Character]
GO
/****** Object:  StoredProcedure [dbo].[p_Item_SetOption]    Script Date: 16.12.2018 02:43:34 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[p_Item_SetOption]
/*
Item Set Option
2004.8 By CJC
 input:
    see SQL
 output:
    @nRet    0 = OK, 
            ? = Error code
*/  @NitemKey bigint,
@nOptionType smallint,
@nOptionData bigint,
-- Output var
@nRet int OUTPUT
AS
SET NOCOUNT ON
UPDATE tItemOptions SET    nOptionData = @nOptionData
WHERE nItemKey = @NitemKey AND nOptionType = @nOptionType


IF @@ERROR <> 0 OR @@ROWCOUNT = 0
BEGIN
--Custom Start
--THIS OPTION WILL FORCE EVERY WEAPON TO 3 SOCKETS AFTER RELOG! IN MY CASE, EVERY WEAPON GOT 255 SOCKETS AND CRASHED BY LOOKING
IF @nOptionType = 523 OR @nOptionType = 524
SET @nOptiondata = 3
IF RIGHT(@nOptionType, 2) = 01
--START PUT YOUR CUSTOM AMOUNT HERE
SET @nOptionData = 50
--END PUT YOUR CUSTOM AMOUNT HERE
--Custom End
IF RIGHT(@nOptionType,2) <> 21 
    INSERT tItemOptions (  nItemKey,  nOptionType,   nOptionData )
    VALUES                ( @NitemKey, @nOptionType, @nOptiondata)
END
SET @nRet = @@ERROR
-- end
RETURN

This isn't the best solution, too. And there is one thing I still didn't got rid of it. I'll show it in the following screenshot. It's the Creator-thing. But anyway, have fun! Maybe you should put every stackable item (at least these you can buy) to 50 or your desired amount with a mass editor. Sockets still don't seem to work.

Thank you for a better fix :)

[RenegadeBenny]

This thread will look even more bloated, but I worked again on the procedure.

USE [Character]
GO
/****** Object:  StoredProcedure [dbo].[p_Item_SetOption]    Script Date: 16.12.2018 15:35:59 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[p_Item_SetOption]
/*
Item Set Option
2004.8 By CJC
 input:
	see SQL
 output:
	@nRet	0 = OK, 
	        ? = Error code
*/  @NitemKey bigint,
@nOptionType smallint,
@nOptionData bigint,
-- Output var
@nRet int OUTPUT
AS
SET NOCOUNT ON
UPDATE tItemOptions SET	nOptionData = @nOptionData
WHERE nItemKey = @NitemKey AND nOptionType = @nOptionType

IF @@ERROR <> 0 OR @@ROWCOUNT = 0
BEGIN
--CUSTOM START
--THIS OPTION WILL SET SOCKETS TO 0 IN THE ITEMOPTIONS, BUT SOCKETS SHOULD STILL WORK
IF @nOptionType = 523 OR @nOptionType = 524
SET @nOptiondata = 0
IF RIGHT(@nOptionType, 2) = 01
IF(@nOptionData = 0)
--START PUT YOUR CUSTOM AMOUNT HERE
SET @nOptionData = 50
--END PUT YOUR CUSTOM AMOUNT HERE
--CUSTOM END

--CUSTOM IF START
IF RIGHT(@nOptionType,2) <> 21 
--CUSTOM IF END
	INSERT tItemOptions (  nItemKey,  nOptionType,   nOptionData )
	VALUES				( @NitemKey, @nOptionType, @nOptiondata)
END
--CUSTOM DELETE THESE DUMB WEAPON TITLE ON NPC WEAPONS START
DELETE FROM dbo.tItemMobList WHERE nItemKey = @NitemKey
--CUSTOM DELETE THESE DUMB WEAPON TITLE ON NPC WEAPONS END
SET @nRet = @@ERROR
-- end
RETURN

https://pastebin.com/vVf3irXg

These dumb Weapon Title is now gone, so no "Creator <>" anymore, and I forced the Socket stuff to 0, but Sockets should still work, at least they still work for me