[Share] Some things to Dragon Source UPDATE # 5

BBim : I think you forgotten something in your ban part :

add

Code:

---

#include "../Common/Database/MySQLM.h"

---

in players.cpp unless it make an error about MYSQL and SetInt when you compil it

Quote:

---

Originally Posted by divinepunition

BBim : I think you forgotten something in your ban part :

add

Code:

---

#include "../Common/Database/MySQLM.h"

---

in players.cpp unless it make an error about MYSQL and SetInt when you compil it

---

Yes, I think I forgot that, will put it in my next update(yes, there is an update almost ready to come, I just need to fix one thing ;P)

edit: update #6 is out, i dont know why the title didnt change, if I press edit it show #6...well, anyways, enjoy :P

awsome work man
congratz for the effort and results

Quote:

---

Originally Posted by Hells

awsome work man
congratz for the effort and results

---

Thanks :]
And btw, I will take a one week break, maybe less, I am making a flyff "fansite" with a friend and until it is finished I wont dev anything :\ (unless I get bored of php :P)

Quote:

---

do {
int* equips = new int[1];
equips[0] = atoi(mrow[0]);
showEquip.push_back(equips);
mrow = mysql_fetch_row(mres);
int*equips = delete int[1] < < < < < < < < < < < < place delete here?
} while (mrow);
mysql_free_result(mres);
return showEquip;
}

---

i think you should not put you delete in the do{} while loop but just after no ?
I suppose it should be this :

Quote:

---

do {
int* equips = new int[1];
equips[0] = atoi(mrow[0]);
showEquip.push_back(equips);
mrow = mysql_fetch_row(mres);

} while (mrow);
mysql_free_result(mres);
delete[] equips; < < < < < < < < < < < < place here
return showEquip;
}

---

Thank to correct me if i made a mistake but i think the memory should be released "after" the loop then you just call one time the delete function (or do you think that thi loop could take too much memory ?)

Quote:

---

Originally Posted by divinepunition

i think you should not put you delete in the do{} while loop but just after no ?
I suppose it should be this :



Thank to correct me if i made a mistake but i think the memory should be released "after" the loop then you just call one time the delete function (or do you think that thi loop could take too much memory ?)

---

Im not 100% sure, but from what I know, if the loop runs 100 times, the way you said would just free 1 address, so leaving 99 still used.

Mmmm ok yes in doubt we should put the delete in the loop !

For time optimising it seem that you forgot something :

in worldthread.cpp go to :

Quote:

---

getLastCheck()

---

in PlayerThread function

replace by :

Quote:

---

getNextCheck()

---

Quote:

---

Originally Posted by divinepunition

Mmmm ok yes in doubt we should put the delete in the loop !

For time optimising it seem that you forgot something :

in worldthread.cpp go to :


in PlayerThread function

replace by :

---

Actually im 99% sure it would delete just the last one and leave 99 :P
And, what did I forget? I didnt get it.

perhap i haven't understood all about you fix ^^

It's just that if we follow step by step, first we apply the hp/mp/fp recorvery
Next in bottom we modify those fix by "Optimazing time checks:"

You said to replace what we have done in step 1 by other code but what you dont say is what will we do about this :

Code:

---

if (GetTickCount() - thisplayer->getLastCheck() > 2000)

---

but getLastCheck() have been suppress so you can't compile the files...

So i had supposed that we must replace

Code:

---

if (GetTickCount() - thisplayer->getLastCheck() > 2000)

---

by that

Code:

---

if (GetTickCount() - thisplayer->getNextCheck() > 2000)

---

What is not clearly wrote on your fix

But thanks a lot with your help it work for me (connect and play):thumbup: and i confirm that there is a problem qith inventory and additem ^^ I tryied to make .item 22026 1 0 0 0 0 and all my slot where equiped by a gardian sword !

Now i'm going to see how all those file work (i had seen a little already by fixing those files) and see what i can do ^^

Quote:

---

Originally Posted by divinepunition

perhap i haven't understood all about you fix ^^

It's just that if we follow step by step, first we apply the hp/mp/fp recorvery
Next in bottom we modify those fix by "Optimazing time checks:"

You said to replace what we have done in step 1 by other code but what you dont say is what will we do about this :

Code:

---

if (GetTickCount() - thisplayer->getLastCheck() > 2000)

---

but getLastCheck() have been suppress so you can't compile the files...

So i had supposed that we must replace

Code:

---

if (GetTickCount() - thisplayer->getLastCheck() > 2000)

---

by that

Code:

---

if (GetTickCount() - thisplayer->getNextCheck() > 2000)

---

What is not clearly wrote on your fix

But thanks a lot with your help it work for me (connect and play):thumbup: and i confirm that there is a problem qith inventory and additem ^^ I tryied to make .item 22026 1 0 0 0 0 and all my slot where equiped by a gardian sword !

Now i'm going to see how all those file work (i had seen a little already by fixing those files) and see what i can do ^^

---

oh, I think you meants why one part says that we need to put one thing (getLastCheck) and the other one says to use getNextCheck, when I made that, I didnt list everyplace that you should change, because it is the samething everywhere, you just need to find where it uses things like

Code:

---

if (GetTickCount() - thisplayer->getLastCheck() > 2000)

---

and change to the optimized code.

yes it was what i wanted to say ^^

bump for people that needs anything from here and didnt see it yet.

1>GameServer - 1 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========

thats the end of my build solution for gameserver, the error is : error C2770 invalid explicit template argument(s) for 'T ConfigFile::String_as_T(const std::string &)'. does anyone know the fix for this error? the error is found in Config.h, at the line
if (found) var = string_as_T<T>( p->second);

i got this for login server :
2>LoginServer - 0 error(s), 2 warning(s)
==========Build: 2 succeeded, 0 failed, 0 skipped ==========

Quote:

---

Originally Posted by briantran

1>GameServer - 1 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========

thats the end of my build solution for gameserver, the error is : see declaration of 'ConfigFile::string_as_T
any suggestions?

i got this for login server :
2>LoginServer - 0 error(s), 2 warning(s)
==========Build: 2 succeeded, 0 failed, 0 skipped ==========

---

Your login is fine, now, to game server, click here: http://forum.ragezone.com/f457/drago...7/#post4348590 and wait till it fully load, the answer will be in front of your nose.

Quote:

---

Originally Posted by BBim

Your login is fine, now, to game server, click here: http://forum.ragezone.com/f457/drago...7/#post4348590 and wait till it fully load, the answer will be in front of your nose.

---

cool, thanks