- Joined
- Sep 8, 2011
- Messages
- 822
- Reaction score
- 129
Looked into how pages were handled, and made some tweaks. Thanks @kevintingg
1/3/2016 - First MapleBit commit of 2016!
- Removed SQL query for custom pages
- Removed SQL query for navbar
- Removed Mailing system
- Fixed JS issues on news, events, and GM blogs when an error occurred or cooldown was in effect.
- Removed all references to MS.
To do:
Remove GD from repository
I've been slowly phasing out any sort of relation between MapleBit and MS/Nexon property, in case you were wondering of the changes these past few weeks.
I can't understand why would you possibly remove all references to MapleStory, if it's because of Nexon then this is completely idiotic, the last thing they'd care about is whether a certain website contains references to their trademark, which by the way is completely allowed by law since it's a fair use of the trademark (i.e. the name).
In sources/public/members.php you have double commas which can lead to some errors.
Another thing is that you should not repeat yourself, instead make a new function to handle this, and call the function in each header.php file.
Another small thing is that you use too many double quotes ("), in excessive use of this, it slows the application down a bit because double quotes is used to tell the parser that there's a variable along with the string while there is none. Also this bothers me for some reason (ocd, sorry).
Nevertheless, great job!
Attachments
You must be registered for see attachments list