A beginners ideas on improvements that can be made to pokenet

[dablackfox]

Hi i am a complete novice when it comes to java or any kind of coding, however i have decided to make java my first language and will be learning it through tutorials.
PokeNet and Minecraft will be my main programs of interest while learning my skills.
From my experience this game is virtually unplayable.
Feel free to take my list and make updates to the git. feel free to post if you do, so i know.

To Do:

Fix KeyPress Movement.

- No longer need to change os config Use KeyPress not just Key.

- Make it so the server and the client movement of other players is accurate.

- When jumping over a rock fence/ledge the player should do the jump animation.

- Prevent the character from walking through and getting stuck in objects.

- Prevent the character from walking on entering combat from wild pokemon.

- Using Raw Input may help here.

- when walking through bush the leaves should make a leaf fall animation or a splitting animation

- Water should be animated, even if its just a gif or the texture is being moved Y+1 x+1 reset

- flowers need to be animated, the top half should split from the bottom half then moved x=0 then x+1 then back to x=0 and maybe even x-1 then back to x=0. giving
it a wind animation.



Incorporate spell animations.

- PokeCenter Animations Should Be Present.

- Attacks and defence should be simple animations such as moving forward or back sudenly

- Special effects such as sleep should be animated.

- Spells should be classed then animated

-fire spells should have no more than 5 animations to begin with eg: (fireblast,ember,firespin are only a few animations)

-water spells ^^ (surf, bubble, hydropump)

-Buffs and so on...


Improve current ui

- The abilitys need to be selectable by keyboard or gamepad and not just mouse.

- Need to replace the default background for the combat buttons and window

- Need to remove other regions as default and make them optional in the config until implemented.

- Keep the Registration window where it is, however make it so you can disable it client or server side.

- Make it so battle player option is not available unless your in a zone that allows it.

- Make it so you cant offer trade with a person who only has one pokemon.

- When a player from one account logs in on another the pokemon are still present on the ui but are not playable.

- The jessie and james background when reaching the edge of a map is annoying and should be a black only background. however it looks good at the loading screen.

- Resolution Changing should be optional.

- Gym Leaders are broken. and the pokemon seem to be incorrect.


Currency and Currency frames

- Pokemon should not drop money

- Pokemon trainers need to drop more money

- Beginning money should be 1500


Notes:
In theory adding all the animations should be nice and painful however it will be worth the pain.
Moving the position of the pokemon should suffice for the animations.
With the multi account pokemon i think its a memory issue. only occurred if you are kicked because you loged in on another computer, then log in with another account.

This post will be updated as i make changes to the client. Get help from Experienced Devs and Find new things to fix
-----------------------------------------------------------------------------------------------
Done:

- Logout needs to be a valid option when pressing esc. pressing it twice should not close the program but close the menu instead.

-----------------------------------------------------------------------------------------------
Working code. Feel Free to use it.
When pressing esc twice in game, it no longer closes the game, instead it closes the close menu.
Closes the exit game window when pressing esc twice.
Now with fully working login enter and tab keys.
Now with ChatBox enter to activate escape to exit chatbox.

package org.pokenet.client;

line 511

Spoiler:

@Override
public void keyPressed (int key,char c) {
        if(m_started){
            if (key == (Input.KEY_ENTER) || key == (Input.KEY_NUMPADENTER)){
                if (m_login.isVisible()){
                    m_login.enterKeyDefault();            
                }
                if (m_ui.getChat().isVisible())
                {
                    m_ui.getChat().grabFocus();
                    }
            }
            if (key == (Input.KEY_TAB)) {
                if  (m_started && m_login.isVisible() );{
                    m_login.tabKeyDefault();
                }
            }
            
            };
            if (key == (Input.KEY_ESCAPE)){    
                m_ui.getChat().dropFocus();
                if (m_confirm==null){
                        ActionListener yes = new ActionListener() {
                            public void actionPerformed(ActionEvent arg0) {
                                try {
                                    System.exit(0);
                                } catch (Exception e) {
                                    e.printStackTrace();
                                }
                                
                            }
                        };
                        ActionListener no = new ActionListener() {
                            public void actionPerformed(ActionEvent arg0) {
                                m_confirm.setVisible(false);
                                getDisplay().remove(m_confirm);
                                m_confirm = null;
                            }
                            
                        };
                        m_confirm = new ConfirmationDialog("Are you sure you want to exit?",yes,no);
                        getUi().getDisplay().add(m_confirm);
                    }
                    else{
                        m_confirm.setVisible(false);
                        getDisplay().remove(m_confirm);
                        m_confirm = null;
                    };
                
            };

package org.pokenet.client.ui.frames;
line 145

    public void grabFocus() {         m_inputBox.grabFocus();     }

information update
org.pokenet.client gameclient.java

Spoiler:

    /**
     * Accepts the user input.
     * @param key The integer representing the key pressed.
     * @param c - The character of the key that was pressed
     */

Depreciated code fixed

---------------------------------------------------------------------
void enableKeyRepeat() - Enable key repeat for this input context.
---------------------------------------------------------------------
void enableKeyRepeat(int initial, int interval) - Deprecated.
---------------------------------------------------------------------

org.pokenet.client gameclient.java

Spoiler:

        gc.getInput().enableKeyRepeat();
//        LoadingList.setDeferredLoading(false);

    }

    private void loadSprites() {
        try {
            String location;
            String respath = System.getProperty("res.path");
            if(respath==null)
                respath="";
            /*
             * WARNING: Change 224 to the amount of sprites we have in client
             * the load bar only works when we don't make a new SpriteSheet
             * ie. ss = new SpriteSheet(temp, 41, 51); needs to be commented out
             * in order for the load bar to work.
             */
            for(int i = -5; i < 224; i++) {
                try {

                    location = respath+"res/characters/" + String.valueOf(i) + ".png";
                    m_spriteImageArray[i + 5] = new Image(location);
                    
                } catch (Exception e) {
                    location = respath+"res/characters/" + String.valueOf(i) + ".png";
                    m_spriteImageArray[i + 5] = new Image(location);
                }
            }
        } catch (Exception e) { 
            e.printStackTrace();
        }
        
    }
    
    void setPlayerSpriteFactory() {
        Player.setSpriteFactory(new SpriteFactory(m_spriteImageArray));
    }

    /**
     * Updates the game window
     */
    @SuppressWarnings("deprecation")
    @Override
    public void update(GameContainer gc, int delta) throws SlickException {
        if (m_nextResource != null) {
            try { 
                m_nextResource.load();

            } catch (Exception e) {
                //throw new SlickException("Failed to load: " + m_nextResource.getDescription(), e);
                System.err.println("Failed to load: " + m_nextResource.getDescription() + "\n"
                        + "... WARNING: the game may or may not work because of this");
            }
            
            m_nextResource = null;
        }
        
        if (LoadingList.get().getRemainingResources() > 0) {
            m_nextResource = LoadingList.get().getNext();
        } else {
            if (!m_started) {
                m_started = true;
                m_soundPlayer.setTrack("introandgym");
//                music.loop();
//                sound.play();
                if(m_ui == null){
                    LoadingList.setDeferredLoading(false);
                    
                    setPlayerSpriteFactory();

                    m_weather = new WeatherService();
                    m_time = new TimeService();
                    if(options != null)
                        m_weather.setEnabled(!Boolean.parseBoolean(options.get("disableWeather")));
                    
                    m_ui = new Ui(m_display); 
                    m_ui.setAllVisible(false);    
                }
                
            }
        }
        
        if(m_started){
            // make sure we can't move while chaging maps
            if(m_loading.isVisible()){
                gc.getInput().disableKeyRepeat();
            }else{
                gc.getInput().enableKeyRepeat();

Removed Venonat as main login background.
It now uses the default background unless its a holiday or event.

org.pokenet.client.ui loginscreen.java

Spoiler:

//            m_bgColor = new Color(255, 255, 255, 70);
            List<String> translated = new ArrayList<String>();
            translated = Translator.translate("_LOGIN");
            /*
             * Load the background image
             * NOTE: Months start at 0, not 1
             */
            Calendar cal = Calendar.getInstance();
            if(cal.get(Calendar.MONTH) == 1) {
                    if(cal.get(Calendar.DAY_OF_MONTH) >= 7
                            && cal.get(Calendar.DAY_OF_MONTH) <= 14) {
                        /* Valentines day! */
                        f = new FileInputStream(respath+"res/pokenet_valentines.png");
                    } else {
                        f = new FileInputStream(respath+"res/pokenet_normal.png");
                    }
            } else if(cal.get(Calendar.MONTH) == 2 
                    && cal.get(Calendar.DAY_OF_MONTH) > 14) {
                /* If second half of March, show Easter login */
                f = new FileInputStream(respath+"res/pokenet_easter.png");
            } else if(cal.get(Calendar.MONTH) == 3 
                    && cal.get(Calendar.DAY_OF_MONTH) < 26) {
                /* If before April 26, show Easter login */
                f = new FileInputStream(respath+"res/pokenet_easter.png");
            } else if(cal.get(Calendar.MONTH) == 9) {
                /* Halloween */
                f = new FileInputStream(respath+"res/pokenet_halloween.png");
            } else if(cal.get(Calendar.MONTH) == 11) {
                /* Christmas! */
                f = new FileInputStream(respath+"res/pokenet_xmas.png");
            } else if(cal.get(Calendar.MONTH) == 0) {
                /* January - Venonat Time! */
                f = new FileInputStream(respath+"res/pokenet_venonat.png");
            } else if(cal.get(Calendar.MONTH) >= 5 
                    && cal.get(Calendar.MONTH) <= 7) {
                /* Summer login */
                f = new FileInputStream(respath+"res/pokenet_summer.png");
            } else {
                /* Show normal login screen */
                f = new FileInputStream(respath+"res/pokenet_normal.png");
            }
            m_bg = new Label(new Image(f, "bg", false));
            m_bg.pack();
            m_bg.setLocation(0, 0);
            m_bg.setVisible(true);
            this.add(m_bg);

Separating the loading screen from the background screen.
i will look at making it change with the seasons soon too.

org.pokenet.client gameclient.java

Spoiler:

    @SuppressWarnings("deprecation")
    @Override
    public void init(GameContainer gc) throws SlickException {
//        gc.getGraphics().setBackground(Color.white);
        m_loadImage = new Image("res/pokenet_normal.png");
//        m_loadImage = m_loadImage.getScaledCopy(gc.getWidth() / m_loadImage.getWidth());
        m_loadImage = m_loadImage.getScaledCopy(800.0f / m_loadImage.getWidth());

        m_loadBarLeft = new Image("res/ui/loadbar/left.png");
        m_loadBarRight = new Image("res/ui/loadbar/right.png");
        m_loadBarMiddle = new Image("res/ui/loadbar/middle.png");

also

    /**
     * Updates the game window
     */
    @SuppressWarnings("deprecation")
    @Override
    public void update(GameContainer gc, int delta) throws SlickException {
        if (m_nextResource != null) {
            try { 
                m_nextResource.load();

            } catch (Exception e) {
                //throw new SlickException("Failed to load: " + m_nextResource.getDescription(), e);
                System.err.println("Failed to load: " + m_nextResource.getDescription() + "\n"
                        + "... WARNING: the game may or may not work because of this");
            }
            
            m_nextResource = null;
        }
        
        if (LoadingList.get().getRemainingResources() > 0) {
            m_nextResource = LoadingList.get().getNext();
        } else {
            if (!m_started) {
                m_started = true;
                m_loadImage = new Image("res/load.jpg");
                m_loadImage = m_loadImage.getScaledCopy(800.0f / m_loadImage.getWidth());
                m_soundPlayer.setTrack("introandgym");
//                music.loop();
//                sound.play();

Afk Timer
set to 15mins
1000 = 1second
1000x60x15 = 900000

org.pokenet.server.network idleTimer.java

Spoiler:

/**
 * A class which kicks players if they've been idle for too long
 */
public class IdleTimer implements Runnable {
    private boolean m_isRunning = false;
    
    public void run() {
        while(m_isRunning) {
            /*
             * Loop through all players and check for idling
             * If they've idled, disconnect them
             */
            TcpProtocolHandler.kickIdlePlayers();
            try {
                Thread.sleep(900000);
            } catch (Exception e) {}
            
        }
    }

My source and client Build.

This build and source has all of the above changes. 2/25/2012

Stable Version 1.0
http://www.mediafire.com/?6lq1fhmzjafhojf
Beta Version 1.01
http://www.mediafire.com/?4c6m0dweolj66lp

[MentaL]

[dablackfox]

DON'T USE THIS CODE, ITS JUST A REFERENCE.
Note: i think the biggest problem here is its sending a key-press to the server, when

i used a multibox program for wow i had issues where it would copy my arrow presses but not how long they were pressed for.
so my first character would be in the right spot but the other 4 were facing the wrong direction.
i think the same thing is happening here.
Which makes me think we need to let it see the direction were going so it can set the direction were facing.
but we need to make it so it runs on x and y co-ordinates,
with movement so there not teleporting.... but how.

Fix for multiplayer Movement

Bug: when it sends multiple directions and x,y it resets the x,y to 0 sending you off the screen.

I think i need to make it so it updates it after the set of key actions and not after each.

Spoiler:

Work in progress
Cut from
org.pokenet.client gameclient.java

Spoiler:

	/**
	 * Accepts the user input.
	 * @param key The integer representing the key pressed.
	 * @param c - The character of the key that was pressed
	 */
	
	
	public void setMap(int x, int y) {
		m_mapX = x;
		m_mapY = y;
		m_isNewMap = true;
		m_loading.setVisible(true);
		m_ui.getReqWindow().clearOffers();
		m_soundPlayer.setTrackByLocation(m_mapMatrix.getMapName(x, y));
	}

Paste Above
org.pokenet.client gameclient.java

Spoiler:

	/**
	 * Returns our player
	 * @return
	 */
	@Override

After that copy and replace the code blow with the similar code.

org.pokenet.client gameclient.java

Spoiler:

					if (key == (Input.KEY_DOWN) || key == (Input.KEY_S)) {
						if(!m_mapMatrix.getCurrentMap().isColliding(m_ourPlayer, Direction.Down)) {
							m_ourPlayer.queueMovement(Direction.Down);
							m_packetGen.move(Direction.Down);
						} else if(m_ourPlayer.getDirection() != Direction.Down) {
							m_ourPlayer.queueMovement(Direction.Down);
							m_packetGen.move(Direction.Down);
							m_ourPlayer.setServerX(m_mapY);
						}
					} else if (key == (Input.KEY_UP) || key == (Input.KEY_W)) {
						if(!m_mapMatrix.getCurrentMap().isColliding(m_ourPlayer, Direction.Up)) {
							m_ourPlayer.queueMovement(Direction.Up);
							m_packetGen.move(Direction.Up);
						} else if(m_ourPlayer.getDirection() != Direction.Up) {
							m_ourPlayer.queueMovement(Direction.Up);
							m_packetGen.move(Direction.Up);
							m_ourPlayer.setServerX(m_mapY);
						}
					} else if (key == (Input.KEY_LEFT) || key == (Input.KEY_A)) {
						if(!m_mapMatrix.getCurrentMap().isColliding(m_ourPlayer, Direction.Left)) {
							m_ourPlayer.queueMovement(Direction.Left);
							m_packetGen.move(Direction.Left);
						} else if(m_ourPlayer.getDirection() != Direction.Left) {
							m_ourPlayer.queueMovement(Direction.Left);
							m_packetGen.move(Direction.Left);
							m_ourPlayer.setServerX(m_mapX);
						}
					} else if (key == (Input.KEY_RIGHT) || key == (Input.KEY_D)) {
						if(!m_mapMatrix.getCurrentMap().isColliding(m_ourPlayer, Direction.Right)) {
							m_ourPlayer.queueMovement(Direction.Right);
							m_packetGen.move(Direction.Right);
						} else if(m_ourPlayer.getDirection() != Direction.Right) {
							m_ourPlayer.queueMovement(Direction.Right);
							m_packetGen.move(Direction.Right);
							m_ourPlayer.setServerX(m_mapX);
							
						}

here im trying to make it so when you press escape it closes the toggled window then allows the exit game window to appear, i had more but i deleted it.

Binds the escape key
to close togglechat, stats, pokemon, bag, map, friends, requests, options, help

org.pokenet.client gameclient.java

Spoiler:

					} else if (key == Input.KEY_C) {
						m_ui.toggleChat();
					}	else if (key == Input.KEY_ESCAPE){
								m_ui.toggleChat();
					} 
					else if (key == (Input.KEY_1)) {
						m_ui.toggleStats();
					}	else if (key == Input.KEY_ESCAPE){
						m_ui.toggleStats();
					}
					else if (key == (Input.KEY_2)) {
						m_ui.togglePokemon();
					}	else if (key == Input.KEY_ESCAPE){
						m_ui.togglePokemon();
					}
					else if (key == (Input.KEY_3)) {
						m_ui.toggleBag();
					}	else if (key == Input.KEY_ESCAPE){
						m_ui.toggleBag();
					}
					else if (key == (Input.KEY_4)) {
						m_ui.toggleMap();
					}	else if (key == Input.KEY_ESCAPE){
						m_ui.toggleMap();
					}
					else if (key == (Input.KEY_5)) {
						m_ui.toggleFriends();
					}	else if (key == Input.KEY_ESCAPE){
						m_ui.toggleFriends();
					}
					else if (key == (Input.KEY_6)) {
						m_ui.toggleRequests();
					}	else if (key == Input.KEY_ESCAPE){
						m_ui.toggleRequests();
					}
					else if (key == (Input.KEY_7)) {
						m_ui.toggleOptions();
					}	else if (key == Input.KEY_ESCAPE){
						m_ui.toggleOptions();
					}
					else if (key == (Input.KEY_8)) {
						m_ui.toggleHelp();
					}	else if (key == Input.KEY_ESCAPE){
						m_ui.toggleHelp();
					}
				}
			}

im going to go get food so i can think again.

[lcey]

I'll try to work on the character jump animation. Thanks for the idea.

[dablackfox]

Thank you for helping XD

[Thesnowman]

did you code all those?

[dablackfox]

yes, some code was simply moved to make other code work but thats in the experimental post.


im a complete novice to coding, but i have had experience with minecraft and wow private server stuf.

most of the code there is just there so you know were to put it.

There is a download link, at the bottom of the top post.


TBH i have been doing this for 3 days now and i feel like i have done nothing.

But what i have done should be permenent.

[Thesnowman]

How do you think i feel. Ive been doing this for 2 weeks now and fixed maybe a few things...

[xkl]

Very nice dablackfox. I wish you the best of luck on everything. You'll be one great developer ;)

Rep +

[dablackfox]

Wow thanks guys XD

I still have quite a bit of learning to do, but i feel like i have learned allot in the last few days..

[DarkOrka]

just a heads up but idk about other people but when i try to click the link for the source it just sends me to Mediafires home page

[dablackfox]

Man this is driving me mad, I'm trying to make it so there is a logout option while ingame and a quit while at the login screen.

it all works.

Except when you log in on the same account after logging out.
it logs in then you get a you have been disconnected error. and the game crashes if you try to move.

i know i should send a call to disconnect on logout.
and i know the server can handle the logout command.
but the client doesn't have one at all.
i have been looking around for a clue as how to disconnect from server at that point. but nothing worked.


i have found this Help -
and this NioDatagramConnector (Apache MINA 2.0.4 API Documentation)
and this IoSession (Apache MINA 2.0.4 API Documentation)
and this Google

maybe im missing something simple or need to create something somewhere, but if anyone knows off the top of there head. would be appreciated.


here is the code.

Spoiler:

	/**
	/**
	 * Accepts the user input.
	 * @param key The integer representing the key pressed.
	 * @param c - The character of the key that was pressed
	 */
	@Override
	public void keyPressed(int key, char c) {
		if(m_started){
			if (m_login.isVisible()){
				if (key == (Input.KEY_ENTER) || key == (Input.KEY_NUMPADENTER))
					m_login.enterKeyDefault();
				if (key == (Input.KEY_TAB))
					m_login.tabKeyDefault();
				if (key == (Input.KEY_ESCAPE)) {			
						if(m_confirm==null){
							ActionListener yes = new ActionListener() {
							public void actionPerformed(ActionEvent arg0) {
								try {
									System.exit(0);
								} catch (Exception e) {
									e.printStackTrace();
								}

							}
						};
						ActionListener no = new ActionListener() {
							public void actionPerformed(ActionEvent arg0) {
								m_confirm.setVisible(false);
								getDisplay().remove(m_confirm);
								m_confirm = null;
							}
						};
						
						m_confirm = new ConfirmationDialog("Are you sure you want to exit?",yes,no);
						getUi().getDisplay().add(m_confirm);
					}else{
						m_confirm.setVisible(false);
						getDisplay().remove(m_confirm);
						m_confirm = null;
					}
				}
			}
		else if (key == (Input.KEY_ESCAPE)) {
				if(m_confirm==null){
						ActionListener yes = new ActionListener() {
						public void actionPerformed(ActionEvent arg0) {
							m_confirm.setVisible(false);
							getDisplay().remove(m_confirm);
							m_confirm = null;
							m_packetGen = null;
							HOST = "";
							try {
								if(BattleManager.getInstance() != null)
									BattleManager.getInstance().endBattle();
								m_ui.getNPCSpeech().setVisible(false);
								m_ui.getChat().setVisible(false);
								m_ui.setVisible(false);
							} catch (Exception e) {}
							m_login.setVisible(true);
							m_login.showLanguageSelect();
							
						}
					};
					ActionListener no = new ActionListener() {
						public void actionPerformed(ActionEvent arg0) {
							m_confirm.setVisible(false);
							getDisplay().remove(m_confirm);
							m_confirm = null;
							}
					};
					
					m_confirm = new ConfirmationDialog("Are you sure you want to logout?",yes,no);
					getUi().getDisplay().add(m_confirm);
				}else{
					m_ui.setVisible(true);
					m_confirm.setVisible(false);
					getDisplay().remove(m_confirm);
					m_confirm = null;
					m_ui.getChat().setVisible(true);
				}
			}

just a heads up but idk about other people but when i try to click the link for the source it just sends me to Mediafires home page

sorry about that, i wrote the link for that before it was uploaded.
and forgot to paste the link into both the link and the description.

it has been updated. but here is the link again.
Client.rar

[Thesnowman]

I have all spell animations. I just dont know how to script them into the client.

Also i think personally the game should be more DB related no client related...

[mecatrix]

I have all spell animations. I just dont know how to script them into the client.

Also i think personally the game should be more DB related no client related...

@Thesnowman : i beg to differ, i think server side are about allright, a buggy client interrupt the whole gaming process, me myself are trying to fix a few client side problem


as a few of my player says, better to have 'pokemon blue like' animation.. although it's not that great, it manage to grab millions of attention on their first release..

a few bug:
- after/during battle: the client crash, player can walk arround
- if the person looses: sometimes the battle 'UI' didnt disapear and block the background

[dablackfox]

@Thesnowman : i beg to differ, i think server side are about allright, a buggy client interrupt the whole gaming process, me myself are trying to fix a few client side problem


as a few of my player says, better to have 'pokemon blue like' animation.. although it's not that great, it manage to grab millions of attention on their first release..

a few bug:
- after/during battle: the client crash, player can walk arround
- if the person looses: sometimes the battle 'UI' didnt disapear and block the background

I say fix what we have, and make it more like gold and silver.
then once that's done, make it better.
by adding newer animations newer maps newer pokemon.
we need a stable client to do that. and that means we need to work on the game client first.
the server is stable and probably doesn't need much work just yet.
combat animations, better menus, with better navigation.
login and logout features.
making movement work so there is less time between get direction and move.
also so other clients are getting real-time movements from other players.
get the current npc's and pokemon working.
also scripting quests like the one that gets you the pokedex.... adding a pokedex to the main menu. fixing the pokemon pain. or making new one from scratch.

these need to be addressed first. from my point of view anyway.


@- if the person looses: sometimes the battle 'UI' didnt disapear and block the background
i have seen this error too. not sure what it is because i haven't looked yet. but its on my list of things to fix.

[xkl]

So much work <3