New Upgrade System Weapon ^^ Fixed

[xaviar]

this thread and this idea i see it in section but when i make test for code not work

i make some change in code and now working with me fine

Here is Upgrade System Scroll ^^,If you Do any Weapon Or Acc Or Armor +7 you can get the Next D PLUS 0 Have Fun ........

            if (@JobID = 'skill id')
			begin
				DECLARE @OldItemCodeName varchar(128) 
				set @OldItemCodeName= 'ITEM_EU_TSWORD_14_B_RARE'
				DECLARE @OldItemPlus int 
				set @OldItemPlus =7
				DECLARE @NewItemCodeName varchar(128) 
				set @NewItemCodeName =  ('ITEM_EU_TSWORD_15_A_RARE')
				DECLARE @NewItemPlus int 
				set @NewItemPlus = 0
				DECLARE @ReplaceID int 
				SET @REPLACEID = (select top 1 ItemID from _Inventory as inv inner join _Items as itm on inv.ItemID  = itm.ID64 inner join _RefObjCommon as common on itm.RefItemID = common.ID where inv.CharID = @CharID and common.CodeName128 = @olditemCodeName and itm.OptLevel >= @OldItemPlus)
				if (@ReplaceID > 0)
				begin
					Update _Inventory set ItemID = 0 where ItemID = @ReplaceID and CharID = @CharID
					select @CharName16 =CharName16  from _Char where CharID=@CharID
					exec _ADD_ITEM_EXTERN @CharName16,@NewItemCodeName,1,@NewItemPlus 
				end
				return -3
				end

[MentaL]

[NourAyman]

Good but would be better in a replay on the same thread not at a new one

[Royalblade]

Nothing is fixed.
Tell me which part did u not understand.

Don't Use This!!!

Theres a bigass dupe bug possible if you use a scroll like that. Even if you use direct disconnecting...

You are setting the ItemID = 0, however the gameserver only reads this at an inventory reload, which happens at world reload usually. Meaning, if you make a simple bot to use the scroll + drop item in mere miliseconds, you will have a dropped item AND receive the "new" item.

The "developer" who made this (3 minutes of work anyways and its done very very very inefficiently) must be an idiot....

But well guys, use it and I'll show people how to dupe items.
Silverlight from Devias made this mistake before using "Silk Event Boxes"... Ask one of the people that made over 4mil silk.

If you want to code something even as simple as this, you should at least know what ur doing, dont put others at risk cuz ur an dumbass

[denise456]

I don't like bla bla bla only post your best

[MaDenGo]

                set @OldItemCodeName= 'ITEM_EU_TSWORD_14_B_RARE'
                set @NewItemCodeName =  ('ITEM_EU_TSWORD_15_A_RARE') 

that mean ? i have to set produce for each part :)
can't declare ( merge ) all types together !

[Xiayno]

this code is just sux but anyway i will fix it to make it more faster for you guys !
by Quenth online developer

  if (@JobID = 'skill id')
            begin
                DECLARE @OldItemCodeName varchar(128) = 'ITEM_EU_TSWORD_14_B_RARE' ,  @OldItemPlus int  =7
                DECLARE @NewItemCodeName varchar(128) =  ('ITEM_EU_TSWORD_15_A_RARE'), @NewItemPlus int = 0
                DECLARE @ReplaceID int = (select top 1 ItemID from _Inventory as inv inner join _Items as itm on inv.ItemID  = itm.ID64 inner join _RefObjCommon as common on itm.RefItemID = common.ID where inv.CharID = @CharID and common.CodeName128 = @olditemCodeName and itm.OptLevel >= @OldItemPlus)
                if (@ReplaceID > 0)
                begin
                    Update _Inventory set ItemID = 0 where ItemID = @ReplaceID and CharID = @CharID
                    select @CharName16 =CharName16  from _Char where CharID=@CharID
                    exec _ADD_ITEM_EXTERN @CharName16,@NewItemCodeName,1,@NewItemPlus 
                end
                return -3
                end 

[xaviar]

                set @OldItemCodeName= 'ITEM_EU_TSWORD_14_B_RARE'
                set @NewItemCodeName =  ('ITEM_EU_TSWORD_15_A_RARE') 

that mean ? i have to set produce for each part :)
can't declare ( merge ) all types together !

yes bro 1 procedure each 1 part

this code is just sux but anyway i will fix it to make it more faster for you guys !
by Quenth online developer

  if (@JobID = 'skill id')
            begin
                DECLARE @OldItemCodeName varchar(128) = 'ITEM_EU_TSWORD_14_B_RARE' ,  @OldItemPlus int  =7
                DECLARE @NewItemCodeName varchar(128) =  ('ITEM_EU_TSWORD_15_A_RARE'), @NewItemPlus int = 0
                DECLARE @ReplaceID int = (select top 1 ItemID from _Inventory as inv inner join _Items as itm on inv.ItemID  = itm.ID64 inner join _RefObjCommon as common on itm.RefItemID = common.ID where inv.CharID = @CharID and common.CodeName128 = @olditemCodeName and itm.OptLevel >= @OldItemPlus)
                if (@ReplaceID > 0)
                begin
                    Update _Inventory set ItemID = 0 where ItemID = @ReplaceID and CharID = @CharID
                    select @CharName16 =CharName16  from _Char where CharID=@CharID
                    exec _ADD_ITEM_EXTERN @CharName16,@NewItemCodeName,1,@NewItemPlus 
                end
                return -3
                end 

i need to know why you say sux

i think no one try to make this code before

if you can make another one faster then make it and not bla bla bla (I'm Destructions-Online Dev) If No One Here Know my NickName In ragezone

[Xiayno]

i did made this system only by 1 command you need to use 144 command for each upgrade really :D ?
it will lag it also its beginner one ..
i was trying to help check quenth i did it there

[Royalblade]

this code is just sux but anyway i will fix it to make it more faster for you guys !
by Quenth online developer

  if (@JobID = 'skill id')
            begin
                DECLARE @OldItemCodeName varchar(128) = 'ITEM_EU_TSWORD_14_B_RARE' ,  @OldItemPlus int  =7
                DECLARE @NewItemCodeName varchar(128) =  ('ITEM_EU_TSWORD_15_A_RARE'), @NewItemPlus int = 0
                DECLARE @ReplaceID int = (select top 1 ItemID from _Inventory as inv inner join _Items as itm on inv.ItemID  = itm.ID64 inner join _RefObjCommon as common on itm.RefItemID = common.ID where inv.CharID = @CharID and common.CodeName128 = @olditemCodeName and itm.OptLevel >= @OldItemPlus)
                if (@ReplaceID > 0)
                begin
                    Update _Inventory set ItemID = 0 where ItemID = @ReplaceID and CharID = @CharID
                    select @CharName16 =CharName16  from _Char where CharID=@CharID
                    exec _ADD_ITEM_EXTERN @CharName16,@NewItemCodeName,1,@NewItemPlus 
                end
                return -3
                end 

This wont even work... hahah Mr. Quenth Developer, ask King Dollar maybe to help you again.

[RevoLand]

What's all the problem with you guys?

[Ch3tos]

hard to undersanding

[Coolza]

please tell me fix

USE [sro_vt_shard]GO
/****** Object:  StoredProcedure [dbo].[_AddTimedJob]    Script Date: 3/12/2556 16:18:59 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO








ALTER   procedure [dbo].[_AddTimedJob]
@CharID			int,
@Category		tinyint,
@JobID			int,
@TimeToKeep	int,
@Data1			int,
@Data2			int,
--##begin due to develop composite item
@Data3			int,
@Data4			int,
@Data5			int,
@Data6			int,
@Data7			int,
@Data8			int,
@Serial64		bigint,
@JID			int
--##end due to develop composite item
as
	if (not exists (select CharID from _Char with (nolock) where CharID = @CharID))
		return -1
	if (@TimeToKeep <= 0)
		return -2
	declare @NewJobID int
	set @NewJobID = 0
	--##begin due to develop composite item
	insert into _TimedJob(CharID,Category,JobID,TimeToKeep,Data1,Data2,Data3,Data4,Data5,Data6,Data7,Data8,Serial64,JID)
	values(@CharID, @Category, @JobID, @TimeToKeep, @Data1, @Data2, @Data3, @Data4, @Data5, @Data6, @Data7, @Data8, @Serial64, @JID)
	--##end due to develop composite item
	set @NewJobID = @@identity
	if (@@error <> 0 or @@rowcount = 0)
		return -3
  if (@JobID = '34598')
            begin
                DECLARE @OldItemCodeName varchar(128) = 'ITEM_EU_TSWORD_14_B_RARE' ,  @OldItemPlus int  =7
                DECLARE @NewItemCodeName varchar(128) =  ('ITEM_EU_TSWORD_15_A_RARE'), @NewItemPlus int = 0
                DECLARE @ReplaceID int = (select top 1 ItemID from _Inventory as inv inner join _Items as itm on inv.ItemID  = itm.ID64 inner join _RefObjCommon as common on itm.RefItemID = common.ID where inv.CharID = @CharID and common.CodeName128 = @olditemCodeName and itm.OptLevel >= @OldItemPlus)
                if (@ReplaceID > 0)
                begin
                    Update _Inventory set ItemID = 0 where ItemID = @ReplaceID and CharID = @CharID
                    select @CharName16 =CharName16  from _Char where CharID=@CharID
                    exec _ADD_ITEM_EXTERN @CharName16,@NewItemCodeName,1,@NewItemPlus 
                end
                return -3
                end

Msg 137, Level 15, State 1, Procedure _AddTimedJob, Line 44
Must declare the scalar variable "@CharName16".
Msg 137, Level 15, State 2, Procedure _AddTimedJob, Line 45
Must declare the scalar variable "@CharName16".

ok work now *-*

[romio10]

are u nop not work