Re: pwAdmin [web shop, item builder] v1.0
I don't want to bother you, but how did you maintain this code? o.o
And for example in DeleteUserAccount you could use LEFT JOIN to delete the data instead of create/execute the DB. Maybe you don't that (you just want to show the code) but if someone decide to help you in GitHub is impossible (or maybe a extremelly hard task) There's a lot of variable named in a way that is impossible to guess what they does. And avoid the usage of to many if/else.
Anyway. Congratulations for the project and for use pure javascript!
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
w3bm4ster
I don't want to bother you, but how did you maintain this code? o.o
And for example in DeleteUserAccount you could use LEFT JOIN to delete the data instead of create/execute the DB. Maybe you don't that (you just want to show the code) but if someone decide to help you in GitHub is impossible (or maybe a extremelly hard task) There's a lot of variable named in a way that is impossible to guess what they does. And avoid the usage of to many if/else.
Anyway. Congratulations for the project and for use pure javascript!
Don't bothered me at all, I maintaned with 3 server (1.4.2,1.5.3 loko, 1.5.3 hrace) then I reinstalled the OS so need install back everything but after OS install I got no space because I worked on a bigger video editing and not long ago finished :)
About delete user u mean make a join for 3-4 table and delete that way?
Honestly maybe easier with using foreign key, no?
About if in few file reduced but not from all (lack of time).
And about variable names, can you tell where is the problem? If not much then I could make comments or replace the names.
Honestly I want make many thing but I can't dublicat myself, idk if at you exist that expression with ride on more horse with on ass :)
So if you want give advice about how could improve then I try do but bigger stuff can't do like rewrite all because working on other web now where I focus on jQuery and json techniques without backend
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
shadowvzs
honestly i lost, what you talking about?
role edit/stop & start server not was added.
The create from web and login with client work with methode from last post?
if yes then web shop also must work and item builder but somehow i see this discussion is one sided since i asked you for upload data files from client and also can check with team viwer if u write pm but u didnt do,
i mean problem for creating account is solved
now i get new problem with adding webshop content, start/stop server from web, and last editing role in web
Re: pwAdmin [web shop, item builder] v1.0
You have error or something?
Normally if u use pw.sql from loko files then rerun my setup.php then the table created to webshop because I guess that the problem.
(Server start/stop & role edit not was added, I started to work on role XML reading but aborted, takes too much time to make better than pwAdmin by Ronny (I wanted design better))
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
shadowvzs
-
Yeah, cascade delete work too. About the expression...I get it! :).
About variable name, just if someone decide to help you, they'll lose time trying to understand what "u" do. Comments are great but to many comments is worst as guess-what variable name. And nope. You don't need to rewrite but you can check about avoid the excessive usage of if/else.
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
w3bm4ster
Yeah, cascade delete work too. About the expression...I get it! :).
About variable name, just if someone decide to help you, they'll lose time trying to understand what "u" do. Comments are great but to many comments is worst as guess-what variable name. And nope. You don't need to rewrite but you can check about avoid the excessive usage of if/else.
Ah I thought it's self explanatory those, u=user, p/pw=password, m=mail, uid=userid etc well when I wrote I thought best if I use short variable names because long ago I heard it is better.
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
shadowvzs
Ah I thought it's self explanatory those, u=user, p/pw=password, m=mail, uid=userid etc well when I wrote I thought best if I use short variable names because long ago I heard it is better.
u = use, usage, unique, etc.
p = public, private, protected
pw = paul walker, perfect world (For password, you can use: passwd
uid = unique identifier
Depending on where this variables are set, can cause confusion.
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
w3bm4ster
u = use, usage, unique, etc.
p = public, private, protected
pw = paul walker, perfect world (For password, you can use: passwd
uid = unique identifier
Depending on where this variables are set, can cause confusion.
he's project owner, i'm sure he decide what variable name he will put in the code, also maybe he's learning about coding, you don't know about it, as i see, the project works good for everybody, ( at least his project works by the way ), WYSIWYG seems good and easy to handle with it, if you want help him, contribute with github project, i didnt see any commit from you.
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
w3bm4ster
u = use, usage, unique, etc.
p = public, private, protected
pw = paul walker, perfect world (For password, you can use: passwd
uid = unique identifier
Depending on where this variables are set, can cause confusion.
and you store in session then use for identify the user? and like said i wanted make short variable names, i don't said the best but when i did the page i thougth it is best way.
Quote:
$un=$_SESSION['un'];
$pw=$_SESSION['pw'];
$uid=$_SESSION['id'];
$ma=$_SESSION['ma'];
if (($uid==$AdminId)&&($atool>0)){
$link = new mysqli($DB_Host, $DB_User, $DB_Password, $DB_Name);
$Admin=VerifyAdmin($link, $un, $pw, $uid, $ma);
then
Quote:
function VerifyAdmin($con, $username, $password, $userid, $email){
example from shorter version for camel names
un=username=>UserName=>UN=>un
pw=most used short version for password (is 2 letter)
uid=is like id, i doubt someone have question what is the id, and user or unique id in this case both true coz every user id is unique id :)
well ma not that complicate just first 2 letter but also except identify user not used for other thing
maybe not the best names, but in short term i thougth it is easy to find out what is it.
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
Bola
he's project owner, i'm sure he decide what variable name he will put in the code, also maybe he's learning about coding, you don't know about it, as i see, the project works good for everybody, ( at least his project works by the way ), WYSIWYG seems good and easy to handle with it, if you want help him, contribute with github project, i didnt see any commit from you.
Yeah. And I like the @shadowvzs work. Despite being a newbie, he's doing the things. And about GitHub: That's why I mentioned the fact of put better name on variables, is more easier to understand and help him. @Bola I know that "is working" for you is more important than code quality. But he's not you and I'll follow the tips that I've received in this career. @shadowvzs, is easier for you not for who decide to help you, if you want to keep, not problem, but I maintain my advice. @Bola. Are you always around, aren't you? Keep that way. In few days you'll see what I can do when I'm earning something. Curious fact about that: I a short amount of time. People told me that you spend 3 months +/-? And got a lot of problems after that. =P
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
w3bm4ster
Yeah. And I like the @
shadowvzs work. Despite being a newbie, he's doing the things. And about GitHub: That's why I mentioned the fact of put better name on variables, is more easier to understand and help him. @
Bola I know that
"is working" for you is more important than
code quality. But he's not you and I'll follow the tips that I've received in this career. @
shadowvzs, is easier for you not for who decide to help you, if you want to keep, not problem, but I maintain my advice. @
Bola. Are you always around, aren't you? Keep that way. In few days you'll see what I can do when I'm earning something. Curious fact about that: I a short amount of time. People told me that you spend 3 months +/-? And got a lot of problems after that. =P
english motherf***er do you speak it ?!
Re: pwAdmin [web shop, item builder] v1.0
Quote:
Originally Posted by
Bola
english motherf***er do you speak it ?!
Your mother drop you on your head when you were a baby?
Re: pwAdmin [web shop, item builder] v1.0
Hello Shadowvzs! Are you alright? I sincerely hope you are well! I am new here in the forum, I am now starting to create perfect world servers, according to its version 1.3.9 ~ 1.4.2. I was able to install correctly, but when trying to install PwAdmin I do not know how to proceed. because by the video I see that you put the pwAdmin.tar.gz file in the var / www directory. and this directory does not exist for me. How can I proceed with this? Sorry if it's a very noob question, I'm starting now. I'd be grateful if you could help me install it as I was delighted with your PwAdmin. Many thanks in advance.
Re: pwAdmin [web shop, item builder] v1.0
Re: pwAdmin [web shop, item builder] v1.0
I tried to combine this pwAdmin with hrace009 1.5.5 version, while doing setup.php, I cannot get pass step 2 (open the pw database).
Is anyone interesting in trying this with me?