[PHP] User System

[Hexadecimal]

This was basically only done for fun. Not for idea theft. Not for profit. Not to make m0nsta look bad.

I saw the thread Mark [m0nsta] did, and decided to do one myself.

Now, it's not completed, but soon enough, it will be.

Screenshots;

Screenshot by Lightshot - Login

Screenshot by Lightshot - Register

Screenshot by Lightshot - Register w/ errors

Screenshot by Lightshot - Picture of Login.php

Screenshot by Lightshot - Picture of Register.php

Development is still occurring. The finished project will be placed up for release if all goes well.

Any feedback/suggestions?

[MentaL]

[iAkira]

Well for one that class file must be Huge but looks decent :].

[Hexadecimal]

Well for one that class file must be Huge but looks decent :].

It's not all one class file. I learned to separate classes into other files to keep means organized. C;

Screenshot by Lightshot

[Gravious]

Suuuuucckks :3
Nah, looks good. Maybe you can make some sort of community thing out of it? So that you can add friends and send private messages?
Posted via Mobile Device

[s-p-n]

You are not making m0nsta look bad, but you are making him look good.

[Hexadecimal]

I didn't intend for it to make him look good nor ad. I meant from the bolding on the OP that it wasn't meant to if any users thought so.

[foxx]

you posted code as a screenshot? lol

[s-p-n]

I didn't intend for it to make him look good nor ad. I meant from the bolding on the OP that it wasn't meant to if any users thought so.

You didn't have to put that disclaimer, but okay.

M0nsta posts open source code. If you're going to mention him, you can improve his code. If you're creating it all yourself, you don't have to mention anyone.

[TheAJ]

This is not worth showing off... anyone can do this.

[Mootie]

Well for one that class file must be Huge but looks decent :].

Are all PHP coders so lazy? This would take at most 30minutes to write, I don't see any need to post a thread about it. Sites I've done sometimes have classes with upwards of 1000 lines(usually an actual CMS).

Sure, you show off some extremely basic OOPHP, but I don't even see you passing variables by reference(not that this is necessary, but if you're showing off OOP...)

class CSecure
{
static function Escape(&$var) // doesn't need to be dynamic
{
// sanitize $var
}
}

$username = $_POST['username'];
CSecure::Escape($username); 

You could also show how your class initialization works, because that is a key in performance for large PHP sites. This is where OOP comes in, not at such simplistic levels unless purely for example.

Btw nice captcha...

[Lapje]

Something which might be easy for you might have taken hours and hours for somebody else. The showcase isn't there only for useful and 1337 stuff, it's to show what you are able to do and show that to other people.

I never saw any rule stating a show case thread has to be all pro and useful to others. I did however see a rule which stated "Saying only something like "this sucks!" will get you warned or even banned!" which is pretty much what you said there, xLethal.

[jMerliN]

Suggestions:

1. Smaller border radius. Large rounded corners are obnoxious and painful to look at.
2. Don't emit HTML from PHP, instead develop the UI in HTML/JS/CSS then send XHR POST's to the back-end to do authentication, and return only JSON. As emitted HTML in this fashion is difficult to cache, you end up wasting a lot of network traffic on what are really just you wanting to ask the back end "is this person authenticated with this username/pw pair?".
3. Support SSL and proper session ID switching (using secure only session and changing the insecure session ID after log-in, as well as generating a per-session independent key to use for anti-CSRF purposes).

[Mootie]

Something which might be easy for you might have taken hours and hours for somebody else. The showcase isn't there only for useful and 1337 stuff, it's to show what you are able to do and show that to other people.

I never saw any rule stating a show case thread has to be all pro and useful to others. I did however see a rule which stated "Saying only something like "this sucks!" will get you warned or even banned!" which is pretty much what you said there, xLethal.

What I gave was 100% constructive criticism. If you want someone to baby you, maybe you shouldn't post code on a forum that supports illegal development. You aren't going to get better when you need someone to tell you "good job" every 30 minutes you code something.

Suggestions:

1. Smaller border radius. Large rounded corners are obnoxious and painful to look at.
2. Don't emit HTML from PHP, instead develop the UI in HTML/JS/CSS then send XHR POST's to the back-end to do authentication, and return only JSON. As emitted HTML in this fashion is difficult to cache, you end up wasting a lot of network traffic on what are really just you wanting to ask the back end "is this person authenticated with this username/pw pair?".
3. Support SSL and proper session ID switching (using secure only session and changing the insecure session ID after log-in, as well as generating a per-session independent key to use for anti-CSRF purposes).

2 - This is definitely good, a simple "1" or "0" could be enough of a response for some cases.

3 - SSL isn't necessary for most sites, and I don't see how he would show SSL support in code really. A custom session ID can be useful, but must be implemented carefully. I don't see it necessary in most cases, unless the site has a "remember me" feature.

[holthelper]

coding your own emulator is not illegal. the only illegal part about what servers do here is hosting those emulators.

[Mootie]

coding your own emulator is not illegal. the only illegal part about what servers do here is hosting those emulators.

I suppose those emulators were coded without reverse engineering the clients in any way ...

Packet decryption goes against most game ToS. Emulators are just as illegal as private servers themselves in most cases. Anyways, if this forum didn't support illegal content then why was it moved to Russia?