What am I doing wrong here?

[X_Sarah_X]

Alright here's the deal.
I want to change the XOR keys in client (cabalmain.exe and *.enc files).

First thing I did was check the location of every single .enc file.
If I'm right they all should be in the Data folder with a few .enc files digged into

Data/Item
Data/Map
Data/Maze
Data/Monster
Data/NPC

After finding them I decompressed them all using balq's tools.
I did the necessary edits (ips changed in language.enc)
I recompressed them using balq's tools with new XOR keys
For this example i'll use XOR keys 12, 34, 56 and 78.

My xor.xml:

<?xml version="1.0" encoding="ISO-8859-1" ?>
<xor_config>
	<xor_key id="1" value="12" />
	<xor_key id="2" value="34" />
	<xor_key id="3" value="56" />
	<xor_key id="4" value="78" />
</xor_config>

Next step I'm firing up Ollydbg to edit my Cabalmain.exe
This is what it looks like in Ollydbg:


So I go to "Copy to Executable" -> Save All Modifications -> Save File, overwriting my original EXE.

However, when I launch Cabalmain.exe I get a horrific ESTSoft report error.

I've used the OGPlanet 2008 Vanilla client posted in the stickies with the patch Yamachi posted in that same topic.

Is there something I'm doing wrong? Or is it something else causing this issue?

Hope some of you guys can help me with this.

[MentaL]

[Disconnect1]

If i`m not wrong you have to convert them (never tested this..)

[Yamachi]

Looking in ollydbg, from top to bottom, the keys are in this order: 4, 3, 2, 1.
Make sure the first key is above 0x7F (127), and the rest of the keys are 0x7F or below.

[PunkS7yle]

Data/Item
Data/Map
Data/Maze
Data/Monster
Data/NPC

You did change the ones in Data/ too right ? D:

[X_Sarah_X]

Yes, I copied every single *.enc file (even initiated a search job in my entire Cabal folder to make sure I got all of them) and decompressed them, then compressed them using the new keys.

@Yamachi: Yes, I know that, however I thought the exact way you are thinking now. I was like "What if i read my cabalmain.exe the wrong way and I switched around my XOR keys like 1=4, 2=3?
So then I re-edited my Cabalmain.exe and switched around my XOR keys, but it resulted in the same problem.

Should it work when using the client files that I used?


++EDIT++

I managed to solve my problem.
Thanks everyone who offered their help, and Yamachi specifically since that made me think about some things, leading to the solution :D