/find command [1.5]

Yeah yeah whatever people, some new members are asking me for these stuff, believe it or not !
So a quick kick off, just no intro, or anything else -.-

ZChat_Cmds.cpp

Code:

---

void ChatCmd_FindPlayer(const char* line, const int argc, char **const argv);

---

Code:

---

_CC_AC("find", &ChatCmd_FindPlayer, CCF_ALL, 1, 1, true, "/find <charname>", "");

---

Code:

---

void ChatCmd_FindPlayer(const char* line,const int argc, char **const argv)
{
      ZPostWhere(argv[1]);
}

---

Save > Build > Run..
Obviously ya'll know what's this, usage: /find <player_name>
Done, Peace :):

All of this is unnecessary

Code:

---

        if(argc < 2)
        {
                sprintf(szMsg, "^2Usage: /find <charname>");
                ZChatOutput(szMsg);
                return;
        }

---

Just change the "ARGVNoMin" to have a minimum of 1 and then it'll automatically output the useage.

That's why that's there.

Quote:

---

Originally Posted by Killer1478

All of this is unnecessary

Code:

---

        if(argc < 2)
        {
                sprintf(szMsg, "^2Usage: /find <charname>");
                ZChatOutput(szMsg);
                return;
        }

---

Just change the "ARGVNoMin" to have a minimum of 1 and then it'll automatically output the useage.

That's why that's there.

---

I know this, u didn't give me something new :): .. just wanted to add this line for fun xD
You know that each command could be done in 1000... ways, i don't have to tell that to someone like you, and u also should'vr known that i knew this ez stuff :/

Quote:

---

Originally Posted by Tannous

I know this, u didn't give me something new :): .. just wanted to add this line for fun xD
You know that each command could be done in 1000... ways, i don't have to tell that to someone like you, and u also should'vr known that i knew this ez stuff :/

---

I'm not being rude but you wouldn't just add a line in for fun, you would try and make the code look as neat as possible, you didn't know that.

But thanks a bunch for the release, all is useful in this community.

Quote:

---

Originally Posted by Chrisss

I'm not being rude but you wouldn't just add a line in for fun, you would try and make the code look as neat as possible, you didn't know that.

But thanks a bunch for the release, all is useful in this community.

---

Bro i don't mean any offense either but i DID add it for fun, just to remind you i am NOT the old Tannous u used to know 2 or 1 years ago...
Now i can do w/e i want, without asking anyone...
Just to let u know i am learning CS done 1st year tho.
So don't try to be smart and decide by your self, and yeah think whatever u want to think, in the end i know that i knew this. Not begging u to believe me :):
No offense again, peace mate <3

Quote:

---

Originally Posted by Tannous

I know this, u didn't give me something new :): .. just wanted to add this line for fun xD
You know that each command could be done in 1000... ways, i don't have to tell that to someone like you, and u also should'vr known that i knew this ez stuff :/

---

I don't give a shit if you knew it or not, I'm correcting the code you wrote and left here.
It's not necessary and should not have been added in the first place.

Quote:

---

Originally Posted by Tannous

Code:

---

...
        char szMsg[256];
        if(argc < 2)
        {
                sprintf(szMsg, "^2Usage: /find <charname>");
                ZChatOutput(szMsg);
                return;
        }
...

---

---

Can't quite wrap my head around why you used sprintf to format a static string into a fixed-size buffer (which is obviously waaaaaay too big for the string (you already know the length of the string; it's static (also more parentheses wooo))).

You guys just need to chill, i don't care what do you tell me, due to the fact that i know rvery single word you wrote. And just to mention, i decide the way i want to show my self NOT you :): and i don't care what do you think either.
So just as Phoenix said once, "i'm closing this thread before it's out of control".. but since i can't close it, i'm ENDING THIS DISCUSSION before it gets out of control. Think w/e you want, ROFL, like ffs i give a sh!t

Quote:

---

Originally Posted by Tannous

You guys just need to chill, i don't care what do you tell me, due to the fact that i know rvery single word you wrote. And just to mention, i decide the way i want to show my self NOT you :): and i don't care what do you think either.
So just as Phoenix said once, "i'm closing this thread before it's out of control".. but since i can't close it, i'm ENDING THIS DISCUSSION before it gets out of control. Think w/e you want, ROFL, like ffs i give a sh!t

---

Code:

---

char Tannous[2048 * 1024];
sprintf(Tannous, "Knock knock open up the door it's real. With the non-stop pop pop and stainless steel");
__asm
{
nop;
}
printf("%s", Tannous);

---

liek if u cried
1 like = 1 rip

Quote:

---

Originally Posted by Tannous

You guys just need to chill, i don't care what do you tell me, due to the fact that i know rvery single word you wrote. And just to mention, i decide the way i want to show my self NOT you :): and i don't care what do you think either.
So just as Phoenix said once, "i'm closing this thread before it's out of control".. but since i can't close it, i'm ENDING THIS DISCUSSION before it gets out of control. Think w/e you want, ROFL, like ffs i give a sh!t

---

The point is, every single snippet of code you've posted so far is absolutely atrocious, and yet you refuse to accept tips from people that are clearly far better than you at programming, and go "LALALA I CAN'T HEAR YOU STOP BEING MEAN TO ME". With this kind of attitude, you'll never achieve anything in this industry.

Quote:

---

Originally Posted by NOPCODE

Code:

---

char Tannous[2048 * 1024];
sprintf(Tannous, "Knock knock open up the door it's real. With the non-stop pop pop and stainless steel");
__asm
{
nop;
}
printf("%s", Tannous);

---

liek if u cried
1 like = 1 rip

---

I love how you added a semicolon after nop because that's obviously what you do in ASM! No, seriously, don't show off with code that you have no knowledge of.

Also, keep all of your ego's down, they're useless and make no sense against oldgen developers that actually do know their stuff.

Quote:

---

Originally Posted by Solaire

I love how you added a semicolon after nop because that's obviously what you do in ASM! No, seriously, don't show off with code that you have no knowledge of.

Also, keep all of your ego's down, they're useless and make no sense against oldgen developers that actually do know their stuff.

---

http://img.4plebs.org/boards/tg/imag...1715132190.jpg

Anyway, the whole idea at first wasn't to poke fun at him, it was to point things out that he should do to improve his releases. It's all fine and dandy for him to say "if you want secure code, then secure it yourself" but the fact of the matter is that if someone knew how to make his code better then they would be capable of writing it themselves. Yes, he's done some things that a lot of people wouldn't do, and it's obvious that he's new to programming, but people are giving him advice and he's just brushing it off and making excuses rather than actually taking peoples suggestions into consideration. There are many ways of doing things and nobody knows everything; so people should always be open to help and advice from others; even seasoned programmers make mistakes.

Quote:

---

Originally Posted by NOPCODE

http://img.4plebs.org/boards/tg/imag...1715132190.jpg

Anyway, the whole idea at first wasn't to poke fun at him, it was to point things out that he should do to improve his releases. It's all fine and dandy for him to say "if you want secure code, then secure it yourself" but the fact of the matter is that if someone knew how to make his code better then they would be capable of writing it themselves. Yes, he's done some things that a lot of people wouldn't do, and it's obvious that he's new to programming, but people are giving him advice and he's just brushing it off and making excuses rather than actually taking peoples suggestions into consideration. There are many ways of doing things and nobody knows everything; so people should always be open to help and advice from others; even seasoned programmers make mistakes.

---

JOKE, and being rude.. anyways not gonna reply.
if you really think i'm noob, NOT forcing you to change your mind. just don't say i have a bad attitude cuz i never, humiliated you <3 (that's insulting what r u doing now) !!!

Quote:

---

Originally Posted by Tannous

JOKE, and being rude.. anyways not gonna reply.
if you really think i'm noob, NOT forcing you to change your mind. just don't say i have a bad attitude cuz i never, humiliated you <3 (that's insulting what r u doing now) !!!

---

Everyone has to start somewhere, which is why I wouldn't poke fun at people for making silly mistakes or doing things sub-optimally. However, I do when people ignore valid advice given to them and make up excuses. Arrogance will get you nowhere.

Also, just for the record you said that you weren't going to reply but in order to state that you weren't going to reply you actually replied ;)

Quote:

---

Originally Posted by Solaire

I love how you added a semicolon after nop because that's obviously what you do in ASM! No, seriously, don't show off with code that you have no knowledge of.

Also, keep all of your ego's down, they're useless and make no sense against oldgen developers that actually do know their stuff.

---

Keep in mind that there's a difference between "ego" and constructive criticism. In this case:
1) Allocating too much memory for a static-sized string.
2) Using sprintf for a static string
3) Usage could be printed automatically by following Killer1478's suggestion
4) Casting a const char* to a char* and then casting it back to a const char*
His entire function could literally be done like this

Code:

---

void ChatCmd_FindPlayer(const char* line,const int argc, char **const argv)
{
    ZPostWhere(argv[1]);
}

---