Script Problems

I feel embarrassed asking why this doesn't work, but i need to learn. Its very simple script and shouldnt be giving me errors but for some reason, whenever it gets to the line cm.openNpc(9200000); it D/c's me and says in the log Send NPC_CHAT, thats a packet error isnt it? Does the openNpc function need to be in a seperate status? I also tried this script with a selection, says like choose your path. Then it would go and open the npc with a selection in status 1 instead of just directly doing it after hitting next. I know the scripts probably poorly written and executing not well but it works untill the point of opening the other npc..

heres the script see what you can do guys!

PHP Code:

---

var status = -1;
var nationcoin = 999999; //filler

function start() {
    status = -1;
    action(1, 0, 0);
}

function action(mode, type, selection) {
    if (mode == 0 || mode == -1 && status == 0) {
        cm.dispose();
        return;
    } else
        (mode == 1 ? status++ : status--);
    if (status == 0) {
    if (cm.getPlayer().getJob() == 0){
    cm.sendSimple("Greetings great hero, welcome to the server. I will be your mentor and I am here to help you begin your adventure. Please continue and choose yourself a path. Then talk to me again!");
    }else{
    cm.sendOk("I have a task for you now, please perform it and I will send you on your way! Bring me 30 Nation coins, from the uglies in the other room. They steal them all the time!");
    cm.dispose();
    }
    }else if (status == 1){
    cm.dispose();
    cm.openNpc(9900002);
    if (cm.getPlayer().haveItem(nationcoin, 30)){
    cm.sendSimple("Great, for your help I will take you to where you can begin your adventure and reward you with 3 of these special coins, hold on to them they'll come in handy.");
    cm.warp(910000000);
    cm.gainItem(nationcoin, -100000);
    cm.gainItem(nationcoin, 3);
    cm.dispose();
    }else{
    cm.sendOk("Please get me those coins sir!");
    cm.dispose();
    }
}
} 


---

Why do you dispose the npc (finish it / end it), and then open another npc (while being disposed), following by warping the user after disposing the npc and opening another npc, and then also giving them an item all in one status? That's.. what?!

Also, you're dcing because you sent two npc packets. After you've cm.openNpc'd the first window, you send a cm.sendSimple window as well (Or if they don't have coins - a cm.sendOk window). Two NPC windows will crash you. Also, I suggest cm.sendNext over cm.sendSimple if you're not adding selections.

Alright i fixed it up, using selections now. Although i didn't want to I don't have enough experience or know how to make it work the way i was doing it. Here is what i did, i still have a problem with the last part. When sending the cm.sendOk() after the cm.warp. It d/cs me, so is it not possible to have a dialogue to come up after you turn in the coins? I know i could just have it go into another status but that wouldnt be worth it. Heres the script now.

PHP Code:

---

var status = -1;
var nationcoin = 4000010; //filler slimebubbles -.-
//map id 746000012

function start() {
    status = -1;
    action(1, 0, 0);
}

function action(mode, type, selection) {
    if (mode == 0 || mode == -1 && status == 0) {
        cm.dispose();
        return;
    } else
        (mode == 1 ? status++ : status--);
    if (status == 0) {
    cm.sendOk("Greetings great hero, welcome to the server. I will be your mentor and I am here to help you begin your adventure. Please continue and choose yourself a path. Then talk to me again! \r\n#L0#Choose my Path\r\n#L1#I have chosen#k");
    }else if (status == 1){
    if (selection == 0){
    if (cm.getPlayer().getJob() == 0){
    cm.dispose();
    cm.openNpc(9900002);
    }else{
    cm.sendOk("You've chosen already!");
    cm.dispose();
    }
    }else if (selection == 1){
    cm.sendOk("I have a task for you now, please perform it and I will send you on your way! Bring me 30 Nation coins, from the uglies in the other room. They steal them all the time! \r\n#L0#I have your coins\r\n#L1#I will get them#k");
    }
    }else if (status == 2){
    if (selection == 0){
    if (cm.getPlayer().haveItem(nationcoin, 30)){
    //cm.sendOk("Thank you #h #, I will send you on your way with a reward. Good luck!"); Doesnt appear when placed here.
    cm.gainItem(nationcoin, -999);
    cm.gainItem(nationcoin, 3);
    cm.warp(910000000);
    //cm.sendOk("Thank you #h #, I will send you on your way with a reward. Good luck!"); D/cs after warp ..
    cm.dispose();
    }else{
    cm.sendOk("Please get me those coins sir");
    cm.dispose();
    }
    }else if(selection == 1){
    cm.dispose();
    }
    }
    } 


---

PHP Code:

---

var status = -1;
var nationcoin = 4000010; //filler slimebubbles -.-
//map id 746000012

function start() {
    action(1, 0, 0);
}

function action(mode, type, selection) {
    if (mode == 0 || mode == -1 && status == 0) {
        cm.dispose();
        return;
    } else
        (mode == 1 ? status++ : status--);
    if (status == 0) {
        cm.sendSimple("Greetings great hero, welcome to the server. I will be your mentor and I am here to help you begin your adventure. Please continue and choose yourself a path. Then talk to me again! \r\n#L0#Choose my Path\r\n#L1#I have chosen#k");
    } else if (status == 1) {
        if (selection == 0){
            if (cm.getPlayer().getJob() == 0) {
                cm.openNpc(9900002);
            } else {
                cm.sendOk("You've chosen already!");
            }
            cm.dispose();
        } else if (selection == 1) {
            cm.sendSimple("I have a task for you now, please perform it and I will send you on your way! Bring me 30 Nation coins, from the uglies in the other room. They steal them all the time! \r\n#L0#I have your coins\r\n#L1#I will get them#k");
        }
    } else if (status == 2) {
        if (selection == 0) {
            if (cm.getPlayer().haveItem(nationcoin, 30)){
                cm.gainItem(nationcoin, -999);
                cm.gainItem(nationcoin, 3);
                cm.warp(910000000);
                cm.sendOk("Thank you #h #, I will send you on your way with a reward. Good luck!"); 
            } else {
                cm.sendOk("Please get me those coins sir");
            }
        }
        cm.dispose();
    }
} 


---

http://i.imgur.com/Qii7In9.png

Oh, and some quick tips:
- Don't send status = -1; twice. If you declare var status = -1, you won't need to re-declare.
- You could send an if-statement checking for job upon the first window, rather than making them click twice (if you prefer, just seems weird to re-click and such)
- If you wanted to, you could make them job-change upon the NPC and then continue, rather than opening an npc and then talking to him again.

Quote:

---

Originally Posted by chunkarama

Oh, and some quick tips:
- Don't send status = -1; twice. If you declare var status = -1, you won't need to re-declare.
- You could send an if-statement checking for job upon the first window, rather than making them click twice (if you prefer, just seems weird to re-click and such)
- If you wanted to, you could make them job-change upon the NPC and then continue, rather than opening an npc and then talking to him again.

---

Yes your correct, I dont know why i declared the status twice that was dumb. I tried in the first script to make it so that it would check whether or not they had the proper job so that they wouldnt have to continue clicking, but thats where i got the to many chat dialogues in a status error, so im not that far along yet to make that work. I will play around with it and see if I can make it work like that. Also yes, I could make it so theres a job selection/advancer via the script and it would work much better.
Thank you for the help and the suggestions, Ill continue to work on it.

Quote:

---

Originally Posted by moehog5

Yes your correct, I dont know why i declared the status twice that was dumb. I tried in the first script to make it so that it would check whether or not they had the proper job so that they wouldnt have to continue clicking, but thats where i got the to many chat dialogues in a status error, so im not that far along yet to make that work. I will play around with it and see if I can make it work like that. Also yes, I could make it so theres a job selection/advancer via the script and it would work much better.
Thank you for the help and the suggestions, Ill continue to work on it.

---

Huh? Just check for job on status 0 and switch. Depending on how big the script is, you can even skip status's like done below:

PHP Code:

---

if (status == 0) {
    if (cm.getPlayer().getJob() == 0) {
        status = 1; // will immediately ++ after choosing selection into status 2,handle selections there 
        cm.sendSimple("#L0#Choose your path");
    } else { // will be handled in status 1, handle selections there 
        cm.sendSimple("#L0#I have your items");
    }
} 


---

This will make it so the first time you click him he has one option, and after you've job changed he has the other.