Simple point script

Hello ragezone,

I'm not super active on ragezone, but everytime I come to check if people need help on the help section I always see the same question, or atleast I see it very often.
"Help mi, why me script no worky?"
And when you open that post its always the same story:
"HELP MY SCRIPT NOT WORK
here is the script (without [code] tags ofcourse)
---
---
---
500 lines later
help me."

Now 90% of the time there is either this going on:
OP says: "looked on ragezone, couldn't find a fix/script"
Another guy says: "Please look at other post, other threads, blablabla"

Another fact about these kind of 'script problem' posts; they are often some kind of player made shops (npc shop) which trades vote/event points for items. (since beginners don't use loops they copy pasta their code a million times)

So I wanted to give it a try to stop this endless cycle, here is an easy editable script (you only have to edit the arrays/varriables)

TL;DR
Hi, this is a script, bye.

PHP Code:

/** * * @author NmZero * point trader (event by default) */ var status = -1; var SERVERNAME = "Ragezone"; var CATEGORIES = ["shoes", "hats"]; var ITEMS = [ [[4000000, 10], [4000017, 20]], // shoes (works like this: [[item id, price], [item id, price]]) you can add more yourself! [[4000000, 30], [4000017, 40]] // hats ]; var STORAGE1; var STORAGE2; function start() { if (cm.getPlayer().isGM()) cm.sendNext(caw("Welcome, master." + "\r\nChoose any item of choice without a price.\r\n" + "\r\nP.S. Those colors aren't overused at all.")); else cm.sendNext("Hello, I'm the event point trader for #r"+SERVERNAME+"#k."); } function action(m, t, s) { (m === 1 ? status++ : (status < 1 ? (status--, cm.dispose()) : status--)); if (status === 0) { var text = "Hey, I trade event points for items!\r\nYou currently have #r"+cm.getPlayer().getEventPoints()+"#k event points.\r\nWhich category would you like to view?\r\n"; for (var i = 0; i < CATEGORIES.length; i++) text += "\r\n#L"+i+"#"+caw(CATEGORIES[i])+"#l"; cm.sendSimple(text); } else if (status === 1) { STORAGE1 = s; var options = "Choose The item you want.\r\nYou currently have #r"+cm.getPlayer().getEventPoints()+"#k event points.\r\n"; for (var x = 0; x < ITEMS[s].length; x++) options += "\r\n#L"+x+"##i"+ITEMS[s][x][0]+"# "+cr()+"#t"+ITEMS[s][x][0]+"##k for "+(cm.getPlayer().isGM() === false ? ""+ITEMS[s][x][1]+" EP" : ""+cr()+"FREE")+"#l"; cm.sendSimple(options); } else if (status === 2) { if (cm.getPlayer().isGM()) { cm.gainItem(ITEMS[STORAGE1][s][0], 1); cm.sendOk(""+cr()+"H"+cr()+"e"+cr()+"r"+cr()+"e "+cr()+"y"+cr()+"a "+cr()+"g"+cr()+"o"+cr()+"."); cm.dispose(); } else { STORAGE2 = s; cm.sendYesNo("Are you sure you want to buy #i"+ITEMS[STORAGE1][s][0]+"# "+cr()+"#t"+ITEMS[STORAGE1][s][0]+"##k for #r"+ITEMS[STORAGE1][s][1]+"#k event points?"); } } else if (status === 3) { if (cm.getPlayer().getEventPoints() >= ITEMS[STORAGE1][STORAGE2][1]) { cm.getPlayer().gainEventPoints(-ITEMS[STORAGE1][STORAGE2][1]); cm.gainItem(ITEMS[STORAGE1][STORAGE2][0], 1); cm.sendOk("Enjoy your #i"+ITEMS[STORAGE1][STORAGE2][0]+"# "+cr()+"#t"+ITEMS[STORAGE1][STORAGE2][0]+"##k!"); } else { var mathIsFun = ITEMS[STORAGE1][STORAGE2][1] - cm.getPlayer().getEventPoints(); cm.sendOk("Sorry, you don't have enough event points.\r\nYou need #r"+mathIsFun+"#k more event points"); } cm.dispose(); } } function caw(str) { //caw = color all words ^_^ var colored = ""; var splitted = str.split(" "); for each (var i in splitted) colored += cr() + " "+i; return colored; } function cr() { var colors = ["b", "d", "g", "r", "k"]; return "#" + colors[(Math.floor(Math.random() * 5))]; }

Before people scream that they dont understand this code (how to edit it)
here is a FAQ before anybody actually asked anything (I can look into the future :cool:)

TL;DR
FAQ:

Spoiler:

Question: "How can I add items/catogories to this script?"
Short answer: Look at the comments in the script itself, or try things out for a change, worst thing that can happen is you break it, in which case you can retry.
Long answer: I designed this script so that it could be easily edited without touching the main code, but if you are unfamilliar with multidimensional arrays this might be a little confusing, especially when you dont know arrays at all. First lets try to add a new category. this one uses a simple array. To add a new category look at the top of the script, you should see the following:

Code:

var CATEGORY = ["shoes", "hats"];

Now to add a new category, all you have to do is add:

Code:

, "a new category!"

after:

Code:

"hats"

Your new code should look like this:

Code:

var CATEGORY = ["shoes", "hats", "a new category!"];

And ur done! You can do this as many times as you want.
But we aren't done with the categories yet, below the CATEGORY is an array called ITEMS

Code:

var ITEMS = [ [[4000000, 10], [4000017, 20]], // shoes (works like this: [[item id, price], [item id, price]]) you can add more yourself! [[4000000, 30], [4000017, 40]] // hats ];

Since we added a new category, this itemlist should also be updated!
after each line of this array you can see 2 slashes "//" (this is a comment) with after that shoes and hats, now if you look at CATEGORY you can also see shoes and hats, but since you added another category there is also "a new category!" - under the hats line and above the ]; line, we need to add a new line

Code:

[[4000000, 30], [4000017, 40]] // a new category!

Now it should look like this:

Code:

var ITEMS = [ [[4000000, 10], [4000017, 20]], // shoes (works like this: [[item id, price], [item id, price]]) you can add more yourself! [[4000000, 30], [4000017, 40]], // hats [[4000000, 30], [4000017, 40]] // a new category! ];

Now you have succesfully added a category.
Adding items is just as easy!
4000000 and 4000017 are item id's and the number behind it is the price, to add another item simply add

Code:

, [itemid, price]

after the existing item, so it should look like this:

Code:

var ITEMS = [ [[4000000, 10], [4000017, 20], [itemid, price], [itemid, price], [itemid, price]], // shoes (works like this: [[item id, price], [item id, price]]) you can add more yourself! [[4000000, 30], [4000017, 40], [itemid, price]], // hats [[4000000, 30], [4000017, 40]] // a new category! ];

of course you have to add a real itemid and price!
ok, so far for the item adding.

Question: "I want to have this with votepoints, not eventpoints."
Short answer: edit all getEventPoints and gainEventPoints to > getVotePoints and gainVotePoints.
Long answer: nope, I don't think I can explain that one better...

Question: "I get this error:"

Code:

javax.script.ScriptException: TypeError: Chronos has no such function "getEventPoints" in <eval> at line number 29 at jdk.nashorn.api.scripting.NashornScriptEngine.throwAsScriptException(NashornScriptEngine.java:586) at jdk.nashorn.api.scripting.NashornScriptEngine.invokeImpl(NashornScriptEngine.java:511) at jdk.nashorn.api.scripting.NashornScriptEngine.invokeFunction(NashornScriptEngine.java:227) at scripting.npc.NPCScriptManager.action(NPCScriptManager.java:95) at net.server.channel.handlers.NPCMoreTalkHandler.handlePacket(NPCMoreTalkHandler.java:71) at net.MapleServerHandler.messageReceived(MapleServerHandler.java:127) at org.apache.mina.core.filterchain.DefaultIoFilterChain$TailFilter.messageReceived(DefaultIoFilterChain.java:690) at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextMessageReceived(DefaultIoFilterChain.java:417) at org.apache.mina.core.filterchain.DefaultIoFilterChain.access$1200(DefaultIoFilterChain.java:47) at org.apache.mina.core.filterchain.DefaultIoFilterChain$EntryImpl$1.messageReceived(DefaultIoFilterChain.java:765) at org.apache.mina.filter.codec.ProtocolCodecFilter$ProtocolDecoderOutputImpl.flush(ProtocolCodecFilter.java:407) at org.apache.mina.filter.codec.ProtocolCodecFilter.messageReceived(ProtocolCodecFilter.java:236) at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextMessageReceived(DefaultIoFilterChain.java:417) at org.apache.mina.core.filterchain.DefaultIoFilterChain.access$1200(DefaultIoFilterChain.java:47) at org.apache.mina.core.filterchain.DefaultIoFilterChain$EntryImpl$1.messageReceived(DefaultIoFilterChain.java:765) at org.apache.mina.core.filterchain.IoFilterAdapter.messageReceived(IoFilterAdapter.java:109) at org.apache.mina.core.filterchain.DefaultIoFilterChain.callNextMessageReceived(DefaultIoFilterChain.java:417) at org.apache.mina.core.filterchain.DefaultIoFilterChain.fireMessageReceived(DefaultIoFilterChain.java:410) at org.apache.mina.core.polling.AbstractPollingIoProcessor.read(AbstractPollingIoProcessor.java:710) at org.apache.mina.core.polling.AbstractPollingIoProcessor.process(AbstractPollingIoProcessor.java:664) at org.apache.mina.core.polling.AbstractPollingIoProcessor.process(AbstractPollingIoProcessor.java:653) at org.apache.mina.core.polling.AbstractPollingIoProcessor.access$600(AbstractPollingIoProcessor.java:67) at org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:1124) at org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: <eval>:29 TypeError: Chronos has no such function "getEventPoints" at jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:58) at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:214) at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:186) at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:173) at jdk.nashorn.internal.runtime.linker.NashornBottomLinker.linkBean(NashornBottomLinker.java:118) at jdk.nashorn.internal.runtime.linker.NashornBottomLinker.getGuardedInvocation(NashornBottomLinker.java:73) at jdk.internal.dynalink.support.CompositeGuardingDynamicLinker.getGuardedInvocation(CompositeGuardingDynamicLinker.java:124) at jdk.internal.dynalink.support.LinkerServicesImpl.getGuardedInvocation(LinkerServicesImpl.java:144) at jdk.internal.dynalink.DynamicLinker.relink(DynamicLinker.java:232) at jdk.nashorn.internal.scripts.Script$\^eval\_.action(<eval>:29) at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:541) at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:209) at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:378) at jdk.nashorn.api.scripting.ScriptObjectMirror.callMember(ScriptObjectMirror.java:185) at jdk.nashorn.api.scripting.NashornScriptEngine.invokeImpl(NashornScriptEngine.java:505) ... 25 more

Answer: Look in your source and open client > MapleCharacter.java and look in this file for a method that says something similiar to this:

Code:

public int getEventPoints() { return eventpoints; }

except for you, its not called "getEventPoints" - but something else
copy this 'something else' and overrwrite every getEventPoints with your 'something else' in the script, you might have to do the same with gainEventPoints (same procedure with any other kind of point)

Question: "When I click on a category (shoes/hats etc) I dc!"
Answer: Let me guess, you get this error popup: http://i.imgur.com/gEiPxz5.png
This means you have an invalid item id in your ITEMS array, recheck your items!

Question: "Sometimes (1 outa 6) I see this in the middle of the chat: "Hello, if you see this in game, tell the owner/coder to stop messing with numbers WAAAAY beyond their understanding!" and I have no idea what I did cause I can't admit I touched something"
Answer: Well, I wish you all the luck in the world, altho I doubt there is any hope for you...

----------------------------------------------------------------
Last but certainly not least; I would love hear any tips/criticism on this script (or on my way too long post for just a simple script)
Anyway, thanks for reading my post, hope it helps! (if anybody actually reads this sentence I'm already happy :3)

p.s. I will however hate you if you criticise my color usage in the script ;c

Re: Simple point script

Good job RmZero! Is this the same script used in Elinia?

Re: Simple point script

Last time I checked, Elinia doesn't have my scripts.
NmZero !== RmZero

Sorry for the confusion, in my defense, I used this name on runescape back in the old day (so im probably first)
anyway, thanks for the good job :)

Re: Simple point script

I was just kidding. But it seemed like you're a fan of him. Never mind then. Good job once again.

Re: Simple point script

Sorry
404 sarcasm not found [emoji14]

Re: Simple point script

+1 for those multidimensional arrays! I can't tell you how many people to this day continue to have 1000 lines of if statements.. :(

Re: Simple point script

You don't have to tell me T_T
Its the reason why I made/released this in the first place

Re: Simple point script

Quote:

Originally Posted by NmZero

You don't have to tell me T_T
Its the reason why I made/released this in the first place

You seem to like going short on scripts AND know ternary's (yay!). The long part of this script that I see would be your switch-case statement. As it seems you don't need to use if-else (you can see your errors unlike others), you should return a ternary one-line color string. It can go shorter than this, but here is "color" initially declared.

PHP Code:

function cr() { var rand = Math.floor(Math.random() * 5) + 1; var color = "#" + (rand == 1 ? "b" : rand == 2 ? "d" : rand == 3 ? "g" : rand == 5 ? "r" : "k"); return color; }

Re: Simple point script

Quote:

Originally Posted by chunkarama

You seem to like going short on scripts AND know ternary's (yay!). The long part of this script that I see would be your switch-case statement. As it seems you don't need to use if-else (you can see your errors unlike others), you should return a ternary one-line color string. It can go shorter than this, but here is "color" initially declared.

PHP Code:

function cr() { var rand = Math.floor(Math.random() * 5) + 1; var color = "#" + (rand == 1 ? "b" : rand == 2 ? "d" : rand == 3 ? "g" : rand == 5 ? "r" : "k"); return color; }

Is ternary something that people don't know? If you consider yourself anywhere above 1% decent I'd hope you would know all of the basics, lol.

Also, again, disgusting use of ternary.

Re: Simple point script

Quote:

Originally Posted by Veda

Is ternary something that people don't know? If you consider yourself anywhere above 1% decent I'd hope you would know all of the basics, lol.

Also, again, disgusting use of ternary.

I use ternary everywhere at all times. All throughout my source and in every NPC script I use there is either a small ternary or a very large ternary. Why so against it? It's not like if-else is faster or something.. I'd prefer to reduce the lines of code in my scripts, and this does that.

Also, I may have learned Java differently because when I was 2% decent I didn't know ternary.

Re: Simple point script

PHP Code:

function cr() { var colors = ["b", "d", "g", "r", "k"]; return "#" + colors[(Math.floor(Math.random() * 5) + 1)]; }

???

Re: Simple point script

Quote:

Originally Posted by Fraysa

PHP Code:

function cr() { var colors = ["b", "d", "g", "r", "k"]; return "#" + colors[(Math.floor(Math.random() * 5) + 1)]; }

???

PHP Code:

function cr() { var colors = ["b", "d", "g", "r", "k"]; return "#" + colors[(Math.floor(Math.random() * 5))]; }

???
array starts at 0 as you know ;)

I really like this one tho
updated the post with this method

Re: Simple point script

Quote:

Originally Posted by NmZero

PHP Code:

function cr() { var colors = ["b", "d", "g", "r", "k"]; return "#" + colors[(Math.floor(Math.random() * 5))]; }

???
array starts at 0 as you know ;)

I really like this one tho
updated the post with this method

sry i kinda sux lel :)) ty for fix

Translation: Thanks for the heads-up, my good sir, I didn't notice that.

Re: Simple point script

Quote:

Originally Posted by chunkarama

I use ternary everywhere at all times. All throughout my source and in every NPC script I use there is either a small ternary or a very large ternary. Why so against it? It's not like if-else is faster or something.. I'd prefer to reduce the lines of code in my scripts, and this does that.

Also, I may have learned Java differently because when I was 2% decent I didn't know ternary.

You shouldn't use ternary for such a long thing. Thats when arrays (as mentioned above), ifs, switch-case come to the script.

Ternary in my opinion should be used for short terms as its very ineffeicient and very hard for the reader to get whats going on when its huge.

Fraysa's method is what I would use for an instance.

Re: Simple point script

Quote:

Originally Posted by Fraysa

PHP Code:

function cr() { var colors = ["b", "d", "g", "r", "k"]; return "#" + colors[(Math.floor(Math.random() * 5) + 1)]; }

???

Nice one, that's an even shorter return line :)

Quote:

Originally Posted by xStr0nGx

You shouldn't use ternary for such a long thing. Thats when arrays (as mentioned above), ifs, switch-case come to the script.

Ternary in my opinion should be used for short terms as its very ineffeicient and very hard for the reader to get whats going on when its huge.

Fraysa's method is what I would use for an instance.

I reduce lines because in my opinion (it's just the way I program) I would prefer to have shorter code. If i'm going to be returning a single int or string, I'm going to use ternary because I can fit it all into one line rather than using if-else-if-else-if-else ... However, yes, if I can use an array like Fraysa had did that would end up being even shorter (again, to me the shorter the better). I also prefer to use ternary within all my NPC's actions whenever I can (instead of using if). ex. (m == 1 ? cm.warp(1, 0) : cm.killPlayer()); and so on. It really just depends on the person I guess.