The default script, at least the one I had (seems most v62 uses that one) had a bug that lets you start the quest over and over again, by asking to take the quiz again before finishing all of the questions. Also, this one lets you ask questions after finishing the quiz, too. Not sure if that's how GMS did it, but I don't see any reason why you shouldn't get to ask him questions after finishing the quest.
Code:
/*Icebyrd Slimm - NLC By Cygnus*/
importPackage(net.sf.odinms.client);
function start() {
status = -1;
action (1,0,0);
}
function action (mode,type,selection) {
if (mode == -1) {
cm.dispose();
} else if (mode == 1) {
status++;
}
if (status == 0 && mode == 1){
cm.sendSimple("What up! Name's Icebyrd Slimm, mayor of New Leaf City! Happy to see you accepted my invite. So, what can I do for you? \r\n#b#L0#What is this place? #l\r\n#L1#Who is Professor Foxwit? #l\r\n#L2#What's a Foxwit Door? #l\r\n#L3#Where are the MesoGears? #l\r\n#L4#What is the Krakian Jungle? #l\r\n#L5#What's a Gear Portal? #l\r\n#L6#What do the street signs mean? #l\r\n#L7#What's the deal with Jack Masque? #l\r\n#L8#Lita Lawless looks like a tough cookie, what's her story?#l\r\n#L9#When will new boroughs open up in the city? #l\r\n#L10#I want to take the quiz!#l");
} else if (status == 1){
if (selection == 0) {
cm.sendNext("I've always dreamed of building a city. Not just any city, but one where everyone was welcome. I used to live in Kerning City, so I decided to see if I could create a city. As I went along in finding the means to do so, I encountered many people, some of whom I've come to regard as friends. Like Professor Foxwit-he's our resident genius; saved him from a group of man-eating plants. Jack Masque is an old hunting buddy from Amoria-almost too smooth of a talker for his own good. Lita and I are old friends from Kerning City-she's saved me a few times with that weapon of hers; so I figured she was a perfect choice for Town Sheriff. It took a bit of persuasion, but she came to believe her destiny lies here. About our resident explorer, Barricade came searching for something; he agreed to bring whatever he found to the museum. I'd heard stories about him and his brother when I was still in Kerning City. And Elpam...well, let's just say he's not from around here. At all. We've spoken before, and he seems to mean well, so I've allowed him to stay. I just realized that I've rambled quite a bit! What else would you like to know?");
} else if (selection == 1) {
cm.sendNext( "A pretty spry guy for being 97. He' s a time-traveler I ran into outside the city one day. Old guy had a bit of trouble with some jungle creatures-like they tried to eat him. In return for me saving him, he agreed to build a time museum. I get the feeling that he's come here for another reason, as he's mentioned more than a few times that New Leaf City has an interesting role to play in the future. Maybe you can find out a bit more... " );
} else if (selection == 2) {
cm.sendNext( "Heh, I asked the same thing when I saw the Professor building them. They're warp points. Pressing Up will warp you to another location. I recommend getting the hang of them, they're our transport system." );
} else if (selection == 3) {
cm.sendNext( "The MesoGears are beneath Bigger Ben. It's a monster-infested section of Bigger Ben that Barricade discovered. It seems to reside in a separate section of the tower-quite strange if you ask me. I hear he needs a bit of help exploring it, you should see him. Be careful though, the Wolf Spiders in there are no joke." );
} else if (selection == 4) {
cm.sendNext( "Ah...well. The Krakian Jungle is located on the outskirts of New Leaf City. Many new and powerful creatures roam those areas, so you'd better be prepared to fight if you head out there. It's at the left end of town. Rumors abound that the Jungle leads to a lost city, but we haven't found anything yet." );
} else if (selection == 5) {
cm.sendNext( "Well, when John found himself in the MesoGears portion of Bigger Ben, he stood on one and went to another location. However, he could only head back and forth-they don't cycle through like the Foxwit Door. Ancient tech for you." );
} else if (selection == 6) {
cm.sendNext( "Well, you'll see them just about everywhere. They're areas under construction. The Red lights mean it's not finished, but the Green lights mean it's open. Check back often, we're always building!" );
} else if (selection == 7) {
cm.sendNext( "Ah, Jack. You know those guys that are too cool for school? The ones who always seem to get away with everything? AND get the girl? Well, that's Jack, but without the girl. He thinks he blew his chance, and began wearing that mask to hide his true identity. My lips are sealed about who he is, but he's from Amoria. He might tell you a bit more if you ask him." );
} else if (selection == 8) {
cm.sendNext( "I've known Lita for a while, thought we've just recently rekindled our friendship. I didn't see her for a quite a bit, but I understand why. She trained for a very, very long time as a Thief. Matter of fact, that's how we first met? I was besieged a group of wayward Mushrooms, and she jumped in to help. When it was time to a pick a sheriff, it was a no-brainer. She's made a promise to help others in their training and protect the city, so if you're interested in a bit of civic duty, speak with her. " );
} else if (selection == 9) {
cm.sendNext( "Soon, my friend. Even though you can't see them, the city developers are hard at work. When they're ready, we'll open them. I know you're looking forward to it and so am I!" );
} else if (selection == 10) {
if ((!cm.getQuestStatus(4900).equals(MapleQuestStatus.Status.COMPLETED)) && (cm.getLevel() >= 15)) {
cm.sendNext("No problem. I'll give you a something nice if you answer them correctly!");
cm.forceStartQuest(4900);
}
else if (cm.getQuestStatus(4911).equals(MapleQuestStatus.Status.COMPLETED)) {
cm.sendNext("You've already solved my questions. Enjoy your trip in NLC!!!");
}
else if (cm.getQuestStatus(4900).equals(MapleQuestStatus.Status.STARTED) || (cm.getQuestStatus(4900).equals(MapleQuestStatus.Status.COMPLETED))) {
cm.sendNext("Hey, pay attention, I'm trying to quiz you on another question!");
}
else {
cm.sendNext("Sorry but this quiz is only available for level 15 and above. Please come back to me when you are ready to take this quiz.")
}
}
}
}
03-05-15
Novak
Re: Icebyrd Slimm GMS-Like
Hmm, though I really do appreciate the gesture of this npc (gms-like) I think you should take a look into variables, array's and other basic JS functions. These kind of scripts are really, really, anooying to look at and Hard to edit.
But yeah, NICE AND SIMPLE EXPLOIT FIX!
03-05-15
Cygnus
Re: Icebyrd Slimm GMS-Like
Quote:
Originally Posted by Novak
Hmm, though I really do appreciate the gesture of this npc (gms-like) I think you should take a look into variables, array's and other basic JS functions. These kind of scripts are really, really, anooying to look at and Hard to edit.
But yeah, NICE AND SIMPLE EXPLOIT FIX!
Hm, do you mean for the 'menu'? The if statements couldn't be made any cleaner to my knowledge. And since this is a one-off script that is unlikely to be edited alot, so I don't think it's worth putting effort into making it into an array. Also, this is how the menu is (well, at least it was) in GMS's script. Thanks for the feedback~
Here's an alternative version with a case selection
Spoiler:
Code:
/*Icebyrd Slimm - NLC Town Quiz ID:9201050By Cygnus*/
importPackage(net.sf.odinms.client);
function start() {
status = -1;
action (1,0,0);
}
function action (mode,type,selection) {
if (mode == -1) {
cm.dispose();
} else if (mode == 1) {
status++;
}
if (status == 0 && mode == 1){
cm.sendSimple("What up! Name's Icebyrd Slimm, mayor of New Leaf City! Happy to see you accepted my invite. So, what can I do for you? \r\n#b#L0#What is this place? #l\r\n#L1#Who is Professor Foxwit? #l\r\n#L2#What's a Foxwit Door? #l\r\n#L3#Where are the MesoGears? #l\r\n#L4#What is the Krakian Jungle? #l\r\n#L5#What's a Gear Portal? #l\r\n#L6#What do the street signs mean? #l\r\n#L7#What's the deal with Jack Masque? #l\r\n#L8#Lita Lawless looks like a tough cookie, what's her story?#l\r\n#L9#When will new boroughs open up in the city? #l\r\n#L10#I want to take the quiz!#l");
} else if (status == 1){
switch (selection) {
case 0:
cm.sendNext("I've always dreamed of building a city. Not just any city, but one where everyone was welcome. I used to live in Kerning City, so I decided to see if I could create a city. As I went along in finding the means to do so, I encountered many people, some of whom I've come to regard as friends. Like Professor Foxwit-he's our resident genius; saved him from a group of man-eating plants. Jack Masque is an old hunting buddy from Amoria-almost too smooth of a talker for his own good. Lita and I are old friends from Kerning City-she's saved me a few times with that weapon of hers; so I figured she was a perfect choice for Town Sheriff. It took a bit of persuasion, but she came to believe her destiny lies here. About our resident explorer, Barricade came searching for something; he agreed to bring whatever he found to the museum. I'd heard stories about him and his brother when I was still in Kerning City. And Elpam...well, let's just say he's not from around here. At all. We've spoken before, and he seems to mean well, so I've allowed him to stay. I just realized that I've rambled quite a bit! What else would you like to know?");
break;
case 1:
cm.sendNext( "A pretty spry guy for being 97. He' s a time-traveler I ran into outside the city one day. Old guy had a bit of trouble with some jungle creatures-like they tried to eat him. In return for me saving him, he agreed to build a time museum. I get the feeling that he's come here for another reason, as he's mentioned more than a few times that New Leaf City has an interesting role to play in the future. Maybe you can find out a bit more... " );
break;
case 2:
cm.sendNext( "Heh, I asked the same thing when I saw the Professor building them. They're warp points. Pressing Up will warp you to another location. I recommend getting the hang of them, they're our transport system." );
case 3:
cm.sendNext( "The MesoGears are beneath Bigger Ben. It's a monster-infested section of Bigger Ben that Barricade discovered. It seems to reside in a separate section of the tower-quite strange if you ask me. I hear he needs a bit of help exploring it, you should see him. Be careful though, the Wolf Spiders in there are no joke." );
break;
case 4:
cm.sendNext( "Ah...well. The Krakian Jungle is located on the outskirts of New Leaf City. Many new and powerful creatures roam those areas, so you'd better be prepared to fight if you head out there. It's at the left end of town. Rumors abound that the Jungle leads to a lost city, but we haven't found anything yet." );
break;
case 5:
cm.sendNext( "Well, when John found himself in the MesoGears portion of Bigger Ben, he stood on one and went to another location. However, he could only head back and forth-they don't cycle through like the Foxwit Door. Ancient tech for you." );
break;
case 6:
cm.sendNext( "Well, you'll see them just about everywhere. They're areas under construction. The Red lights mean it's not finished, but the Green lights mean it's open. Check back often, we're always building!" );
break;
case 7:
cm.sendNext( "Ah, Jack. You know those guys that are too cool for school? The ones who always seem to get away with everything? AND get the girl? Well, that's Jack, but without the girl. He thinks he blew his chance, and began wearing that mask to hide his true identity. My lips are sealed about who he is, but he's from Amoria. He might tell you a bit more if you ask him." );
break;
case 8:
cm.sendNext( "I've known Lita for a while, thought we've just recently rekindled our friendship. I didn't see her for a quite a bit, but I understand why. She trained for a very, very long time as a Thief. Matter of fact, that's how we first met? I was besieged a group of wayward Mushrooms, and she jumped in to help. When it was time to a pick a sheriff, it was a no-brainer. She's made a promise to help others in their training and protect the city, so if you're interested in a bit of civic duty, speak with her. " );
break;
case 9:
cm.sendNext( "Soon, my friend. Even though you can't see them, the city developers are hard at work. When they're ready, we'll open them. I know you're looking forward to it and so am I!" );
break;
case 10:
if ((!cm.getQuestStatus(4900).equals(MapleQuestStatus.Status.COMPLETED)) && (cm.getLevel() >= 15)) {
cm.sendNext("No problem. I'll give you a something nice if you answer them correctly!");
cm.forceStartQuest(4900);
}
else if (cm.getQuestStatus(4911).equals(MapleQuestStatus.Status.COMPLETED)) {
cm.sendNext("You've already solved my questions. Enjoy your trip in NLC!!!");
}
else if (cm.getQuestStatus(4900).equals(MapleQuestStatus.Status.STARTED) || (cm.getQuestStatus(4900).equals(MapleQuestStatus.Status.COMPLETED))) {
cm.sendNext("Hey, pay attention, I'm trying to quiz you on another question!");
}
else {
cm.sendNext("Sorry but this quiz is only available for level 15 and above. Please come back to me when you are ready to take this quiz.")
break;
}
}
}
}
Regards, Cygnus
03-05-15
Novak
Re: Icebyrd Slimm GMS-Like
Well, i'd personally try putting al those sendNext text into an array so that you can neat things up.
It's easier to call the text out of a one line array then having it in the way of everyhing else. that makes the actuall if-else statements easier to read.
But that's not a requirement at all. That's just how i'd do it.
04-05-15
TL Works
Re: Icebyrd Slimm GMS-Like
Could be me but, I am level 61 and it's telling me I need to be higher than level 15?
- - - Updated - - -
Nvm getLevel should be getLevel()
04-05-15
Cygnus
Re: Icebyrd Slimm GMS-Like
Quote:
Originally Posted by Teeria LLC
Could be me but, I am level 61 and it's telling me I need to be higher than level 15?
- - - Updated - - -
Nvm getLevel should be getLevel()
Ah, right you are. Forgot to change that part on here.
Thanks for pointing it out.
Regards, Cygnus
04-05-15
TL Works
Re: Icebyrd Slimm GMS-Like
Quote:
Originally Posted by Cygnus
Ah, right you are. Forgot to change that part on here.
Thanks for pointing it out.
Regards, Cygnus
Now to find why I get the following: TypeError: Cannot find function forceStartQuest in object Conversation with NPC: 9201050.
Obviously it wouldn't exist, but I do have it in the QuestActionManager.java
04-05-15
Cygnus
Re: Icebyrd Slimm GMS-Like
Quote:
Originally Posted by Teeria LLC
Now to find why I get the following: TypeError: Cannot find function forceStartQuest in object Conversation with NPC: 9201050.
Obviously it wouldn't exist, but I do have it in the QuestActionManager.java
You'll need it in your NPCConversationManager.java
04-05-15
TL Works
Re: Icebyrd Slimm GMS-Like
Quote:
Originally Posted by Cygnus
You'll need it in your NPCConversationManager.java
Would this work?
Code:
public class QuestActionManager extends NPCConversationManager {
private boolean start; // this is if the script in question is start or end
private int quest;
public QuestActionManager(MapleClient c, int quest, int npc, boolean start) {
super(c, npc);
this.quest = quest;
this.start = start;
}
public int getQuest() {
return quest;
}
public boolean isStart() {
return start;
}
@Override
public void dispose() {
QuestScriptManager.getInstance().dispose(this, getClient());
}
public boolean forceStartQuest() {
return forceStartQuest(quest);
}
public boolean forceStartQuest(int id) {
return MapleQuest.getInstance(id).forceStart(getPlayer(), getNpc());
}
public boolean forceCompleteQuest() {
return forceCompleteQuest(quest);
}
public boolean forceCompleteQuest(int id) {
return MapleQuest.getInstance(id).forceComplete(getPlayer(), getNpc());
}
}
04-05-15
Cygnus
Re: Icebyrd Slimm GMS-Like
Quote:
Originally Posted by Teeria LLC
Would this work?
Code:
public class QuestActionManager extends NPCConversationManager {
private boolean start; // this is if the script in question is start or end
private int quest;
public QuestActionManager(MapleClient c, int quest, int npc, boolean start) {
super(c, npc);
this.quest = quest;
this.start = start;
}
public int getQuest() {
return quest;
}
public boolean isStart() {
return start;
}
@Override
public void dispose() {
QuestScriptManager.getInstance().dispose(this, getClient());
}
public boolean forceStartQuest() {
return forceStartQuest(quest);
}
public boolean forceStartQuest(int id) {
return MapleQuest.getInstance(id).forceStart(getPlayer(), getNpc());
}
public boolean forceCompleteQuest() {
return forceCompleteQuest(quest);
}
public boolean forceCompleteQuest(int id) {
return MapleQuest.getInstance(id).forceComplete(getPlayer(), getNpc());
}
}
You need to have it in your NPCConversationManager.java.
Your QuestActionManager is used for quest methods, this is a NPC script, not a quest script, the fact that it extends NPCConversationManager just means it implements the methods from your NPCConversationManager, not the other way around.
04-05-15
TL Works
Re: Icebyrd Slimm GMS-Like
Also, shouldn't the first mode check "cm.dispose" be "cm.dispose();"
- - - Updated - - -
Quote:
Originally Posted by Cygnus
You need to have it in your NPCConversationManager.java.
Your QuestActionManager is used for quest methods, this is a NPC script, not a quest script, the fact that it extends NPCConversationManager just means it implements the methods from your NPCConversationManager, not the other way around.
So porting over code wouldn't work?
04-05-15
Cygnus
Re: Icebyrd Slimm GMS-Like
Quote:
Originally Posted by Teeria LLC
Also, shouldn't the first mode check "cm.dispose" be "cm.dispose();"
- - - Updated - - -
So porting over code wouldn't work?
The NPC script reads methods from NPCConversationManager. Unless you modify the script to read methods from the QuestActionManager, it doesn't have access to those methods.
