different methods ?

So, when in trying to create a GMS - Like Job Advancer , (somewhat), I wanted to do a different method. Normally, what comes to mind would be cm.changeJobById, but in this case I tried this way. I'm not too sure, I wanted inputs from fellow RZ.

Code:

---

var job = [[100, "Warrior"], [1100, "Dawn Warrior"]];
var status = 0;
var select;


function start() {
    status = -1;
    action(1, 0, 0);
} 


function action(mode, type, selection) {
    if (mode == 1)
        status++;
    else if (mode == -1)
        status--;
    else {
        cm.dispose();
        return;
    }
    if (status == 0) {
        if (cm.getPlayer().getLevel() >= 10 && cm.getPlayer().getJob() >= 0)
            cm.sendYesNo("Would you like to job advance?");
        else {
            cm.sendOk("You may not advance at the current state");
            cm.dispose();
        }
    } else if (status == 1)    {
        switch (cm.getPlayer.getJob()) {
       
            case 0: // Beginner
                jobSelection(0);
                break;
            case 1000 // Noblesse
                jobSelection(1);
                break;
            case 3000 // Citizen
                jobSelection(2);
                break;
            // 1st Job
            case 1100: //Dawn Warrior
                break;
            case 100: // Warrior
                cm.getPlayer().changeJob(cm.getPlayer().getJob() + 10);
                cm.dispose();
                break;
            default:
                cm.sendOk("You may not advance at the current state");
                cm.dispose();
        }
    } else if (status == 2) {
        select = selection;
        cm.sendYesNo("Have you completely made up your mind?");
    } else if (status == 3) {
        cm.getPlayer().changeJob(select);
        cm.dispose();
    }
}
function jobSelection(index) {
    var choose = "Select your desired job"
    for (var i = 0; i < job[index].length; i++)
        choose += "r\n#L" +job[index][i][1] + "#1";
    cm.sendSimple(choose);
}

---

suggestions?

What suggestions are you looking for/what's the question? As long as it works it doesn't really matter. From a glance I see a few things that aren't needed/used in the script ie. " && cm.getPlayer().getJob() >= 0) ", you never use the id's in your job array, not sure what you're doing with your "case 1100:" either. Also, you have a two-dimensional array, but you're using 3 dimensions here "job[index][i][1]". I'm assuming you just haven't added it yet, but there's also no index 2 for case 3000:

Quote:

---

Originally Posted by Audace

What suggestions are you looking for/what's the question? As long as it works it doesn't really matter. From a glance I see a few things that aren't needed/used in the script ie. " && cm.getPlayer().getJob() >= 0) ", you never use the id's in your job array, not sure what you're doing with your "case 1100:" either. Also, you have a two-dimensional array, but you're using 3 dimensions here "job[index][i][1]". I'm assuming you just haven't added it yet, but there's also no index 2 for case 3000:

---

this has been made with ripped code from a job advancer that has dawn warrior in it, I assume. It could be just future proofing, but yknow.

Switch case works great; but an array would be better.