Printable View
I am seeing an extra line in the hp bar on monsters. Also when the monster is visibly 1/2 hp, it'll die. I had this problem on an RC game i was making and the problem was just an overlay error. Anyone else getting this or know how to attack the problem?
When you attack a mob, you do damage right?
But think, what would happen when your ATK Power is lower than the Defense of the mob?
Here how it looks (example):
ATK Power - Mob's DEF = Damage
2000-1000=1000
But if your ATK Power is lower than the mob's defense, it's:
2000-(-1000)=2000+1000=3000
That's why the gray bar appear when you attack a very strong mob with poor stats and weapon, it's ADDING HP to the mob... same with the character (when the mob attacks you)
What your saying makes sense, but when I am attack Jelly Beans, they have a defence of 0. My attack power + my Weapon attack power (for a lvl 7 visitor with wooden sword, 15 str and 15 def) is 19. So my attack power is always going to be greater. I can post my attack code if you want.
Nah, jelly bean's DEF is something like 8 or 6... but you should be able to hit them anyways... O.o
well, the add hp bug is easy to fix:
Code:hitpower=(hitpower<0)0:hitpower;
hmm. That doesn't fix it. Here is my attack code:
weapon attack method:Code:if (etime > 0.9*CLOCKS_PER_SEC && abs(dx*dx+dy*dy) <= 0) {
unsigned hitpower = unsigned((thisclient->c_level/5) + (thisclient->c_str/2) + (thisclient->c_dex/3.3) + rand()%(thisclient->c_level*5)+1);
//Log( MSG_DEBUG, "weapon refine:%i",(thisclient->items[7].refine) );
// refined weapon damage needs to be added.
switch(thisclient->items[7].refine){
case 16: // 1
hitpower += int(thisclient->GetAtkPower( )*1.06); // add weapon damage;
break;
case 32: // 2
hitpower += int(thisclient->GetAtkPower( )*1.13); // add weapon damage;
break;
case 48: // 3
hitpower += int(thisclient->GetAtkPower( )*1.2); // add weapon damage;
break;
case 64: // 4
hitpower += int(thisclient->GetAtkPower( )*1.3); // add weapon damage;
break;
case 80: // 5
hitpower += int(thisclient->GetAtkPower( )*1.4); // add weapon damage;
break;
case 96: // 6
hitpower += int(thisclient->GetAtkPower( )*1.5); // add weapon damage;
break;
case 112: // 7
hitpower += int(thisclient->GetAtkPower( )*1.65); // add weapon damage;
break;
case 128: // 8
hitpower += int(thisclient->GetAtkPower( )*1.80); // add weapon damage;
break;
case 144: // 9
hitpower += int(thisclient->GetAtkPower( )*2.0); // add weapon damage;
break;
default: // 0
hitpower += thisclient->GetAtkPower( ); // add weapon damage;
break;
} //end switch
hitpower -= (thismon->defense+1);
//Log( MSG_DEBUG, "weapon ap= %i", (thisclient->GetAtkPower( )) );
//Log( MSG_DEBUG, "hitpower= %i", hitpower );
thismon->currenthp -= hitpower;
BEGINPACKET( pak, 0x799 );
ADDWORD( pak, thisclient->clientid );
ADDWORD( pak, thismon->clientid );
ADDDWORD( pak, hitpower );
ADDDWORD( pak, (thismon->currenthp<=0)?16:0 );
SendToVisible( &pak, thismon );
thisclient->lastAttackTime = clock();
}
Code:// -----------------------------------------------------------------------------------------
// Returns the Weapon Attack Power
// -----------------------------------------------------------------------------------------
unsigned CWorldClient::GetAtkPower( )
{
unsigned atkpower = 0;
for( unsigned j = 0; j < 12; j++ ) {
if( items[j].itemtype == 8 ) {
atkpower += ((CWorldServer*)ParentServer)->STB_ITEM[items[j].itemtype-1].rows[items[j].itemnum][35];
} // end if
} // end for
return atkpower;
}
sorry for the sloppy coding, I've never programmed in C++ before. I'm a Java Programmer.
Java is look like a extension of original CQuote:
Originally Posted by barnett81
Yeh java is pretty much the same as C. Your explanation is wrong.
Mobs defence can't be -1000 heres what happens when mobs def is high.Quote:
Here how it looks (example):
ATK Power - Mob's DEF = Damage
2000-1000=1000
But if your ATK Power is lower than the mob's defense, it's:
2000-(-1000)=2000+1000=3000
Attackpower - mobs defence = damage
250 - 350 = -100 All you will do is negative damage which you can solve by saying if damage is less than 0 then set dmg to zero. That is not the problem i am sure the reason the bar is bigger than the hp bar is because the hps are wrong. I changed the hp update for mobs to half and the bar is 3/4 full so it is somthing to do with that.
When I log the defense of the Jelly beans it comes up with 0, and the hitpower is registering correctly with the health of the monster. It just isn't displaying it right. I need to check what the defense is referencing and fix that. I am going to log everything I can and see if I can come up with a solid solution for this bug. I think the character health is related. I am very busy with other venues, but should have a good solution in about a week.
Does that atk code works well?
yeah is that attack code any good and caali
where would i put that code
(would i replace the hitpower code that is already there for player or mons)
That attack code is as close as I could get to actual Rose Evo damage. Its most likely not perfect though.
Caali's code is wrong. It should be:Quote:
Originally Posted by kac123ige
This is just a messy way of saying:Code:hitpower=(hitpower<0)?0:hitpower;
Sry for the late post, but I am still having trouble with the monster defense. When I divide the health by 2, it comes real close, but still isn't correct. Can anyone tell me if the stb rows 7 * 8 is the actual monster health?Code:if(hitpower<0) hitpower=0;
ps. sry for the double post.
barnett... I've already tried that "if(hitpower<0) hitpower=0;" because I logically though it fits... but, it WILL keep adding HP to the mobs, and to you as well... :\ I have no explaination for this...
I just posted the monster defense on the SVN thread. This helps a little with the adding of hp, but it still has the extra little bar.
Keep the "if(hitpower<0) hitpower=0;" though cuz it is needed for monsters with greater defense.
Or even closer to the game, i have:
Code:if(hitpower<5)hitpower = 5;