[PHP]Insert Error

Line thats erroring.

PHP Code:

---

        $res = insertthree("INSERT INTO usergroups (group_id, owner_id, group_name) VALUES ('%s', '%s, '%s')", 'null', $_SESSION["userid"], $groupname);
        if($res != 'Added')
        {
            echo $res;
        } 


---

Insertthree function.

PHP Code:

---

function insertthree($query, $item1, $item2, $item3)
{
    $querysafe = sprintf($query,
    mysql_real_escape_string($item1),
    mysql_real_escape_string($item2),
    mysql_real_escape_string($item3));
    mysql_query($querysafe) or die(mysql_error());
    return 'Added';
} 


---

Error:

Code:

---

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Test')' at line 1

---

I don't quiet see why its erroring, I don't see a error in my script but eh maybe I'm wrong.
Thanks in advanced.

PHP Code:

---

$res = insertthree("INSERT INTO usergroups (group_id, owner_id, group_name) VALUES ('%s', '%s, '%s')", 'null', '".$_SESSION["userid"]."', '$groupname'); 


---

Your query is kinda messy though, so there could be more errors.

Quote:

---

Originally Posted by Pieman

PHP Code:

---

$res = insertthree("INSERT INTO usergroups (group_id, owner_id, group_name) VALUES ('%s', '%s, '%s')", 'null', '".$_SESSION["userid"]."', '$groupname'); 


---

Your query is kinda messy though, so there could be more errors.

---

I've had this error before in this same exact place, I don't remember what i did to fix it though.

Check the syntax, you forgot a single-quote on the third element:

('%s', '%s, '%s')

should be

('%s', '%s', '%s')

Fist query is nearly correct except one thing
You have

PHP Code:

---

"inser into......$_SESSION["userid"],...";
/* now you have " as an external quotes and suddenly u have " as inner, so this cannot 
    like that, it shall be
*/
"insert into.....".$_SESSION['userid'].",...."; 
/* 
    also i think you are missing a ) at the end, cause you close the ) for the function
   but you do not close the ) for the values(....)
*/ 


---

Quote:

---

Originally Posted by Daevious

Check the syntax, you forgot a single-quote on the third element:

('%s', '%s, '%s')

should be

('%s', '%s', '%s')

---

Ye didn't notice that one.
Take care

Thanks, was 6am and that error was makin me mad, looked over the missing ' atleast 4 times.

Yes, I got that aswell.

For future, the error returned is often AFTER (or around) the syntax error, so than you can more effectively abandon errors.