[PHP] S/N Not Showing up

the SN shows up in the DB, but on the site where it needs to be...

PHP Code:

---

function randomkeys($length)
{
  $pattern = "1234567890abcdefghijklmnopqrstuvwxyz";
  for($i=0;$i<$length;$i++)
  {
   if(isset($key))
     $key .= $pattern{rand(0,35)};
   else
     $key = $pattern{rand(0,35)};
  }
  return $key;
}
 
$sn = randomkeys(15);

INSERT INTO Login(UID, ID, PWD, Birth, Type, ExpTime, Email, MSN, AIM, IP, SN)
VALUES ('$z', '$name',$password, '19000101', '0', '4000', '$email', '$msn', '$aim', '$userip', '$sn') 


echo "Account ".$_POST['name']." successfully added!";
echo "<br> Accounts SN is ".$_POST['sn'].""; 


---

You never insert it to the database, I'm surprised you don't get errors.

It should read:

PHP Code:

---

$query = mysql_query("INSERT INTO Login(UID, ID, PWD, Birth, Type, ExpTime, Email, MSN, AIM, IP, SN)
VALUES ('$z', '$name',$password, '19000101', '0', '4000', '$email', '$msn', '$aim', '$userip', '$sn')"); 


---

it is inserted into the DB...

PHP Code:

---

$query = mysql_query("INSERT INTO Login(UID, ID, PWD, Birth, Type, ExpTime, Email, MSN, AIM, IP, >>>SN<<<)
VALUES ('$z', '$name',$password, '19000101', '0', '4000', '$email', '$msn', '$aim', '$userip', >>>'$sn'<<<)"); 


---

By looking at the coding (With you not providing the whole page to look through, This could be wrong) but with SN being defined here:

Code:

---

$sn = randomkeys(15);

---

Should the line displaying it not be like so:

Code:

---

echo "<br> Accounts SN is ".$sn."";

---

Also, After the post sn part, You do not need to quote out as its at the end of the line, Which would then become:

Code:

---

echo "<br> Accounts SN is " . $sn;

---

Just thought you might want to know that, I used to use double quotation at the end too =]

Edit:

Im surprised the query went through too

Quote:

---

Originally Posted by Ace-SG1-

it is inserted into the DB...

PHP Code:

---

$query = mysql_query("INSERT INTO Login(UID, ID, PWD, Birth, Type, ExpTime, Email, MSN, AIM, IP, >>>SN<<<)
VALUES ('$z', '$name',$password, '19000101', '0', '4000', '$email', '$msn', '$aim', '$userip', '$sn')"); 


---

---

Considering the $password variable will most certainly be a string, It needs ' around it, Unlike the numeric values, $z, 19000101, 0, 4000 etc, Which do not need them.

$password alone should have gave it problems inserting into the database.

ty that worked.