[PHP] Loop

ok so im working on a radio site, and im working on a code to refresh the page once the song has been changed. But it just will not work.

PHP Code:

---

<?php
$song = "song.txt";
$fh = fopen($song, 'r');
$data = fread($fh, 100000);

for ($i = 0; $i < 2400;  )
{
if ( $data == $data ) {
echo "$data";
$i = $i + 1;
} else {
include "redirect.php";
}
  }

?>

---

Im trying to get it to check $data every couple of seconds but that will just not work well i found a way for it to work but it is like a jiant dos. So any suggestions.

PHP Code:

---

<?php
$song = "song.txt";
$fh = fopen($song, 'r');
$data = fread($fh, 100000);

for ($i = 0; $i < 2400;  )
{
if ( $data == $data ) {
echo "$data";
$i = $i + -;
} else {
include "redirect.php";
}
  }

?>

---

Why not just do a $_GET?
if(isset($_GET['song'])
{
do the refresh
} else {
do this
}

I can't stand to see that flat code :P:
Use indenting for neetness sake!
And, in a for-to-do loop, if you do for example:

PHP Code:

---

for ($i = 0; $i == 9;)
{
     //Code here
     $i++; //I can increase it because I haven't set the $i++ in the for-to-do loop.
} 


---

But here:

PHP Code:

---

for ($i = 0; $i < 9; $i++)
{
     //Code
     //NO INCREASE! the for-to-do loop will increase it!
} 


---

Proper code:

PHP Code:

---

for ($i = 0; $i < 2400; $i++)
{
     if ($data == $data)
     {
          echo $data; //No need for quotes...
     }
     else
     {
          include "redirect.php";
     }
} 


---

Ok you both didnt help, i dont think you understand what needs to be done, i need the code to be repeated every like 10 seconds, but i dont want it to be repeated all at once. So but thanks, but it didnt help :D

Quote:

---

Originally Posted by lordvladek

Why not just do a $_GET?
if(isset($_GET['song'])
{
do the refresh
} else {
do this
}

---

Ok sorry its a habit.

Quote:

---

Originally Posted by EliteGM

I can't stand to see that flat code :P:
Use indenting for neetness sake!
And, in a for-to-do loop, if you do for example:

PHP Code:

---

for ($i = 0; $i == 9;)
{
     //Code here
     $i++; //I can increase it because I haven't set the $i++ in the for-to-do loop.
} 


---

But here:

PHP Code:

---

for ($i = 0; $i < 9; $i++)
{
     //Code
     //NO INCREASE! the for-to-do loop will increase it!
} 


---

Proper code:

PHP Code:

---

for ($i = 0; $i < 2400; $i++)
{
     if ($data == $data)
     {
          echo $data; //No need for quotes...
     }
     else
     {
          include "redirect.php";
     }
} 


---

---

Hmm.. isn't there some sleep() function or something in PHP?
So you sleep 10,000 MS..

PHP Code:

---

for ($i = 0; $i < 2400; $i++)
{
     if ($data == $data)
     {
          echo $data; //No need for quotes...
     }
     else
     {
          include "redirect.php";
     }
     sleep(10); //Sleep(10): "sleep" (wait) 10 sec.
} 


---

Use JavaScript, Luke. Only and only.

sleep(); function just halts script execution.

It's very hard to keep an active browser connection open while you're executing a script. Not impossible (COMET abuses the fact) but there is a far easier solution: use javascript.

On the page itself you can add a script like this to refresh every N seconds:

Code:

---

setTimeout(refreshPage, refreshTimeOut);

function refreshPage () {
        window.location.reload( false );
}

---

Of course, you will also need to tell your script what song the user has on his screen. To this end you can simply add a GET variable, like page.php?song="songtitle", to your update. Alternatively, forget about the whole redirection at all and just always display current song information on the page?

Why not use a HTML script that reloads the page after certain amount of time (depends on how long the song is playing)

Quote:

---

Originally Posted by EliteGM

Hmm.. isn't there some sleep() function or something in PHP?
So you sleep 10,000 MS..

PHP Code:

---

for ($i = 0; $i < 2400; $i++)
{
     if ($data == $data)
     {
          echo $data; //No need for quotes...
     }
     else
     {
          include "redirect.php";
     }
     sleep(10); //Sleep(10): "sleep" (wait) 10 sec.
} 


---

---

ok sleep makes the whole page sleep for 10 seconds thats why i dont use it

Quote:

---

Originally Posted by admLoki

Use JavaScript, Luke. Only and only.

sleep(); function just halts script execution.

---

who the fuck is luke? lol

Quote:

---

Originally Posted by HotelUnderSeige

who the fuck is luke? lol

---

Watch the "Star Wars", Luke.

sorry if i miss the topic but why are you checking this:

PHP Code:

---

 if ($data == $data) 


---

this is ALWAYS true. I don't know if the compiler checks this and ignores it but u don't need it!

You shoud'nt use PHP to refresh your page. Some tiny Javascript does this job far better but was said by FragFrog.

If you'r realy cool you can use AJAX to update the song without refreshing the whole site.
There are some realy cool frameworks which makes it realy easy to do this. I use prototype on my own: http://www.prototypejs.org/

If you need help with that, ask google or Ragezone ;-)

Thats just an example

In fact I have to agree.

Sleep() function won't help the way JavaScript works.Try to learn some javascript (which you may already know) and do your job.

I didn't indent to write this but it seems strange that you read songs.txt.I know it has nothing to do with the thread but why that? You could do this somehow else.Can't think something right now, you see I already drunk 2 beers :P

-Blane

omg that was hillarious really i loled

Quote:

---

Originally Posted by admLoki

Watch the "Star Wars", Luke.

---

Quote:

---

Originally Posted by MaSch

sorry if i miss the topic but why are you checking this:

PHP Code:

---

 if ($data == $data) 


---

this is ALWAYS true. I don't know if the compiler checks this and ignores it but u don't need it!

You shoud'nt use PHP to refresh your page. Some tiny Javascript does this job far better but was said by FragFrog.

If you'r realy cool you can use AJAX to update the song without refreshing the whole site.
There are some realy cool frameworks which makes it realy easy to do this. I use prototype on my own: http://www.prototypejs.org/

If you need help with that, ask google or Ragezone ;-)

---

Cuase $data = song.txt right? so when song.txt does not equal = $data that means the song has been changed thus the refreshing of the page :D