[PHP] Redirector

OK, I got bored, and most of you can probably make these, but I got realllllllllllly bored and made this.

Have you noticed on RZ, they have that redirector thing, I made my own.

Not as good, but yeah.

PHP Code:

---

<?

$timeout = "3";
$home = "index.php";

if(isset($_GET[url])){
    $redirect = $_GET[url];
    echo "<meta http-equiv=\"Refresh\" content=\"".$timeout.";".$redirect."\">You are now being directed to <b>".$redirect."</b> in ".$timeout." seconds.<br><br>If you do not want to wait, click <a href=\"#clichere\" onclick=\"window.location=('".$redirect."');\">here</a> now!<br><br>Some crap by <a href=\"mailto:mark@zer0-studios.com\">Monsta.</a>.";
}else{
    header("Location: ".$home."");
}

?>

---

It works:

Code:

---

www.gfxdome.co.uk/redirect.php?url=_URL_

---

- Monsta.

Quote:

---

Originally Posted by Monsta.

PHP Code:

---

<?

$timeout = "3";
$home = "index.php";

if(isset($_GET[url])){
    $redirect = $_GET[url];
    echo "<meta http-equiv=\"Refresh\" content=\"".$timeout.";".$redirect."\">You are now being directed to <b>".$redirect."</b> in ".$timeout." seconds.<br><br>If you do not want to wait, click <a href=\"#clichere\" onclick=\"window.location=('".$redirect."');\">here</a> now!<br><br>Some crap by <a href=\"mailto:mark@zer0-studios.com\">Monsta.</a>.";
}else{
    header("Location: ".$home."");
}

?>

---

---

Okay.. But you put allot of extra things in the code. One thing that gets to me in particular is the fact that you use quotes all the time in PHP. In other languages yes, but in PHP it takes longer to parse the quotes than apostrophes. Reason being that quotes are made to parse variables. You don't have to close the quotes when your using variables. Even the way you enclose your PHP, '<? ?>' can do wierd things sometimes, so you should use '<?php ?>'.

Your code will work and all, but it can be better.

PHP Code:

---

<?php

$timeout = 3;
$home = 'index.php';

if(strlen($_GET['url'])>0){
    $redirect = $_GET['url'];
    echo '<meta http-equiv="Refresh" content="'.$timeout.';'.$redirect.'">You are now being directed to <b>'.$redirect.'</b> in '.$timeout.' seconds.<br><br>If you do not want to wait, click <a href="#clichere" onclick="window.location=(\''.$redirect.'\');">here</a> now!<br><br>Some crap by <a href="mailto:mark@zer0-studios.com">Monsta.</a>.';
}else{
    header('Location: '.$home);
}

?>

---

this should be just as good as the one used on ragezone. It's pretty standard most places actually..

Standards alert ! :P:

PHP Code:

---

<?php
    $timeout = 3;
    $home = "index.php";
    $url = $_GET["url"];    

    if (!empty($url))
    {
        echo "<meta http-equiv=\"Refresh\" content=\"". $timeout .";url=". $redirect ."\" />";
        echo "You are now being directed to <b>". $redirect ."</b> in ". $timeout ." seconds.\n";
        echo "<br /><br />\n";
        echo "If you do not want to wait, click <a href=\"#clichere\" onclick=\"window.location=(". $redirect .");\">here</a> now!\n";
        echo "<br /><br />";
        echo "Some crap by <a href=\"mailto:mark@zer0-studios.com\">Monsta.</a>";
    }
    else
    {
        header("Location: ". $home);
    }
?>

---

And there's nothing wrong with quotes... IMO it makes it even better to read =\
And, I believe that javascript doesn't hande escaped quotes, e.g:

PHP Code:

---

echo 'onClick="window.location.href=\'lol.php\';"'; 


---

Idk if that'll work.

PHP Code:

---

echo "onClick=\"window.location.href='lol.php';\""; 


---

That's why I use quotes.

What is this?

It is preferred to use the traditional style call to echo, namely:

PHP Code:

---

echo('Some text.'); 


---

This is my preference since it results in more readable less alien looking code (as otherwise it appears as VB script, PHP was designed to be similar to C, not to VBScript, so don't make it so :\). As long as you keep it consistent, it shouldn't matter.

Also, there is no "standards" issue here. Double quotes are used to delineate strings (in PHP) which may contain escape sequences and variables, thus they are parsed as such. Single quotes should be preferred almost always as they are quite a bit faster. Reference: http://ca.php.net/types.string


Finally, writing a meta tag for refreshing when you haven't already written any HTML output is considerably worse in performance and in standards compliance than using a true header. META tags simulate headers, and when you have access to writing headers, you shouldn't be writing META tags such as this.

PHP Code:

---

header('refresh: 10; url=http://gohere.com'); 


---

This is what "http-equiv" means in your meta tag. While 'refresh' is not a standard header in the HTTP 1.0 or 1.1 protocol, there is a status code reserved for such actions, but because it's so widely adopted, almost ALL browsers support it (in fact, any browser which supports the meta tag will support the header).


One last note: When you *DO* write tags in HTML (or XHTML), do some things:

1. Use a standard heading. This is a doctype followed by a html tag with xmlns and xml:lang attributes.
http://www.w3.org/QA/2002/04/valid-dtd-list.html

2. Follow the XHTML standard (run your code through the markup validator to get help). Primarily, for <meta> tags, terminate them with a /> because they contain no body. The same goes for <hr/>,<br/>,<img/>,etcetcetc.

Headers can't be called in the middle of a HTML document.

Quote:

---

Originally Posted by EliteGM

Headers can't be called in the middle of a HTML document.

---

You don't send it in the middle of your markup, you check your data from your $_GET or $_POST, decide if we're redirecting or not, then send the header and then the markup.

Quote:

---

Originally Posted by EliteGM

Standards alert ! :P:

PHP Code:

---

<?php
    $timeout = 3;
    $home = "index.php";
    $url = $_GET["url"];    

    if (!empty($url))
    {
        echo "<meta http-equiv=\"Refresh\" content=\"". $timeout ."url=". $redirect ."\" />";
        echo "You are now being directed to <b>". $redirect ."</b> in ". $timeout ." seconds.\n";
        echo "<br /><br />\n";
        echo "If you do not want to wait, click <a href=\"#clichere\" onclick=\"window.location=(". $redirect .");">here</a> now!\n";
        echo "<br /><br />";
        echo "Some crap by <a href=\"mailto:mark@zer0-studios.com\">Monsta.</a>"';
    }
    else
    {
        header("Location: ". $home);
    }
?>

---

And there's nothing wrong with quotes... IMO it makes it even better to read =\
And, I believe that javascript doesn't hande escaped quotes, e.g:

PHP Code:

---

echo 'onClick="window.location.href=\'lol.php\';"'; 


---

Idk if that'll work.

PHP Code:

---

echo "onClick=\"window.location.href='lol.php';\""; 


---

That's why I use quotes.

---

Okay.. No, no, no.

And yes, there is something wrong with quotes, in PHP. My post is the best example. As for javascript escaping quotes, google it before you post. Here, I found this for you: http://www.quackit.com/javascript/tutorial/javascript_escape_characters.cfm

Yes, JavaScript could escape characters before you ever went to any tutorial to learn about PHP.

The difference between quotes and apostrophes result in apostrophes loading much faster. I also found this for you: http://www.evolt.org/node/26440


Anyway, no hard feelings pal :cool:

I know my code is all wrong, I tried to edit it but it went all weird so I left it, soz for false info.
I'd hate to bring false info. The edit messed with some quotes -.-
EDIT:
I hope I sort-of fixed it.
I ain't flaming bro, just bringing standards to people, so I can read their code.
No hard feelings at all.

I'm mostly talking of PHP standards, e.g: correct indenting:

PHP Code:

---

<?php
    //4 spaces/1 TAB!
    if ($cond == $cond2)
    {
        //again.
    }
?>

---

also when using headers, use ob_start() and ob_end_flush will prevent alot of headaches on bigger projects with included files etc

EliteGM, indenting is for programmer readability. It's not actually in the Web Standards, it's just recommended. It's cool and all to suggest that, but 5 spaces, 4 spaces; same difference. It's actually best, IMO, to use tab. Of course, ragezone's text-editor has technical difficulties getting the tab key to function differently then the browser default (which is, to jump to next field in form); So we have to use space.

Web Standards, like w3c listed on http://en.wikipedia.org/wiki/Web_standards, are there to make sure that all clients and servers react more or less the same to the XHTML, CSS, JavaScript, etc. The standards could care less if you use tabs, 4 spaces, 5 spaces, hell, 500 spaces!

Escaping quotes in HTML is against the w3 XHTML standards.
This here wouldn't even work in firefox, and gave me 6 errors on validator.w3.org.

Code:

---

<meta http-equiv=\"Refresh\" content=\"3;url=index.php\" />

---

The above isn't a problem if you print/echo it from PHP, just saying..

Also, as expected, this worked fine in firefox, and passed the XHTML test.

PHP Code:

---

echo '<meta http-equiv="Refresh" content="3;url=index.php" />'; 


---

call this in the <head> or above it..

Closing quotes for variables is pointless..
If you're going to use quotes, use one of these

PHP Code:

---

echo "<meta http-equiv='Refresh' content='$timeout;url=$redirect' />";
echo "<meta http-equiv=\"Refresh\" content=\"$timeout;url=$redirect\" />"; 


---

The second line works because PHP replaces (\") with (") before printing it as HTML
Happy Compromise?

Quote:

---

Originally Posted by Fearlest

also when using headers, use ob_start() and ob_end_flush will prevent alot of headaches on bigger projects with included files etc

---

Just be careful that you pay attention to what you are doing, these things nest.

Quote:

---

Originally Posted by s-p-n

EliteGM, indenting is for programmer readability. We don't actually call that standard, it's just recommended. It's cool and all to suggest that, but 5 spaces, 4 spaces; same difference. It's actually best, as you and everyone knows, to use tab.

---

Tabs are best? Arguable. Just like many other things, lots of people have different opinions on that, if you do it with tabs, and port it somewhere else, the tabs likely wont carry over, and the spaces will. (windows to linux for example) Since php ignores spaces when it runs, you wont make your code larger by using spaces.(They wont increase run time)
I think exactly how you do this this is a matter of personal preference, espeically since many coding tools indent for you without tabs or spaces.

Indenting is a certainly best practice, and if you code for a job it very well may be a standard in your workplace.

Quote:

---

Originally Posted by s-p-n

Standards, like presented on w3.org, are procedures that should always be followed to make it easier for the computer to read.Theoretically, if standards are followed, the code will work perfectly no matter where it's parsed. (So long as the parser follows the up-to-date standards as well).

---

Standards are not just for computers:

Quote:

---

Originally Posted by dictionary.com

standards
something considered by an authority or by general consent as a basis of comparison; an approved model.

---

w3c is an Authority. My employer is also an authority over me, and if they say I need to indent, then I indent.

I think what you are trying to say is, no general authority exsist that makes indenting a standard for progammers, it is a best practice and highly recommended for readability, but it doesn't help the code run any better.
Your attitude is coming off a bit arrogant, you may be trying to help people, but you are still learning too, don't forget that.


I think your points about the single and double quotes are also opinions. I've read many opinions that go both way on the topic.

Php.net does not specify that using double quotes are bad, and uses both in their examples. http://us.php.net/echo

Quote:

---

Originally Posted by s-p-n

Now my point. Escaping quotes in HTML is against the w3 XHTML standards.
This here wouldn't even work in firefox, and gave me 6 errors on validator.w3.org.

PHP Code:

---

echo "<meta http-equiv=\"Refresh\" content=\"3;url=index.php\" />"; 


---

+ Another reason why I use apostrophes. Teehee
Also, as expected, this worked fine in firefox, and passed the XHTML test.

PHP Code:

---

echo '<meta http-equiv="Refresh" content="3;url=index.php" />'; 


---

---

Since when?
Your source code on the web page should be the same either way:

Code:

---

<meta http-equiv="Refresh" content="3;url=index.php" />

---

Madison, ZCE

PHP Code:

---

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
<script type="text/javascript">
<!--
function MM_goToURL() { //v3.0
  var i, args=MM_goToURL.arguments; document.MM_returnValue = false;
  for (i=0; i<(args.length-1); i+=2) eval(args[i]+".location='"+args[i+1]+"'");
}
//-->
</script>
</head>

<body onload="MM_goToURL('parent','GoingToThisPage.php');return document.MM_returnValue">
Redirecting...
</body>
</html> 


---

Javascript what i use.
I wish it works for you :)

http://www.ozzu.com/website-design-f...es-t23401.html

Looks extremely similar to this, oh my!
--
/thread;
Standards are your own choice but highly appreciated amongst coders. They make code READABLE!

If you want an immediate redirect without annoying wait time etc (which includes page loads), use the .htaccess file. It's called mod_redirect if I'm not mistaken...

Anyways, here's a nice description: http://www.knd.com.au/apache-redirect-vs-rewrite/

Mod_alias manuel: (redirect included in this document)
http://httpd.apache.org/docs/1.3/mod/mod_alias.html