[PHP] While Loops

PHP Code:

---

<?while($row = mysql_fetch_assoc($sql)) { 
        $i++;
        if(IsEven($i)){
            $even = "even";
        } else {
            $even = "odd";
        }
        $checksql = mysql_fetch_assoc(mysql_query("SELECT * FROM cms_badge_shop WHERE image='".$row['image']."'"));
$check = $checksql['error'];    
        ?>
        <?if($costum == 0){
$filename = $cimagesurl.$badgesurl.$row['image'].'.gif';
}else{
$filename = "http://images.habbohotel.co.uk/c_images/album1584/".$row['image'].".gif";
}
if(file_exists($filename)){
    mysql_query("UPDATE cms_badge_shop SET error = '0' WHERE image = '".$row['image']."' LIMIT 1");
}else{
    $image = './web-gallery/images/failbadge.png';
    $erroredid = mysql_query("UPDATE cms_badge_shop SET error = '1' WHERE image = '".$row['image']."' LIMIT 1");    
}?>
                    <li class="<?php echo $even; ?>">
                <table style="width: 100%">
                    <tr align="center">
                    <?if (isset($image) && $check > 0 ){  ?>
                        <td style="width: 25%"><img src="<?php echo $image; ?>" /></td>
                        <?php }else{ ?>
                    <?if ($costum == 0){ ?>
                        <td style="width: 25%"><img src="<?php echo $cimagesurl.$badgesurl.$row['image'].".gif"; ?>" /></td>
                        <? }else{ ?>
                        <td style="width: 25%"><img src="http://images.habbohotel.co.uk/c_images/album1584/<? echo $row['image']; ?>.gif" /></td>
                        <? }} ?>
                        
                    
                        
                            <td style="width: 35%"><b><?php echo $row['name']; ?></b><br /><?php echo $row['description']; ?></td>
                            <td style="width: 15%"><?php echo $row['cost']; ?></td>
                            <td style="width: 25%">
                            <a class="new-button fill" onclick="habboclub.buttonClick(<?php echo $row['id']; ?>,'Confirm Purchase'); return false;" href="#"><b>Buy Now</b><i></i></a>
                            </td>
                    </tr>
                </table>

---

I've got this code above:
Basically, what it should do is, detect if the image exists, then updates the sql if it doesn't (error).
Then it will display the error image.
But because it's in a while loop: it all the ($row['image'])'s to 1

I'd love some help here. thanks iJames.

What you said made no sense. The only problem you pointed out was that you have it in a while loop; therefore solving your own problem, don't use a while loop.

Clarify?

In your while loop why did u end your php tags and start them up again for no reason :s
Here:

PHP Code:

---

$check = $checksql['error'];    
        ?>
        <?if($costum == 0){

---

Why use a while loop? also, im not sure if u ever ended your loop. It doesnt show all the code.

Right. First of all, that code looks, sorry to say, horrible. No wonder you have a bug, you can't maintain this code.

Try to indent the code in consistent way, I don't care which indentation style you will use, put please use it! For example, this is how a piece of indented code for me looks like:

PHP Code:

---

while ($loop)
{
    $var = 5;
    if ($var == 7)
    {
        echo '$var equals 7';
    }
    else
    {
        echo '$var does not equal 7';
    }
} 


---

Just a simple example, but it does show you what indentation is.

Second, you increase an integer and use some function to determine if it's odd or even. Why not use a boolean?

PHP Code:

---

$even = true;
while (1)
{
    if ($even)
    {
        echo 'Iteration count is even';
    }
    else
    {
        echo 'Iteration count is odd';
    }
    
    $even = !$even;
} 


---

Third, use the <?php tag, and remove instance where it reads: ?><? because that's 100% redundant code. You might even consider using a template engine (build by you, or use something like Smarty, look it up) to separate HTML from PHP, but this might be a big step to get right.

Fourth, now what is your problem? You say:

Quote:

---

But because it's in a while loop: it all the ($row['image'])'s to 1

---

I think you meant to say, "All ($row['image'])'s equal 1, therefore the while loop never ends". If that is what you mean, then I don't see the problem. You don't use ($row['image'])'s at all in your while statement, namely you have the following:

$row = mysql_fetch_assoc($sql)

Which lets the while loop iterate through all MySQL rows you selected somewhere above this code.

A screenshot of the error is here:
http://img.habboupload.com/1239009182.jpg

It always displays the ph box. even tho the image has been found.

Are you sure that the statement

PHP Code:

---

if(file_exists($filename)) 


---

evaluates to true?

Put an echo inside the scope, and see if it's ever executed. Echo the filepath and track if it points to the right (existing) image.

Wait...
file_exists(0 doesn't work on remote files =p
fopen() would be much better for this haha

Correct me if I'm wrong but this is my understanding of the function.

Quote:

---

Originally Posted by Wh005h

Wait...
file_exists(0 doesn't work on remote files =p
fopen() would be much better for this haha

Correct me if I'm wrong but this is my understanding of the function.

---

No their two completely different functions and both of them work for remote files, fopen is for streaming files. file_exists will return false if the file is inaccessible for different reasons.. It depends on allot of things

http://us.php.net/file_exists