Negative mesos fix. (command)

Quite simple:

Into playercommands:

Code:

---

else if (splitted[0].equals("mesosfix")) {
            if (player.getMeso() < 0) {
            player.setMeso(0);
            player.dropMessage("Reset your mesos to 0.");
            }
            else {
                player.dropMessage("You don't have negative mesos.");
            }
        }

---

Into maplecharacter:

Code:

---

    public void setMeso(int set) {
        meso.set(set);
        updateSingleStat(MapleStat.MESO, set, false);
    }

---

Note:It will only set the mesos to 0 if you got negative mesos.

Better prevent than fix? :]
anyways you should add a Negative check or a noob might use it and loose everything. o.o

Quote:

---

Originally Posted by mertjuh

Better prevent than fix? :]
anyways you should add a Negative check or a noob might use it and loose everything. o.o

---

Exactly what I was thinking.

Code:

---

if (getMeso() > 0) {
setMeso(0);
}

---

Well, you can simple add a new command to warn them first. Won't be so hard I guess?

EDIT:

Quote:

---

Originally Posted by LikeReally

Code:

---

if (getMeso() > 0) {
setMeso(0);
}

---

---

Heh, was looking for that. x]

Quote:

---

Originally Posted by Settler11

Well, you can simple add a new command to warn them first. Won't be so hard I guess?

---

Yeah, so Packet Editors can ignore the warning.

Quote:

---

Originally Posted by Settler11

Well, you can simple add a new command to warn them first. Won't be so hard I guess?

EDIT:

Heh, was looking for that. x]

---

Yeah, how clever, if you have more than 1 mesos, why not set it to 0? So everyone have 0 mesos and no more problems :D

Quote:

---

Originally Posted by LikeReally

Code:

---

if (getMeso() < 0) {
setMeso(0);
}

---

---

lol...

Quote:

---

Originally Posted by XxОsirisxX

Yeah, how clever, if you have more than 1 mesos, why not set it to 0? So everyone have 0 mesos and no more problems :D

---

Haha, yea I saw trough that. First I was like "huh?" but it's actually "<" Smaller then.

im wondering what causes negative mesos

Settler11 I hope you don't put what LikeReally said on your server.

Quote:

---

Originally Posted by Settler11

Haha, yea I saw trough that. First I was like "huh?" but it's actually "<" Smaller then.

---

Quote:

---

Originally Posted by XiuzSu

Settler11 I hope you don't put what LikeReally said on your server.

---

You said? Anywayz, it got "if/else" now.
Oh, and I don't run a server since begin may 2010.

Quote:

---

Originally Posted by Settler11

You said? Anywayz, it got "if/else" now.

---

Its acually in math term 'Less than' XD

Can anyone explain me how someone can fking get negative mesos? It shouldn't even be possible to get negative mesos. And MapleStory cannot write negative mesos lol. I've never seen negative mesos when opening my Inventory. If I receive negative mesos it would start at max mesos. That's how people hack mesos ...

Well, I check random servers and on one I found out that you get negative mesos if it reach above the 2,147 bill.

Quote:

---

Originally Posted by Settler11

Well, I check random servers and on one I found out that you get negative mesos if it reach above the 2,147 bill.

---

Omg. Then make a check in the gainMeso function.
if ((getMeso() + gain) == 2147...) {
return;
}

Rather putting this in PlayerUpdateHandler.

Code:

---

if (player.getMeso() > 2147483347) {
player.setMeso(2147483347);
if (player.getAntiCheat().getCheatAttempt > 5) {
player.setMeso(0);
}
} else {
if (player.getMeso() < 0) {
player.setMeso(0);
}

---

Win, simple but hard for glitchers :thumbup1:

Quote:

---

Originally Posted by Carrino

Rather putting this in PlayerUpdateHandler.

Code:

---

if (player.getMeso() > 2147483347) {
player.setMeso(2147483347);
if (player.getAntiCheat().getCheatAttempt > 5) {
player.setMeso(0);
}
} else {
if (player.getMeso() < 0) {
player.setMeso(0);
}

---

Win, simple but hard for glitchers :thumbup1:

---

I prefer just adding it in gainMesos because now you are checking every time when it's entering a channel. So it's better to just prevent them getting negative mesos.

Quote:

---

Originally Posted by kevintjuh93

I prefer just adding it in gainMesos because now you are checking every time when it's entering a channel. So it's better to just prevent them getting negative mesos.

---

Playerupdatehandler will check when you change a map, login and so on.

I suggest adding both of them.

True, but some servers apparently doesn't have that.

Quote:

---

Originally Posted by Carrino

Playerupdatehandler will check when you change a map, login and so on.

I suggest adding both of them.

---

Lol, you said PlayerLoggedinHandler...
And prevention is better than cure.

Quote:

---

Originally Posted by kevintjuh93

Lol, you said PlayerLoggedinHandler...
And prevention is better than cure.

---

What? I said PlayerUpdateHandler, not PlayerLoggedinHandler.

Quote:

---

Originally Posted by Carrino

What? I said PlayerUpdateHandler, not PlayerLoggedinHandler.

---

Lol ok, then why have you edited it. And maybe I was blind.
But still, prevention is better than cure. So checking all the time is pretty gey, when you can just prevent it from happening.

Quote:

---

Originally Posted by Carrino

Playerupdatehandler will check when you change a map, login and so on.

I suggest adding both of them.

---

PlayerUpdateHandler isn't even used. ChangeMapHandler or PlayerLoggedInHandler would be a better solution to this. Also, adding it to the gainMeso function would be more efficient.

@ Xuiz, i hope someone adds it :):.

Quote:

---

Originally Posted by LikeReally

PlayerUpdateHandler isn't even used. ChangeMapHandler or PlayerLoggedInHandler would be a better solution to this. Also, adding it to the gainMeso function would be more efficient.

@ Xuiz, i hope someone adds it :):.

---

After adding these, update message will show everytime when they enters a new map, login, and so on.

v75

Code:

---

PLAYER_UPDATE = 0xD5

---

Handler

Code:

---

package net.channel.handler;

import client.MapleClient;
import net.AbstractMaplePacketHandler;
import org.slf4j.LoggerFactory;
import tools.data.input.SeekableLittleEndianAccessor;

public final class PlayerUpdateHandler extends AbstractMaplePacketHandler {
    private final static org.slf4j.Logger log = LoggerFactory.getLogger(PlayerUpdateHandler.class);
    public final void handlePacket(SeekableLittleEndianAccessor slea, MapleClient c) {
    try {
        c.getPlayer().saveToDB(true);
        log.info("LezDev : Player's data saved : " + c.getPlayer().getName());
    } catch (Exception e) {
      log.info("LezDev : Error caught when saving - " + e);
      }
  }
}

---

Okay, the code explains everything.

I don't actually need to read anything from it, since I don't need any data.

kabooom.

Quote:

---

Originally Posted by Carrino

After adding these, update message will show everytime when they enters a new map, login, and so on.

v75

Code:

---

PLAYER_UPDATE = 0xD5

---

Handler

Code:

---

package net.channel.handler;

import client.MapleClient;
import net.AbstractMaplePacketHandler;
import org.slf4j.LoggerFactory;
import tools.data.input.SeekableLittleEndianAccessor;

public final class PlayerUpdateHandler extends AbstractMaplePacketHandler {
    private final static org.slf4j.Logger log = LoggerFactory.getLogger(PlayerUpdateHandler.class);
    public final void handlePacket(SeekableLittleEndianAccessor slea, MapleClient c) {
    try {
        c.getPlayer().saveToDB(true);
        log.info("LezDev : Player's data saved : " + c.getPlayer().getName());
    } catch (Exception e) {
      log.info("LezDev : Error caught when saving - " + e);
      }
  }
}

---

Okay, the code explains everything.

I don't actually need to read anything from it, since I don't need any data.

---

Why would you add a meso check there when nothing else is being checked there? It needs to be added to the gainMeso function, as this has to do with dealing mesos.

Quote:

---

Originally Posted by LikeReally

Why would you add a meso check there when nothing else is being checked there? It needs to be added to the gainMeso function, as this has to do with dealing mesos.

---

Finally, someone else that is smart enough. People listen. And lol at the PlayerUpdate. Spam the packet and you fking crash lol

Quote:

---

Originally Posted by LikeReally

Why would you add a meso check there when nothing else is being checked there? It needs to be added to the gainMeso function, as this has to do with dealing mesos.

---

Oh okay, what I meant was to check mesos in PlayerUpdateHandler.

Quote:

---

Originally Posted by Carrino

Oh okay, what I meant was to check mesos in PlayerUpdateHandler.

---

That'd crash servers if you knew what PlayerUpdateHandler did.

You guys are idiots, it's impossible to get more than 2147483347 mesos.

Quote:

---

Originally Posted by GoldenKevin

You guys are idiots, it's impossible to get more than 2147483347 mesos.

---

What, everybody here knows.

Quote:

---

Originally Posted by GoldenKevin

You guys are idiots, it's impossible to get more than 2147483347 mesos.

---

It was possible if you played like in v55

Quote:

---

Originally Posted by SirDanielot

Its acually in math term 'Less than' XD

---

I didn't know "less than" was a math term... ?

Quote:

---

Originally Posted by kevintjuh93

Can anyone explain me how someone can fking get negative mesos? It shouldn't even be possible to get negative mesos. And MapleStory cannot write negative mesos lol. I've never seen negative mesos when opening my Inventory. If I receive negative mesos it would start at max mesos. That's how people hack mesos ...

---

Wondering the exact same really, I don't get how people don't have a check in gainMeso.

Quote:

---

Originally Posted by Carrino

After adding these, update message will show everytime when they enters a new map, login, and so on.

v75

Code:

---

PLAYER_UPDATE = 0xD5

---

Handler

Code:

---

package net.channel.handler;

import client.MapleClient;
import net.AbstractMaplePacketHandler;
import org.slf4j.LoggerFactory;
import tools.data.input.SeekableLittleEndianAccessor;

public final class PlayerUpdateHandler extends AbstractMaplePacketHandler {
    private final static org.slf4j.Logger log = LoggerFactory.getLogger(PlayerUpdateHandler.class);
    public final void handlePacket(SeekableLittleEndianAccessor slea, MapleClient c) {
    try {
        c.getPlayer().saveToDB(true);
        log.info("LezDev : Player's data saved : " + c.getPlayer().getName());
    } catch (Exception e) {
      log.info("LezDev : Error caught when saving - " + e);
      }
  }
}

---

Okay, the code explains everything.

I don't actually need to read anything from it, since I don't need any data.

kabooom.

---

LOL savetodb? :w00t:

Quote:

---

Originally Posted by GoldenKevin

You guys are idiots, it's impossible to get more than 2147483347 mesos.

---

actually, if you made mesos into a long... =O
I think it would just show as negative though, yet still continue increasing.

@carrino: good idea to save players when they just logged in.
your way will reduce cpu&memory&harddisk usage alot.

Quote:

---

Originally Posted by buya

@carrino: good idea to save players when they just logged in.
your way will reduce cpu&memory&harddisk usage alot.

---

I know it long ago before adding in, but in order to prevent rollback and suchs, I choose to do this way.

Quote:

---

Originally Posted by buya

@carrino: good idea to save players when they just logged in.
your way will reduce cpu&memory&harddisk usage alot.

---

What lol? It'll constantly send queries, that's what will happend.

This was release a long time ago...

It's not "gaining" mesos. You all fails at thinking.

And yeah, if I can recall correctly, all public source doesn't have this "patched", you can get negative mesos.

I say Nexon failed for making the storage variable for mesos a signed value in the first place, but that's just me.

Quote:

---

Originally Posted by Zygon

I say Nexon failed for making the storage variable for mesos a signed value in the first place, but that's just me.

---

Yeah, it would be really nice from NEXON to make it unsigned, knowing that. mesos - amount < 0 as being unsigned will always be false.

You first need to know what you're talking about before posting, just saying.

Quote:

---

Originally Posted by XxОsirisxX

Yeah, it would be really nice from NEXON to make it unsigned, knowing that. mesos - amount < 0 as being unsigned will always be false.

You first need to know what you're talking about before posting, just saying.

---

You should take your own advice Osi. You assign a higher primitive type for storage (such as a long) on the server (if your engine is Java-based) if they did have it that way, or you could ditch Java and go with a .NET language and have unsigned values.

har har

if (getMesos() < 0) {
setMesos(0);
}

Quote:

---

Originally Posted by Zygon

You should take your own advice Osi. You assign a higher primitive type for storage (such as a long) on the server (if your engine is Java-based) if they did have it that way, or you could ditch Java and go with a .NET language and have unsigned values.

---

Ermm Zygon, that post made not sense at all. You SHOULD know by fact why you have to use a higher data type for unsigned in this case.

Java doesn't support unsigned and believe me, I have researched about this subject way more than what have you read about java at all. So, don't come with shits like "You should take your own advise", what you said makes not really a difference at all, that's the only way around when dealing with unsigned values at a C++ client and using a non-supported-unsigned language in the server.

Don't change subjects by the way, since what you said was really far from what I said.

Let's go back to what you said, why don't you create a Java client, so you don't use what the STUPID NEXON CODERS used, the unsigned values.

Quote:

---

Originally Posted by XxОsirisxX

Ermm Zygon, that post made not sense at all. You SHOULD know by fact why you have to use a higher data type for unsigned in this case.

---

Errr Osi, most of your post is just a re-iteration of mine.
Let me google that for you
First link...

Quote:

---

Originally Posted by XxОsirisxX

Java doesn't support unsigned and believe me, I have researched about this subject way more than what have you read about java at all.

---

Actually, if you knew anything, you can add support for that if you actually knew where to look. You would write it in C, and we both know you can't write C, so GG. Wait, so you've read over 1000+ pages of information on just unsigned values? That's really sad you would waste your time on such a subject that could be covered in little under a page.

Quote:

---

Originally Posted by XxOsirisxX

So, don't come with shits like "You should take your own advise",

---

No, you.

Quote:

---

Originally Posted by XxOsirisxX

what you said makes not really a difference at all, that's the only way around when dealing with unsigned values at a C++ client and using a non-supported-unsigned language in the server.

---

Way to re-iterate my post... *head desk*

Quote:

---

Originally Posted by XxОsirisxX

Don't change subjects by the way, since what you said was really far from what I said.

---

I wasn't changing the subject. My post was just saying what you would do if they did change it to unsigned in the client, please learn to read more carefully.

Quote:

---

Originally Posted by XxОsirisxX

Let's go back to what you said, why don't you create a Java client, so you don't use what the STUPID NEXON CODERS used, the unsigned values.

---

You give me a wz manipulation library in Java and I will make you one, kthxbai.

Quote:

---

Originally Posted by Zygon

Errr Osi, most of your post is just a re-iteration of mine.
Let me google that for you
First link...


Actually, if you knew anything, you can add support for that if you actually knew where to look. You would write it in C, and we both know you can't write C, so GG. Wait, so you've read over 1000+ pages of information on just unsigned values? That's really sad you would waste your time on such a subject that could be covered in little under a page.


No, you.


Way to re-iterate my post... *head desk*


I wasn't changing the subject. My post was just saying what you would do if they did change it to unsigned in the client, please learn to read more carefully.


You give me a wz manipulation library in Java and I will make you one, kthxbai.

---

re-iteration of yours? HA!

Just for your information, before going into Java, I were into C/C++. Then again, this subject is not about coding language, this is about unsigned values. And yeah, I may waste my time looking for it (actually, no), just like I'm doing right now trying to prove you wrong again.

This whole subject became because you failed with unsigned values, implying that NEXON should make mesos unsigned (Which may never works, unless you add 2 variables in the method).

Then, you came to me and said that I should take my own advise which was "You first need to know what you're talking about before posting". In that post, I did and proved. But you changed the subject to "You can use a higher primitive data type if you're using Java and the data sent by client is unsigned" (Which is something that I know by fact, and really off-topic) and also "You could ditch Java and go to .NET then".

You can say anything you wants Zygon, but that's really a subject change right there.

"I wasn't changing the subject.". Yes, you did..

I re-iterated your post? Looks like you're just putting up craps without thinking before posting again.

Seriously, take my advise.

Quote:

---

Originally Posted by XxОsirisxX

Just for your information, before going into Java, I were into C/C++.

---

I'm sure you did.

Quote:

---

Originally Posted by XxОsirisxX

Then again, this subject is not about coding language, this is about unsigned values.

---

Actually, it is about programming languages because of their support of unsigned values. *head desk*

Quote:

---

Originally Posted by XxОsirisxX

And yeah, I may waste my time looking for it (actually, no), just like I'm doing right now trying to prove you wrong again.

---

You are only saying you are wasting time because you know I am right.

Quote:

---

Originally Posted by XxОsirisxX

re-iteration of yours? HA!
This whole subject became because you failed with unsigned values, implying that NEXON should make mesos unsigned (Which may never works, unless you add 2 variables in the method).

---

*head desk* .NET framework languages supports unsigned values, so please think before you respond. You don't need two variables to represent an unsigned value.

Quote:

---

Originally Posted by XxОsirisxX

Then, you came to me and said that I should take my own advise which was "You first need to know what you're talking about before posting". In that post, I did and proved. But you changed the subject to "You can use a higher primitive data type if you're using Java and the data sent by client is unsigned" (Which is something that I know by fact, and really off-topic) and also "You could ditch Java and go to .NET then".

---

That's what the whole argument is about... Please get your head out of your ass Osi.

Quote:

---

Originally Posted by XxОsirisxX

I re-iterated your post? Looks like you're just putting up craps without thinking before posting again.

---

No Osi, that would be you.

Quote:

---

Originally Posted by XxOsirisxX

You can say anything you wants Zygon, but that's really a subject change right there.

"I wasn't changing the subject.". Yes, you did..

---

Obviously you don't understand that mesos can never be negative if the value is unsigned. Unsigned values are always natural numbers (if you don't know what those are, then I truly pity you) or 0 (meaning its another fix for this problem). Hence, my post was quite relevant to this subject.

Quote:

---

Originally Posted by XxOsirisxX

Seriously, take my advise.

---

What advise would that be?

Quote:

---

Originally Posted by Zygon

I'm sure you did.


Actually, it is about programming languages because of their support of unsigned values. *head desk*


You are only saying you are wasting time because you know I am right.


*head desk* .NET framework languages supports unsigned values, so please think before you respond. You don't need two variables to represent an unsigned value.


That's what the whole argument is about... Please get your head out of your ass Osi.


No Osi, that would be you.


Obviously you don't understand that mesos can never be negative if the value is unsigned. Unsigned values are always natural numbers (if you don't know what those are, then I truly pity you) or 0 (meaning its another fix for this problem). Hence, my post was quite relevant to this subject.


What advise would that be?

---

Ok Zygon, you're truly an idiot.

Quote:

---

Actually, it is about programming languages because of their support of unsigned values. *head desk*

---

This is specifically about unsigned values, not programming language. Okay? Learn to understand a conversation dude.

Okay Zygon, now I know why you haven't convinced yourself about your stupidity. It's because:

Quote:

---

Obviously you don't understand that mesos can never be negative if the value is unsigned. Unsigned values are always natural numbers (if you don't know what those are, then I truly pity you) or 0 (meaning its another fix for this problem). Hence, my post was quite relevant to this subject.

---

I do KNOW that mesos can't be negative if you use unsigned values.. But hells, what an idiot...

If you subtract a unsigned value to something below to 0, the result will be POSITIVE! How will you check if the amount to subtract from mesos will be negative, if the stupid mesos variable is unsigned??? the value of the check will be POSITIVE!

Now get why you're an idiot that needs to read and research before posting????

TAKE MY ADVISE, for 3rd time!

Quote:

---

Originally Posted by XxОsirisxX

Ok Zygon, you're truly an idiot.

---

How so? I'm simply telling you what is fact, however you say I'm an idiot for this.

Quote:

---

Originally Posted by XxОsirisxX

This is specifically about unsigned values, not programming language. Okay? Learn to understand a conversation dude.

Okay Zygon, now I know why you haven't convinced yourself about your stupidity. It's because:

---

How about you learn to read English a little bit more carefully? Languages that are capable of using unsigned values are what I'm talking about. -.-'

Quote:

---

Originally Posted by XxОsirisxX

I do KNOW that mesos can't be negative if you use unsigned values.. But hells, what an idiot...

If you subtract a unsigned value to something below to 0, the result will be POSITIVE! How will you check if the amount to subtract from mesos will be negative, if the stupid mesos variable is unsigned??? the value of the check will be POSITIVE!

Now get why you're an idiot that needs to read and research before posting????

TAKE MY ADVISE, for 3rd time!

---

You subtract from an unsigned with an unsigned...

Now this is a no-no, since you're subtracting a signed value from an unsigned value:
4294967295 - -2147483648 = 6442450943

However, since we have unsigned values holding the meso value, we will use unsigned values for our algebraic equations, because doing otherwise wouldn't make any sense:
4294967295 - 4294967295 = 0

Quote:

---

Originally Posted by Zygon

How so? I'm simply telling you what is fact, however you say I'm an idiot for this.


How about you learn to read English a little bit more carefully? Languages that are capable of using unsigned values are what I'm talking about. -.-'


You subtract from an unsigned with an unsigned...

Now this is a no-no, since you're subtracting a signed value from an unsigned value:
4294967295 - -2147483648 = 6442450943

However, since we have unsigned values holding the meso value, we will use unsigned values for our algebraic equations, because doing otherwise wouldn't make any sense:
4294967295 - 4294967295 = 0

---

Ok Zygon... I wrote it wrong, I meant result of subtract not the actual number.

Ok.. so... let's be a bit more "realistic".

You got 500 mesos.

unsigned int mesos = 500;

ok?

And now, for some reason you wants to subtract it with 1000.

mesos - 1000

Get it now?

Java doesn't have unsigned integers dumbass. Java doesn't support.

Quote:

---

Originally Posted by XxОsirisxX

Ok Zygon... I wrote it wrong, I meant result of subtract not the actual number.

Ok.. so... let's be a bit more "realistic".

You got 500 mesos.

unsigned int mesos = 500;

ok?

And now, for some reason you wants to subtract it with 1000.

mesos - 1000

Get it now?

---

Code:

---

uint mesos = 500;
if (mesos >= 1000)
    mesos - 1000;
else
    return;

---

You don't do that unless they have the mesos in the first place, and an exception would be thrown because the value is outside of the data type's precision. In MS you can't have negative money... Well you can, but it isn't on purpose, and this is because the variable is signed. You can owe money in the real world, but currency never has a negative value.

Quote:

---

Originally Posted by jon5477

Java doesn't have unsigned integers dumbass. Java doesn't support.

---

What he was providing was an example in a language that would, but yes everyone knows unsigned values aren't supported in Java, but there is a way on how you would acquire them for use in Java.

Quote:

---

Originally Posted by Zygon

Code:

---

uint mesos = 500;
if (mesos >= 1000)
    mesos - 1000;
else
    return;

---

You don't do that unless they have the mesos in the first place, and an exception would be thrown because the value is outside of the data type's precision. In MS you can't have negative money... Well you can, but it isn't on purpose, and this is because the variable is signed. You can owe money in the real world, but currency never has a negative value.


What he was providing was an example in a language that would, but yes everyone knows unsigned values aren't supported in Java, but there is a way on how you would acquire them for use in Java.

---

Nope, it doesn't throw any kind of exception if you subtract an unsigned value and the result is below to 0, it will just be "reset".

But yeah, pretty much, you need a check before subtract, even tho, if negative is there, it will also be positive and flaw.

They're talking about languages that do support, not just java dumbass

ur server sucks if u needed this..