PW Chat

Printable View

05-03-11
das7002

PW Chat

After many headaches (for obvious things which caused lots of /facepalms) I have finally come to a version of PW Chat that I like.

Screenshot of main interface: http://dl.dropbox.com/u/1178264/scre.../PW%20Chat.png

The project is entirely open source and there is still a bit I'd like to add to it but for now it does work. I would like ANY comments or suggestions on anything you'd like to see me change or improve upon. You also have the freedom to change something inside of the project if you want to as it is open source. Please, please, please read the included README.txt file and the bazillion comments I put in the PHP server file (they are there for a reason)

If you somehow can't understand how to make it work I'll help to the best of my ability.

Anyway: Download of precompiled Downloads - pw-chat - Project Hosting on Google Code

Source: Source Checkout - pw-chat - Project Hosting on Google Code

Changes as of Mar 17, 2011

Alrighty, added a bunch of new features and fixed some bugs since last release (on RaGEZONE anyway)

New things added and bugs fixed
Get Role Name (gets the name of the character by ID)
Auto version checker (runs weekly)
Fixed bug with non-ASCII characters not being sent for broadcast properly
Fixed bug that caused a .NET exception to be thrown if no response from server is given or bad data is received

Things coming soon!
Mute user
Ban user
Finding cause of mysterious script death upon message sending (used to add message sent to MySQL but not anymore...)
Possibly add ability for user to pick their own sound notification

Things coming eventually!
Changing all requests made to server to async so the client doesn't seem to 'freeze' whenever it makes a request

As always download link is Downloads - pw-chat - Perfect World Chat - Google Project Hosting
05-03-11
Romulan

Re: PW Chat

What is that? :laugh:

Code:

Consultez la fin de ce message pour plus de détails sur l'appel du débogage juste-à-temps (JIT) à la place de cette boîte de dialogue. ************** Texte de l'exception ************** CodeTitans.JSon.JSonReaderException: Invalid token found ('<' at 1:1) à CodeTitans.JSon.JSonReader.ReadNextToken(Boolean fromCurrentChar) à CodeTitans.JSon.JSonReader.Read() à CodeTitans.JSon.JSonReader.ReadAsJSonObject(String input) à PW_Chat.dataHandler.readJson(String data) à PW_Chat.dataHandler.login() à PW_Chat.NewConnection.Login(String user, String pass, String serv) à PW_Chat.NewConnection.loginbtn_Click(Object sender, EventArgs e) à System.Windows.Forms.Control.OnClick(EventArgs e) à System.Windows.Forms.Button.OnClick(EventArgs e) à System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent) à System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) à System.Windows.Forms.Control.WndProc(Message& m) à System.Windows.Forms.ButtonBase.WndProc(Message& m) à System.Windows.Forms.Button.WndProc(Message& m) à System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m) à System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) à System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam) ************** Assemblys chargés ************** mscorlib Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 (RTMRel.030319-0100) CodeBase : file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll ---------------------------------------- PW Chat Version de l'assembly : 1.0.0.0 Version Win32 : 1.0.0.0 CodeBase : file:///C:/Program%20Files/PW%20Chat/PW%20Chat.exe ---------------------------------------- System.Windows.Forms Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll ---------------------------------------- System.Drawing Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll ---------------------------------------- System Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll ---------------------------------------- System.Configuration Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 (RTMRel.030319-0100) CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll ---------------------------------------- System.Xml Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll ---------------------------------------- System.Speech Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Speech/v4.0_4.0.0.0__31bf3856ad364e35/System.Speech.dll ---------------------------------------- System.Windows.Forms.resources Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms.resources/v4.0_4.0.0.0_fr_b77a5c561934e089/System.Windows.Forms.resources.dll ---------------------------------------- CodeTitans.JSon Version de l'assembly : 1.4.0.0 Version Win32 : 1.4.0.0 CodeBase : file:///C:/Program%20Files/PW%20Chat/CodeTitans.JSon.DLL ---------------------------------------- mscorlib.resources Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 (RTMRel.030319-0100) CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/mscorlib.resources/v4.0_4.0.0.0_fr_b77a5c561934e089/mscorlib.resources.dll ---------------------------------------- ************** Débogage JIT ************** Pour activer le débogage juste-à-temps (JIT), le fichier de configuration pour cette application ou cet ordinateur (machine.config) doit avoir la valeur jitDebugging définie dans la section system.windows.forms. L'application doit également être compilée avec le débogage activé. Par exemple : <configuration> <system.windows.forms jitDebugging="true" /> </configuration> Lorsque le débogage juste-à-temps est activé, les exceptions non gérées seront envoyées au débogueur JIT inscrit sur l'ordinateur plutôt que d'être gérées par cette boîte de dialogue.
05-03-11
das7002

Re: PW Chat

Quote:

Originally Posted by Romulan

What is that? :laugh:

Code:

Consultez la fin de ce message pour plus de détails sur l'appel du débogage juste-à-temps (JIT) à la place de cette boîte de dialogue. ************** Texte de l'exception ************** CodeTitans.JSon.JSonReaderException: Invalid token found ('<' at 1:1) à CodeTitans.JSon.JSonReader.ReadNextToken(Boolean fromCurrentChar) à CodeTitans.JSon.JSonReader.Read() à CodeTitans.JSon.JSonReader.ReadAsJSonObject(String input) à PW_Chat.dataHandler.readJson(String data) à PW_Chat.dataHandler.login() à PW_Chat.NewConnection.Login(String user, String pass, String serv) à PW_Chat.NewConnection.loginbtn_Click(Object sender, EventArgs e) à System.Windows.Forms.Control.OnClick(EventArgs e) à System.Windows.Forms.Button.OnClick(EventArgs e) à System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent) à System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) à System.Windows.Forms.Control.WndProc(Message& m) à System.Windows.Forms.ButtonBase.WndProc(Message& m) à System.Windows.Forms.Button.WndProc(Message& m) à System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m) à System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) à System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam) ************** Assemblys chargés ************** mscorlib Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 (RTMRel.030319-0100) CodeBase : file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll ---------------------------------------- PW Chat Version de l'assembly : 1.0.0.0 Version Win32 : 1.0.0.0 CodeBase : file:///C:/Program%20Files/PW%20Chat/PW%20Chat.exe ---------------------------------------- System.Windows.Forms Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll ---------------------------------------- System.Drawing Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll ---------------------------------------- System Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll ---------------------------------------- System.Configuration Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 (RTMRel.030319-0100) CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll ---------------------------------------- System.Xml Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll ---------------------------------------- System.Speech Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Speech/v4.0_4.0.0.0__31bf3856ad364e35/System.Speech.dll ---------------------------------------- System.Windows.Forms.resources Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 built by: RTMRel CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms.resources/v4.0_4.0.0.0_fr_b77a5c561934e089/System.Windows.Forms.resources.dll ---------------------------------------- CodeTitans.JSon Version de l'assembly : 1.4.0.0 Version Win32 : 1.4.0.0 CodeBase : file:///C:/Program%20Files/PW%20Chat/CodeTitans.JSon.DLL ---------------------------------------- mscorlib.resources Version de l'assembly : 4.0.0.0 Version Win32 : 4.0.30319.1 (RTMRel.030319-0100) CodeBase : file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/mscorlib.resources/v4.0_4.0.0.0_fr_b77a5c561934e089/mscorlib.resources.dll ---------------------------------------- ************** Débogage JIT ************** Pour activer le débogage juste-à-temps (JIT), le fichier de configuration pour cette application ou cet ordinateur (machine.config) doit avoir la valeur jitDebugging définie dans la section system.windows.forms. L'application doit également être compilée avec le débogage activé. Par exemple : <configuration> <system.windows.forms jitDebugging="true" /> </configuration> Lorsque le débogage juste-à-temps est activé, les exceptions non gérées seront envoyées au débogueur JIT inscrit sur l'ordinateur plutôt que d'être gérées par cette boîte de dialogue.

PHP side must've sent something invalid back, try running the PHP from a browser and show me what comes up (like a Syntax error or something if it does)

If not run my debug mode one (builds as a console app instead so I can see what PHP is actually sending to the client) so I can see where it went wrong

http://dl.dropbox.com/u/1178264/pw-c...lease/Debug.7z as that does seem weird

And remember, server must, must, must be sending text/plain there can not be any HTML output as I read for JSON only in the client. I'll work in a json validator so that doesn't get thrown

Edit: New download on Google code page added with the fix
05-03-11
Romulan

Re: PW Chat

Quote:

Originally Posted by das7002

And remember, server must, must, must be sending text/plain there can not be any HTML output as I read for JSON only in the client.

And how to do that with the server? :mellow:

Screenshot from Debug:
http://dl.dropbox.com/u/11797022/2011-03-05_211457.png

I still don't get how to make the login work :blink:
05-03-11
das7002

Re: PW Chat

Quote:

Originally Posted by Romulan

And how to do that with the server? :mellow:

Screenshot from Debug:
http://dl.dropbox.com/u/11797022/2011-03-05_211457.png

I still don't get how to make the login work :blink:

You have to give it the path of where the php file is, sorry if I forgot to mention that

Like for example 192.168.1.100/pwchat-server/csharp.php

http:// doesn't have to be included in server string as it adds it automatically if not given

And also ?initdb=AUTHKEYINPHPFILE to get the database part working (if you didnt figure that out)
05-03-11
Romulan

Re: PW Chat

When i go on:

Code:

http://192.168.1.100/csharp.php

Returned error:

Code:

Parse error: syntax error, unexpected ':' in /var/www/csharp.php on line 263

And still Login failed :*:
05-03-11
Broc923

Re: PW Chat

I'm honestly not for sure what this is.
Anyways...Nice work!
05-03-11
das7002

Re: PW Chat

Quote:

Originally Posted by Romulan

When i go on:

Code:

http://192.168.1.100/csharp.php

Returned error:

Code:

Parse error: syntax error, unexpected ':' in /var/www/csharp.php on line 263

And still Login failed :*:

That means you have an old version of PHP and need to update (major bugfix in 5.3.3 PHP :: Bug #53632 :: PHP hangs on numeric value 2.2250738585072011e-308)

http://dl.dropbox.com/u/1178264/scre...epad%2B%2B.png is how you would fix it (see the comment on the line)

After that it should work perfectly fine for you

Quote:

Originally Posted by Broc923

I'm honestly not for sure what this is.
Anyways...Nice work!

I kind of see it as useful to people running servers and want the GM's to be able to see whats going on in chat without forcing them to be online AND don't want to give them access to pwAdmin (since pwAdmin has a live chat plugin which is similar)
This also will eventually allow more permissions then the basic 'broadcast' (enable or disable broadcasting with that user) one I have now
05-03-11
Romulan

Re: PW Chat

Code:

************** Texte de l'exception ************** System.NullReferenceException: La référence d'objet n'est pas définie à une instance d'un objet. à PW_Chat.dataHandler.readJson(String data) à PW_Chat.dataHandler.login() à PW_Chat.NewConnection.Login(String user, String pass, String serv) à PW_Chat.NewConnection.loginbtn_Click(Object sender, EventArgs e) à System.Windows.Forms.Control.OnClick(EventArgs e) à System.Windows.Forms.Button.OnClick(EventArgs e) à System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent) à System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) à System.Windows.Forms.Control.WndProc(Message& m) à System.Windows.Forms.ButtonBase.WndProc(Message& m) à System.Windows.Forms.Button.WndProc(Message& m) à System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m) à System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) à System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

I think I'll give up... :/:
05-03-11
das7002

Re: PW Chat

Quote:

Originally Posted by Romulan

Code:

************** Texte de l'exception ************** System.NullReferenceException: La référence d'objet n'est pas définie à une instance d'un objet. à PW_Chat.dataHandler.readJson(String data) à PW_Chat.dataHandler.login() à PW_Chat.NewConnection.Login(String user, String pass, String serv) à PW_Chat.NewConnection.loginbtn_Click(Object sender, EventArgs e) à System.Windows.Forms.Control.OnClick(EventArgs e) à System.Windows.Forms.Button.OnClick(EventArgs e) à System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent) à System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) à System.Windows.Forms.Control.WndProc(Message& m) à System.Windows.Forms.ButtonBase.WndProc(Message& m) à System.Windows.Forms.Button.WndProc(Message& m) à System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m) à System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) à System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

I think I'll give up... :/:

It is rather odd how it doesn't quite like you. I'll work on a detailed install guide then...
05-03-11
Romulan

Re: PW Chat

Oki :/:
05-03-11
das7002

Re: PW Chat

Quote:

Originally Posted by Romulan

Oki :/:

https://code.google.com/p/pw-chat/wiki/Manual

Follow that and ask me again if you have any other issues, I really do want this to work nice and smoothly
06-03-11
Zorno

Re: PW Chat

For me it works fine. No errors for now das :wink:
06-03-11
hrace009

Re: PW Chat

it was work fine to with me, after i update my Winsucks :lol:
18-03-11
das7002

Update!

Changes

Alrighty, added a bunch of new features and fixed some bugs since last release (on RaGEZone anyway)

New things added and bugs fixed
Get Role Name (gets the name of the character by ID)
Auto version checker (runs weekly)
Fixed bug with non-ASCII characters not being sent for broadcast properly
Fixed bug that caused a .NET exception to be thrown if no response from server is given or bad data is received

Things coming soon!
Mute user
Ban user
Finding cause of mysterious script death upon message sending (used to add message sent to MySQL but not anymore...)
Possibly add ability for user to pick their own sound notification

Things coming eventually!
Changing all requests made to server to async so the client doesn't seem to 'freeze' whenever it makes a request

As always download link is Downloads - pw-chat - Perfect World Chat - Google Project Hosting
18-03-11
ddnut

Re: PW Chat

Not sure why but I had to reset the key in the GUI to the one you sent.Not a huge deal.
I also had to make the database by hand with this.

Code:

CREATE TABLE `messages` ( `id` int(11) NOT NULL AUTO_INCREMENT, `uid` int(11) NOT NULL DEFAULT '-1', `type` text NOT NULL, `chldst` int(11) NOT NULL DEFAULT '0', `time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, `message` text NOT NULL, PRIMARY KEY (`id`), FULLTEXT KEY `message` (`message`) ) ENGINE=MyISAM DEFAULT CHARSET=latin1 AUTO_INCREMENT=1

did see .net error a few times(I had settings wrong in a php :lol: ).
stays in limbo or "freeze" 99.9% of the time with little to no network actions.
All in all nice work its coming along vary nice :thumbup1:
18-03-11
das7002

Re: PW Chat

Quote:

Originally Posted by ddnut

Not sure why but I had to reset the key in the GUI to the one you sent.Not a huge deal.
I also had to make the database by hand with this.

Code:

CREATE TABLE `messages` ( `id` int(11) NOT NULL AUTO_INCREMENT, `uid` int(11) NOT NULL DEFAULT '-1', `type` text NOT NULL, `chldst` int(11) NOT NULL DEFAULT '0', `time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, `message` text NOT NULL, PRIMARY KEY (`id`), FULLTEXT KEY `message` (`message`) ) ENGINE=MyISAM DEFAULT CHARSET=latin1 AUTO_INCREMENT=1

did see .net error a few times(I had settings wrong in a php :lol: ).
stays in limbo or "freeze" 99.9% of the time with little to no network actions.
All in all nice work its coming along vary nice :thumbup1:

In the manual I did say you have to run ?initdb=YOURAUTHKEY

The .NET errors that come up are probably Cryptography exceptions, I'll pick a spot to put in a try catch for those just not 100% sure where I want to put them... (and under normal proper use they never show up so I haven't really put to much effort into doing this...)

And you had to reset the key because Visual Studio changes the identifier the Release build uses every now and again (which makes settings save somewhere else) I'll eventually figure out how to make them stay in one spot or just write my own settings save but I love the built in Visual Studio settings class...

Quote:

stays in limbo or "freeze" 99.9% of the time with little to no network actions.

What do you mean by that? I don't really have any issues with it "stopping" it might freeze on getting chat messages initially or if your server is really slow to respond...

One of my Linux VM's decided it wanted to just not work at all on me when the client tried sending login data and that might be what you are talking about? I have no idea what is causing that and am still truly hoping its just a fluke limited to me... (to test if it is run ?login and see if the script just hangs there... if it is working right it quickly throws a bunch of errors (which is normal))
19-03-11
ddnut

Re: PW Chat

Quote:

Originally Posted by das7002

In the manual I did say you have to run ?initdb=YOURAUTHKEY

The .NET errors that come up are probably Cryptography exceptions, I'll pick a spot to put in a try catch for those just not 100% sure where I want to put them... (and under normal proper use they never show up so I haven't really put to much effort into doing this...)

And you had to reset the key because Visual Studio changes the identifier the Release build uses every now and again (which makes settings save somewhere else) I'll eventually figure out how to make them stay in one spot or just write my own settings save but I love the built in Visual Studio settings class...

What do you mean by that? I don't really have any issues with it "stopping" it might freeze on getting chat messages initially or if your server is really slow to respond...

One of my Linux VM's decided it wanted to just not work at all on me when the client tried sending login data and that might be what you are talking about? I have no idea what is causing that and am still truly hoping its just a fluke limited to me... (to test if it is run ?login and see if the script just hangs there... if it is working right it quickly throws a bunch of errors (which is normal))

I missed that first part my bad. and as for the program freeze I will show you in a short video http://dl.dropbox.com/u/23268971/chat.7z
Don`t think it would be the servers they all in a blade and I use FX not TX connections so latency is not an issue. Not sure if it would cause an issue is my servers are a cut up as services(ie. MYSQL on one blade, PW on another and so on)
19-03-11
das7002

Re: PW Chat

Quote:

Originally Posted by ddnut

I missed that first part my bad. and as for the program freeze I will show you in a short video http://dl.dropbox.com/u/23268971/chat.7z
Don`t think it would be the servers they all in a blade and I use FX not TX connections so latency is not an issue. Not sure if it would cause an issue is my servers are a cut up as services(ie. MYSQL on one blade, PW on another and so on)

Well it seems like it is taking that long all the time because it needs to parse the entire log file every, single, time, which it shouldn't be, check to make sure something gets written to the table and that len.len is writable by whatever the HTTP server is (len.len just is a placeholder for what line the logfile is at)

And those freezes every few seconds after that is because it asks the server if there are any more chats every 5 seconds, again caused by what is said above, when I switch everything to async the 'freezes' will go away (caused by waiting on server) but it will still take that long to respond if the server isn't able to mark location of log file
20-03-11
ddnut

Re: PW Chat

Ya alls good in the SQL have like 10 entries and files are able to be used(set as same user and chmod 777) So I would say its working fine at the point in the project that you are at.
20-03-11
das7002

Re: PW Chat

Quote:

Originally Posted by ddnut

Ya alls good in the SQL have like 10 entries and files are able to be used(set as same user and chmod 777) So I would say its working fine at the point in the project that you are at.

It shouldn't take that long to respond though so it does seem as if you possibly have the same issue my one VM did then...