[php] login system [v1][coded]

Hey guys!

I have coded a login system, 100% working, and ready to go!

Readme File:
~~~~~~~~~~~~~~
~~~~Credits to ***** Scripts!~~~~
-----------------------
Setup:
~~~~
1) Run this SQL in your database:

CREATE TABLE `members` (
`id` int(4) NOT NULL auto_increment,
`username` varchar(65) NOT NULL default '',
`password` varchar(65) NOT NULL default '',
PRIMARY KEY (`id`)
) TYPE=MyISAM AUTO_INCREMENT=2 ;

--
-- Dumping data for table `members`
--

INSERT INTO `members` VALUES (1, 'Test', 'Test');

2) Edit 'checklogin' to your PHPMYADMIN details!

3) Create a user VIA database

Coming soon:
Register
Hashed Passwords

Needs fixing:
~NOTHING~

If you would like to keep ***** opened forever, please donate VIA paypal!
Paypal Email/Account: crimpson_striker@live.com
~~~~~~~~~~~~~~

***** is free-to-use, so we suggest that you don't remove the copyrights, nor re-release our work in any shape or form!

To download the LOGIN SYSTEM V1, please click on the link below:

Download: http://*****.net/downloads/LOGIN1.rar
Demo: http://*****.net/downloads/LOGIN1/

:thumbup:ENJOY:thumbup:

dont use deprecated functions.

future advise although this is version 1 practice ALLOT more.

I wouldn't recommend using this script, using deprecated functions and not hashing passwords etc is a very bad practise.

Oh and to make a hash is incredibly simple, just make a salt as well so that u don't end up making it too easy for an eventual hacker to crack the passwords.

Things wrong;

-You don't indent.
-You don't organize your scripts!
-It looks very messy.
-You don't hash your passwords.
-You don't have a proper anti-injection script.
-In my opinion, you use too many files for things that can be in one.

This could have been better, but yet, good try. ;)

From the comments I didn't bother downloading to see it myself but I did. It's not that bad but you shouldn't have created like 5 separate PHPS.

Quote:

---

Originally Posted by Apixenz

-You don't organize your scripts!
-In my opinion, you use too many files for things that can be in one.)

---

FYI, these two contradict themselves.

The scripts are organized using 5 different files. It's not indented, it's not well commented, and it's using old-school techniques (such as the mysql extension instead of the improved mysql extension, mysqli).

Also... security is pretty poor.. No password protection and the post data is escaped but thrown in the query with no surrounding quotes...

There's no single "connect" or "header" file, which could handle sessions, db info, and other such common things, and be included on all pages.

There are much better login system tutorials or showcases on this forum.