Swap bug Quick fix

Hi I fixed the swap bug a long time ago it got tested on my server and it worked :thumbup1:
I posted this because someone kinda posted a youtube thingy about it :O.

Find this in DPSrv.cpp @ worldserver

Code:

---

void CDPSrvr::OnDoEquip( CAr & ar, DPID dpidCache, DPID dpidUser, LPBYTE lpBuf, u_long uBufSize )
{
        DWORD nId;
        int nPart;

        ar >> nId;
        ar >> nPart;               
       
        if( nPart >= MAX_HUMAN_PARTS )       
                return;

        CUser* pUser = g_UserMng.GetUser( dpidCache, dpidUser );

---

And put this under it

Code:

---

#ifdef __QUGET_SWAP_FIX

                                if( pUser->GetHitPoint() >  pUser->GetMaxHitPoint() )
                                        pUser->SetHitPoint( pUser->GetMaxHitPoint());

                                if( pUser->GetManaPoint() >  pUser->GetMaxManaPoint() )
                                        pUser->SetManaPoint( pUser->GetMaxManaPoint() );

                                if( pUser->GetFatiguePoint() >  pUser->GetMaxFatiguePoint() )
                                        pUser->SetFatiguePoint( pUser->GetMaxFatiguePoint() );

#endif

---

find this in function void CDPClient::OnDoEquip( OBJID objid, CAr & ar ) @ DPClient.cpp
and add under

Code:

---

if( g_WndMng.m_pWndBeautyShop && g_WndMng.m_pWndBeautyShop->m_pModel )
                        {
                                CMover::UpdateParts( pPlayer->GetSex(), pPlayer->m_dwSkinSet, pPlayer->m_dwFace, pPlayer->m_dwHairMesh, pPlayer->m_dwHeadMesh, pPlayer->m_aEquipInfo, g_WndMng.m_pWndBeautyShop->m_pModel, &pPlayer->m_Inventory );
                        }

---

this

Code:

---

#ifdef __QUGET_SWAP_FIX
                                if( pPlayer->GetHitPoint() >  pPlayer->GetMaxHitPoint() )
                                        pPlayer->SetHitPoint( pPlayer->GetMaxHitPoint());

                                if( pPlayer->GetManaPoint() >  pPlayer->GetMaxManaPoint() )
                                        pPlayer->SetManaPoint( pPlayer->GetMaxManaPoint() );

                                if( pPlayer->GetFatiguePoint() >  pPlayer->GetMaxFatiguePoint() )
                                        pPlayer->SetFatiguePoint( pPlayer->GetMaxFatiguePoint() );

#endif

---

and then define __QUGET_SWAP_FIX in versioncommon.h @neuz and worldserver

Funny how we got further in the flyff development then eFlyFF.

Good release. :)

Good job MisterKid, Swap fuck the PvP alot.

Quote:

---

Originally Posted by blur

Good job MisterKid, Swap fuck the PvP alot.

---

I know :) i tought of fixing it since BP alway's do this swap shit :(

already knew that personally, but it will still be a pleasant sight to see the swap bug eliminated from more servers

how does work this swap works? it block any item usage or block any skill when ur using any skill. or just fix the bug?

it works by resetting your HP, MP, and FP every time you equip something

thanks for the release

are you kidding me or im failing? this source edit didnt fix anything xD...

swamp's still perfectly working

did you put #define __QUGET_SWAP_FIX in versioncommon.h of world server folder?

ofcourse. i did all he said in the guide XD

ofcourse. i did all he said in the guide XD

did you compile/build it and use the new worldserver program? cause that's the only thing that hasn't been said xD

Idk at my server they said it got fixed.
I don't bug abuse lol so yea...
Let me explain...

if( pUser->GetHitPoint() > pUser->GetMaxHitPoint() )//If users HitPoint is higher then users max hitpoints..
pUser->SetHitPoint( pUser->GetMaxHitPoint());//Set users hitpoints to his max hitpoints

This dont "Fix" swap at all.

Why don't you make just a check in the dmg formula for Psycho Bomb & Asal?

something like that:

PHP Code:

---

int AsalFormula ()
{
    int nMana = pUser->GetManaPoint();

    if( nMana > pUser->GetMaxManaPoint() )
         nMana = pUser->GetMaxManaPoint();

    return nStr*nMana*TheRest;
} 


---

Quote:

---

Originally Posted by sagenessamerda

Why don't you make just a check in the dmg formula for Psycho Bomb & Asal?

something like that:

PHP Code:

---

int AsalFormula ()
{
    int nMana = pUser->GetManaPoint();

    if( nMana > pUser->GetMaxManaPoint() )
         nMana = pUser->GetMaxManaPoint();

    return nStr*nMana*TheRest;
} 


---

---

Nha i would rather check when you swap the shit (OnDoEquip)
So other skills wont be effected with the bug.

This should have fixed the swap bug since it didnt work on my server atleast gms/mod/players confirmed it didnt work anymore.
When my server was still running... :ott1:

nvm forgot a piece of code in the client let me update

/updated main post sorry

lol i sorta thought server side would be too simple..
either way, I did as the previous have said and fixed it in the formula

:p I forgot the neuz edit :) check the main post it should work now
Posted via Mobile Device

Quote:

---

Originally Posted by MisterKid

So other skills wont be effected with the bug.

---

oh yeah, this is actually inaccurate. Spirit Bomb and Asal both have completely separate damage functions, so modifying them to prevent swapping, has no effect on any other skills.

But what if you make more skills like that? then you have too repeat this all over again.
Also this fixes the huge hpbar/mpbar bug.
If I'm right when you are going to swap your mpbar will be bigger then your max mp :s
I rather fix problems where it starts.
OnDoEquip--->Asal
--->mpBomb
Posted via Mobile Device

-.- you're drawing away from my previous point. I wasn't trying to convince people to do it that way, merely stating that it wouldn't effect all skills, cause their formulas are separate

Quote:

---

Originally Posted by ShadowDragon42

-.- you're drawing away from my previous point. I wasn't trying to convince people to do it that way, merely stating that it wouldn't effect all skills, cause their formulas are separate

---

Owh sorry might have readed your post wrong:*:.
I'm so tired >.<

Quote:

---

Originally Posted by ShadowDragon42

oh yeah, this is actually inaccurate. Spirit Bomb and Asal both have completely separate damage functions, so modifying them to prevent swapping, has no effect on any other skills.

---

Exactly, psy swap-bug still works, you just have to wait a bit longer that tom's antihack don't detect swapping gear.

So, fix it into the Spirit bomb formula.

It can't be that hard, lol.

Quote:

---

Originally Posted by MisterKid

Idk at my server they said it got fixed.
I don't bug abuse lol so yea...
Let me explain...

if( pUser->GetHitPoint() > pUser->GetMaxHitPoint() )//If users HitPoint is higher then users max hitpoints..
pUser->SetHitPoint( pUser->GetMaxHitPoint());//Set users hitpoints to his max hitpoints

---

Well Explain me why you made it if(.....) then something.... it shouldn't be if because it won't be updated on equip change if I am right but when the player will send packet to get current hp.... If I'm not right correct me but you should force server to get hp on eq change ^_^.

Quote:

---

Originally Posted by smejalni

Exactly, psy swap-bug still works, you just have to wait a bit longer that tom's antihack don't detect swapping gear.

---

are you even paying attention to what people are saying in this thread? nobody has even mentioned anything about tom's antihack blocking anything

Quote:

---

Originally Posted by Jomex

Well Explain me why you made it if(.....) then something.... it shouldn't be if because it won't be updated on equip change if I am right but when the player will send packet to get current hp.... If I'm not right correct me but you should force server to get hp on eq change ^_^.

---

pay attantion to the bug... OnDoEquip is when you equip something. swapbug involves equiping....
and mp/hp updates after a while but while waiting for that you be able too have high mp.
Posted via Mobile Device

Quote:

---

Originally Posted by MisterKid

pay attantion to the bug... OnDoEquip is when you equip something. swapbug involves equiping....
and mp/hp updates after a while but while waiting for that you be able too have high mp.
Posted via Mobile Device

---

What he's saying is: Why are you checking anything? Why not just force the stats to update whenever something is equipped?

I dont know this Swap bug is, can you please tell me what bug gives this in-game.

Quote:

---

Originally Posted by Jay B

I dont know this Swap bug is, can you please tell me what bug gives this in-game.

---

if you change mp set to hp set you will have both mp and hp. the same with STR/ATCK etc etc o;

people like that bug i dont see why fix it. the only thing that suck is there are a tool to do it.

Quote:

---

Originally Posted by ShadowDragon42

What he's saying is: Why are you checking anything? Why not just force the stats to update whenever something is equipped?

---

ahh Should find where that happends

Quote:

---

Originally Posted by carlos123

if you change mp set to hp set you will have both mp and hp. the same with STR/ATCK etc etc o;

people like that bug i dont see why fix it. the only thing that suck is there are a tool to do it.

---

ok, how long is that bug when you change set in game will take? (like 1 hour or permanent?)

Quote:

---

Originally Posted by MisterKid

ahh Should find where that happends

---

or add somewhere because method you used isn't a really good fix :P and sorry I forgot that if in C++ is always done :PP

Quote:

---

Originally Posted by Jomex

or add somewhere because method you used isn't a really good fix :P and sorry I forgot that if in C++ is always done :PP

---

I dont get what you mean with that.
Anyway it might be a function reseting.
But atm I'm too lazy working on some AS3 projects :)

Misterkid i tried your code and it didnt work, it just reset your mp hp etc etc but the bug still exist.

Quote:

---

Originally Posted by blur

Misterkid i tried your code and it didnt work, it just reset your mp hp etc etc but the bug still exist.

---

also add it on worldserver?
since hp/mp/fp are resseted o.e thats the bug right?

Quote:

---

Originally Posted by MisterKid

also add it on worldserver?
since hp/mp/fp are resseted o.e thats the bug right?

---

mp didnt get fixed ;p psy can do 11m demage.

yah in my server they switch bug
there asal about 29m and this code is not work

o.e then my testers were failing so hard.
Can you explain me the whole bug

Quote:

---

Originally Posted by MisterKid

o.e then my testers were failing so hard.
Can you explain me the whole bug

---

Example:


When you have hp weapons and you switch it to Atk weapons (using an specific AoE skill), you will have the hp + Atk in the same time. that's a gay bug that pinoys loves.

Quote:

---

Originally Posted by MisterKid

o.e then my testers were failing so hard.
Can you explain me the whole bug

---

Some players fast switch there item using macro program in first this swap bug is ok but now the players know about swap bug very fast

Quote:

---

Originally Posted by blur

Example:


When you have hp weapons and you switch it to Atk weapons (using an specific AoE skill), you will have the hp + Atk in the same time. that's a gay bug that pinoys loves.

---

Yah pinoy loves that bug

it only looks like it works, you dont see your HP/MP/FP bugging but it still does.


i asaled 1 time with 20k mp, i did 500k.
then i aoe'd and swapped from 20k MP to 1k mp and still did 500k asal.
then i just asaled with 1k mp again but this time without any aoe and did 30k asal.


It really does NOT work, it only shows normal HP/MP/FP while swapping but it still bugs when you hit/aoe/or do any dmg.



Does someone know a "true" fix?



Edit:

i saw you dont know why this bug is happening, let me explain it to you.

it happens because when you get any dmg or do dmg, then the "Battle-Phase" starts, while battle phase your HP/MP/FP will not recover, the battle phase lasts 10 secounds, when the 10 secounds are over and you didnt made any DMG or received any DMG then it is over and your HP/MP/FP recovers.
you must remove that Battle Phase, or make that HP/FP/MP always recover, even while fighting.

Quote:

---

Originally Posted by xefiroid

it only looks like it works, you dont see your HP/MP/FP bugging but it still does.


i asaled 1 time with 20k mp, i did 500k.
then i aoe'd and swapped from 20k MP to 1k mp and still did 500k asal.
then i just asaled with 1k mp again but this time without any aoe and did 30k asal.


It really does NOT work, it only shows normal HP/MP/FP while swapping but it still bugs when you hit/aoe/or do any dmg.



Does someone know a "true" fix?



Edit:

i saw you dont know why this bug is happening, let me explain it to you.

it happens because when you get any dmg or do dmg, then the "Battle-Phase" starts, while battle phase your HP/MP/FP will not recover, the battle phase lasts 10 secounds, when the 10 secounds are over and you didnt made any DMG or received any DMG then it is over and your HP/MP/FP recovers.
you must remove that Battle Phase, or make that HP/FP/MP always recover, even while fighting.

---

Nope.

Why?
Because if it really does not work then he only sent to user that HP/MP/FP changed but didn't change it in world server in the same time, that's all. That's only my opinion after reading all what is here because I didn't test personally.

:P In theory it should be fixed.
But you could add it before someone uses a skill.
I didnt know swap bug would go so fast that you can't see your gear change :/
This is @ worldserver

Quote:

---

oid CDPSrvr::OnDoEquip( CAr & ar, DPID dpidCache, DPID dpidUser, LPBYTE lpBuf, u_long uBufSize )
{
DWORD nId;
int nPart;

ar >> nId;
ar >> nPart;

if( nPart >= MAX_HUMAN_PARTS )
return;

CUser* pUser = g_UserMng.GetUser( dpidCache, dpidUser );
#ifdef __QUGET_SWAP_FIX

if( pUser->GetHitPoint() > pUser->GetMaxHitPoint() )
pUser->SetHitPoint( pUser->GetMaxHitPoint());

if( pUser->GetManaPoint() > pUser->GetMaxManaPoint() )
pUser->SetManaPoint( pUser->GetMaxManaPoint() );

if( pUser->GetFatiguePoint() > pUser->GetMaxFatiguePoint() )
pUser->SetFatiguePoint( pUser->GetMaxFatiguePoint() );

#endif

---

did u change anything huh? looks same as on first page O_o...

it is :p i tried to add it @ onUseSkill
Posted via Mobile Device

OMG! Why didn't I look at this more closely when you first posted it? More importantly, how did somebody not catch the problem before now?

The reason your coding doesn't work, is because in DPSrvr.cpp, you added the reset HP/MP/FP coding BEFORE their equips were actually changed. Move it to the bottom of the function, then it should work.

Edit: Someone please tell me if this fixes it. I'm not entirely sure it's fast enough (that function in DPSrvr chains into a lot of other functions before finishing). If it's not fast enough, I'll find a spot higher in the function chain that should work.

Quote:

---

Originally Posted by ShadowDragon42

OMG! Why didn't I look at this more closely when you first posted it? More importantly, how did somebody not catch the problem before now?

The reason your coding doesn't work, is because in DPSrvr.cpp, you added the reset HP/MP/FP coding BEFORE their equips were actually changed. Move it to the bottom of the function, then it should work.

Edit: Someone please tell me if this fixes it. I'm not entirely sure it's fast enough (that function in DPSrvr chains into a lot of other functions before finishing). If it's not fast enough, I'll find a spot higher in the function chain that should work.

---

o.o Why did i already had it at the bottom and didn't put it here :o. thats why it worked for me :?: maybe xD

Quote:

---

Originally Posted by MisterKid

o.o Why did i already had it at the bottom and didn't put it here :o. thats why it worked for me :?: maybe xD

---

I have no idea lol but I looked at that function, and the very last thing it does, is change the character's equips. Move your coding to the end, and it should work.

Quote:

---

Originally Posted by ShadowDragon42

Edit: Someone please tell me if this fixes it. I'm not entirely sure it's fast enough (that function in DPSrvr chains into a lot of other functions before finishing). If it's not fast enough, I'll find a spot higher in the function chain that should work.

---

No it dosent work! It only looks like it works, you dont see your HP/MP/FP bugging but it still does.


i asaled 1 time with 20k mp, i did 500k.
then i aoe'd and swapped from 20k MP to 1k mp and still did 500k asal.
then i just asaled with 1k mp again but this time without any aoe and did 30k asal.


It really does NOT work, it only shows normal HP/MP/FP while swapping but it still bugs when you hit/aoe/or do any dmg.

Quote:

---

Originally Posted by xefiroid

No it dosent work! It only looks like it works, you dont see your HP/MP/FP bugging but it still does.


i asaled 1 time with 20k mp, i did 500k.
then i aoe'd and swapped from 20k MP to 1k mp and still did 500k asal.
then i just asaled with 1k mp again but this time without any aoe and did 30k asal.


It really does NOT work, it only shows normal HP/MP/FP while swapping but it still bugs when you hit/aoe/or do any dmg.

---

>.> You don't have to constantly repeat it and yell at me. I didn't make this coding, merely tried to fix it, but without testing it. Just for that, I won't bother trying to help you with it.

Quote:

---

Originally Posted by xxrob143xx

Some players fast switch there item using macro program in first this swap bug is ok but now the players know about swap bug very fast

---

somebody should program a little timer on changing equip, so swapping wont be "in" anymore. similar to using blinkwings.


btw, does the other stats are set right instantly? the bug only exists for hp/mp/fp?

Quote:

---

Originally Posted by VibeTribe

somebody should program a little timer on changing equip, so swapping wont be "in" anymore. similar to using blinkwings.


btw, does the other stats are set right instantly? the bug only exists for hp/mp/fp?

---

yes the bug only exist for HP MP FP because they get stuck (dont recover) if the user is in Attack Mode, that means if he is fighting the HP MP FP wont recover so they will stay at the same point for 10 sec. if he keeps fighting it holds for another 10 sec. and so on.

i found a way to fix it much easier, i just removed code that the HP MP FP dont recover for 10 sec if the user is in attack mode. Now the HP MP FP does always recover, even when he is fighting and this makes it impossible to bug the HP MP FP.

Its easy to fix the item switching, just get Toms Antihack and change the detection.ini that he just allows 1 item switch per minute.
But it think thats just stupid because in pvp and especially in Guild Siege the players should swapp items like from HP to DMG but without holding their HP at a really high amount by abusing the Non-Recover in Attack mode.

Quote:

---

Originally Posted by xefiroid

i found a way to fix it much easier, i just removed code that the HP MP FP dont recover for 10 sec if the user is in attack mode. Now the HP MP FP does always recover, even when he is fighting and this makes it impossible to bug the HP MP FP.

---

That is an interesting idea, but it just gave me a better one. Instead of enabling recovery regardless of being in attack mode, when the ProcessRecovery function checks if you're able to recover, you should simply check if their HP, MP, and FP are at values that they shouldn't be.

thank you for your answers, its very interesting and helpful =)

This code was never tested by myself and was just a theory.
Swapping involves equipping things. And some people said it got fixed at my old server... Might be something else I did tough. Just can't remember.

I don't even know how this bug exactly works just that you sap your equips before using Asal :P

Quote:

---

Originally Posted by MisterKid

This code was never tested by myself and was just a theory.
Swapping involves equipping things. And some people said it got fixed at my old server... Might be something else I did tough. Just can't remember.

I don't even know how this bug exactly works just that you sap your equips before using Asal :P

---

some people some people? you cannot trust your community always. those people who can say its fixed must try it, prolly they use it, how can u be sure?
i prefer u go and check it yourself. xD

I can't I'm such a noob in Flyff..... It was tested by a friend of mine :)