Swap bug Quick fix

Hi I fixed the swap bug a long time ago it got tested on my server and it worked :thumbup1:
I posted this because someone kinda posted a youtube thingy about it :O.

Find this in DPSrv.cpp @ worldserver

Code:

---

void CDPSrvr::OnDoEquip( CAr & ar, DPID dpidCache, DPID dpidUser, LPBYTE lpBuf, u_long uBufSize )
{
        DWORD nId;
        int nPart;

        ar >> nId;
        ar >> nPart;               
       
        if( nPart >= MAX_HUMAN_PARTS )       
                return;

        CUser* pUser = g_UserMng.GetUser( dpidCache, dpidUser );

---

And put this under it

Code:

---

#ifdef __QUGET_SWAP_FIX

                                if( pUser->GetHitPoint() >  pUser->GetMaxHitPoint() )
                                        pUser->SetHitPoint( pUser->GetMaxHitPoint());

                                if( pUser->GetManaPoint() >  pUser->GetMaxManaPoint() )
                                        pUser->SetManaPoint( pUser->GetMaxManaPoint() );

                                if( pUser->GetFatiguePoint() >  pUser->GetMaxFatiguePoint() )
                                        pUser->SetFatiguePoint( pUser->GetMaxFatiguePoint() );

#endif

---

find this in function void CDPClient::OnDoEquip( OBJID objid, CAr & ar ) @ DPClient.cpp
and add under

Code:

---

if( g_WndMng.m_pWndBeautyShop && g_WndMng.m_pWndBeautyShop->m_pModel )
                        {
                                CMover::UpdateParts( pPlayer->GetSex(), pPlayer->m_dwSkinSet, pPlayer->m_dwFace, pPlayer->m_dwHairMesh, pPlayer->m_dwHeadMesh, pPlayer->m_aEquipInfo, g_WndMng.m_pWndBeautyShop->m_pModel, &pPlayer->m_Inventory );
                        }

---

this

Code:

---

#ifdef __QUGET_SWAP_FIX
                                if( pPlayer->GetHitPoint() >  pPlayer->GetMaxHitPoint() )
                                        pPlayer->SetHitPoint( pPlayer->GetMaxHitPoint());

                                if( pPlayer->GetManaPoint() >  pPlayer->GetMaxManaPoint() )
                                        pPlayer->SetManaPoint( pPlayer->GetMaxManaPoint() );

                                if( pPlayer->GetFatiguePoint() >  pPlayer->GetMaxFatiguePoint() )
                                        pPlayer->SetFatiguePoint( pPlayer->GetMaxFatiguePoint() );

#endif

---

and then define __QUGET_SWAP_FIX in versioncommon.h @neuz and worldserver

Funny how we got further in the flyff development then eFlyFF.

Good release. :)

Good job MisterKid, Swap fuck the PvP alot.

Quote:

---

Originally Posted by blur

Good job MisterKid, Swap fuck the PvP alot.

---

I know :) i tought of fixing it since BP alway's do this swap shit :(

already knew that personally, but it will still be a pleasant sight to see the swap bug eliminated from more servers

how does work this swap works? it block any item usage or block any skill when ur using any skill. or just fix the bug?

it works by resetting your HP, MP, and FP every time you equip something

thanks for the release

are you kidding me or im failing? this source edit didnt fix anything xD...

swamp's still perfectly working

did you put #define __QUGET_SWAP_FIX in versioncommon.h of world server folder?

ofcourse. i did all he said in the guide XD

ofcourse. i did all he said in the guide XD

did you compile/build it and use the new worldserver program? cause that's the only thing that hasn't been said xD

Idk at my server they said it got fixed.
I don't bug abuse lol so yea...
Let me explain...

if( pUser->GetHitPoint() > pUser->GetMaxHitPoint() )//If users HitPoint is higher then users max hitpoints..
pUser->SetHitPoint( pUser->GetMaxHitPoint());//Set users hitpoints to his max hitpoints

This dont "Fix" swap at all.