deleted
Printable View
deleted
I like it, it looks really nice! Keep it going!
The favicon though is a bit unrecognisable.
Thanks! And yeah I just shrunk the logo XD I was in a hurry.Quote:
Originally Posted by getty
You serious about that 1.5mb 2800x2076 png that's shrunk to 290x260px?
Also the whole site is 1365px wide, max about be 960 or 1140 if you feel 2012.
Apart from the obvious designing and usability errors, you were right about the code - it sucks big time, tons of error, deprecated tags, all in all, work of someone completely clueless who wasn't even bothered to read the very basic html tutorials.
You must really hate me:huh: not sure what I have done, lol. I get the code sucks I stated it, Thats not constructive critisim your just being a dick about it. I am still learning, everyone learns even you had to learn at one point.Quote:
Originally Posted by foxx
I don't hate you, my post couldn't be more constructive, everything I said was just true. As hard as it might sound.
foxx doesn't hate very many people; he is just quite blunt, albeit very experienced.
Let me help you a bit. I like the direction you are going in with the site. I like the general look. But the code is definitely very messy.
You need to learn how to correctly open and close HTML tags.
Let's take a look at this code in your site:
Ok, so, when you open a tag, you use <tag>. Now, you are using <a href="URL" /> The problem is the / at the end of that. You are attempting to (shorthand) close the tag, which isn't valid use of the <a> tag.Code:<a href="index.html" /><img src="styles/images/home.png"></a>
The <img> tag is opened but never closed. Once again, not good.
Read this for more info.
Shorthand closing an HTML tag is essentially doinginstead ofCode:<link rel="stylesheet" type="text/css" href="styles/style.css" />
Sometimes, it is valid. Most of the times, it is not. Some tags can be shorthand closed only when you are using a specific doctype. In my opinion, it's not a good habit to shorthand your tags unless you know that it is valid semantics with your chosen doctype.Code:<link rel="stylesheet" type="text/css" href="styles/style.css"></link>
FYI, you should add a doctype to your site.
</br> is invalid. You are attempting to close a <br> tag which was never opened. I think you were looking for <br />. The linebreak(<br>) tag is kind of funky when it comes to shorthand closing. Some doctypes, you shouldn't close the tag. Some types, you can do <br/>, and some you can do <br />.
Personally, I use <div style="clear: both;"> instead of the linebreak tag. It usually imitates a linebreak by making sure there is nothing to the left and right of the div. If you want to only clear the left or the right, you can do that via clear: left;
(You should put the CSS in a class instead of in the div directly, like I just did as an example)
<center> is deprecated(i.e. old). Use the CSS property text-align instead.
Javascript should go at the end of the <body> tag, i.e. right before </body>, unless it must be executed before the page loads. In this case, put it in the <head> tag.
You should never have any code after </html>.
Also, I would definitely take foxx's advice - shrink the width of the page, and don't load huge images on your site - especially if you are going to resize them. In that situation, your best bet is to probably just resize them in an image editor, and then just load that.
Do not use <BR /> , that is ugly and outdated. Instead of that make styles.css as stated above , and add like
which will make every paragraph have a space between them. Of course this require you to insert text into paragraph like <p>This is a sample text ...</p><p>this another sample text that goes bellow</p>Code:p { margin-bottom:1.5em; }
You don't use <center></center> either , besides that's not valid either. CSS version of that is
or if its an image or another <div> thanCode:#lolwut { text-align:center; }
than you do it likeCode:#lolwut { width:500px; /*make sure its smaller than the wrapper*/ margin:0 auto; }
Using <div style="clear:both"> is also ugly. Instead of that go to your css and addPHP Code:<div id="lolwut">Hello World!</div>
than use <div class="clear"></div> / also I do not recommend you to use this as a replacement for <br /> , just use paragraphs and as I showed you above. The clear:both; is for floats.Code:.clear { clear:both; }
For example you have a
the cssPHP Code:<body>
<div id="wrapper">
<div id="menu"></div>
<div id="content"></div>
<div id="sidebar"></div>
<div class="clear"></div>
</div>
<div id="footer"></div>
<body>
There is much more you can do but , figure it out yourself <.<Code:#wrapper { width: 960px; margin:0 auto; }
#menu { height:50px; /*width will be the same as wrapper*/ }
#content { width:600px; float:left; }
#sidebar { width:200px; float:right; }
.clear { clear:both; }
#footer { width:960px; margin:0 auto; }
/AgreedQuote:
Originally Posted by foxx
You don't even understand how the basics of css and html
http://gotoauto.net/styles/images/bg.png
800px × 600px
This one is super gay and the quality are super low:
http://img88.imageshack.us/img88/4093/detailing.png
2,800px × 2,076px (scaled to 290px × 250px)
http://gotoauto.net/styles/images/menu.png
1,365px × 65px
The whole page was a fail, it won't work if you have larger screen.
Just pay me I'll do all fix LAWL
1920x1080 here, it works perfectly fine - it just needs to be censored horizontally.Quote:
Originally Posted by NubPro
You know what you should do? delete the entire file, and then start rewriting the code. This time you're going to follow the tips in this thread.Quote:
Originally Posted by timebomb
About the "logo" / "image", cut it in photoshop or paint, or whatever, instead of scaling it down using css.
Also, in your code, you should use indention in your code, example:
is way better than this: (your current)Code:<html>
<head>
<title>Whatever</title>
</head>
<body>
<div id="bla"></div>
</body>
</html>
Code:<html>
<head>
<title>Whatever</title>
</head>
<body>
<div id="bla"></div>
</body>
</html>
To tell you the truth, this is what a lot of companies' websites would look like -- it might sell. Clueless business owners pay some 'web designer' to build them a website, nowhere near professional but still, they don't know any better. Foxx didn't design 'em so they're bad :P (just kidding, but he's actually pretty professional)
@EliteGM You are quite right.
You're talking to the wrong person, and for the record, while code indentation is nice, it is not going to affect the output of the code, wherein many of the other semantic/etc-related changes here will do just that.Quote:
Originally Posted by Erlend
Code indentation is great for debugging, though. You can easily see if you have misplaced a tag or simply put one too many.
Sent from my HTC Flyer P512 using Tapatalk
Look - I hadn't used a computer for about 2 years and frankly I am suprised I even got this out if it. Thanks for the feedback and I will for sure work on it!
timebomb: no shit?
Posted via Mobile Device
every thing not a rush take your time :D and every thing comes out perfect.:thumbup:Quote:
Originally Posted by Habbro
Just a bit too many images. Try using a little more pure CSS. Good work. 8/10.