[HELP] For loop

Working on a school assignment, and I've reached a bit of an impasse.

I'm inputting data from a text file, running a name and 6 different double numbers. Each name and all the numbers are outputted, while determining the person's final score (numbers are scores, obv). Also, it's supposed to determine the highest final score.
I'm using a for loop to get their name, which ends on a specific character. Then the 6 numbers are read in through a while loop until they're all read in.

My problem is that when determining the highest final score amongst all the names, the last final score read in is declared the highest final score. Anything is appreciated

while (var = number) {
if (var > topValueSoFar) {
topValueSoFar = var;
}
}

Could you provide some insight? Variable isn't equal to number (in your context), variable is the persons final score, while number is the last number read in from the file. The final score is the average of all scores combined and divided.

So do I understand correctly that you have x number of names, each followed by 6 scores? And you need to figure out not only the highest score per name, but also the highest among all? With this assumption:

Code:

---

highestOfAll = 0
loop all names
  highestForThisName = 0
  loop the 6 scores
    thisScore = however-you-obtain-the-current-score
    if thisScore > highestForThisName then highestForThisName = thisScore
  end loop
  if highestForThisName > highestOfAll then highestOfAll = highestForThisName
end loop

---

This is in the C++ section ffs....

Try to parse the text data into strings(names) and integers(for scores). When you've parsed everything, you can check the last integer read for the final score... My apologies if this doesn't make sense, I haven't had much sleep.

Quote:

---

Originally Posted by Mootie

This is in the C++ section ffs....

Try to parse the text data into strings(names) and integers(for scores). When you've parsed everything, you can check the last integer read for the final score... My apologies if this doesn't make sense, I haven't had much sleep.

---

Yeah it's in C++ because this is C++... but.. ok.

Anyways, I'm trying to use as few variables as possible (program requirement). The first final score is set as highest, and then simply compared continously. So yes Negata, your code is actually almost exactly identical to what mine is.
As I said, this process just sets the last names final score as the highest overall.

Quote:

---

Originally Posted by Mootie

This is in the C++ section ffs....

Try to parse the text data into strings(names) and integers(for scores). When you've parsed everything, you can check the last integer read for the final score... My apologies if this doesn't make sense, I haven't had much sleep.

---

The nerve to remind me of sections... oh well. I know it's the C++ section, but his problem isn't with C++ but the problem logic. I much rather provide pseudo code solutions in these cases and conveniently avoid focus on minor details.

Joocy I don't understand your assignment well enough to say whether you could drop another variable from it or not. I also don't understand if you still have a problem with it? If your code logic is identical to what I provided then either it will work perfectly or I have misunderstood the assignment.

It's identical in concept. The variable names and order vary a bit, but you've gotten the idea of what I'm trying to do. My code:

Code:

---

edited

---

Disregard poor formatting, WIP.
As I said, the problem is that the highest final score for all the names is set to the last read final score.

This block should not be there within score calculation:

Code:

---

          if (numOfScores == 1)
            highestFinalScore = dancersFinalScore;
          else if (highestFinalScore < dancersFinalScore)
            highestFinalScore = dancersFinalScore;

---

Also try to avoid checks like if (num == 1), instead initialize your highest score to 0 before the loop (if no score can be lower) to make your code simpler and less error prone by eliminating exceptional cases.

I got it. Thank you for the immediate help Negata! Saved my ass!

It's your assignment so please do not copy this, but just to show you how I'd write it for your education:

Code:

---

unsigned int highestFinalScore = 0;
for (all dancers)
{
  unsigned int lowestScore = -1; // Underflow to uint max
  for (int numOfScores = 0; numOfScores < 5; numOfScores++)
  {
    finScore >> score;
    dancersTotalScore = dancersTotalScore + score;

    if (lowestScore > score) lowestScore = score;

    outFile << setfill(' ') << setw(5) << score;
  }
     
  dancersFinalScore = (dancersTotalScore - lowestScore) / 4;
  outFile << " " << dancersFinalScore;

  if (dancersFinalScore > highestFinalScore) highestFinalScore = dancersFinalScore;

  outFile << endl;
  finScore.ignore(100, '\n');
}

---

Ahh forgot you mentioned they were doubles, not ints. Also the code is obviously lacking some parts that you didn't specify, but it's the thought that counts, not details.

Happy to help!

Quote:

---

Originally Posted by Negata

The nerve to remind me of sections... oh well. I know it's the C++ section, but his problem isn't with C++ but the problem logic. I much rather provide pseudo code solutions in these cases and conveniently avoid focus on minor details.

---

Nerve? You think I give a fuck about a rank? I reminded you, as I would remind anyone, that posting pseudo code on a language specific section defeats the purpose of the section.

Anyways, this seems like a very simple problem. I doubt the main issue is logic, but rather syntax. A beginner is more likely to understand words than pseudo code.

Quote:

---

Originally Posted by Mootie

Nerve? You think I give a fuck about a rank? I reminded you, as I would remind anyone, that posting pseudo code on a language specific section defeats the purpose of the section.

---

Pff, not about rank but the fact I've moderated every section on the board and having posted above 5000 posts should be a pretty good hint I know what I'm doing and where to post.

He had an assignment for C++ and his problem was with the logic, not the syntax, so pseudo code was more than appropriate. Even if the section is C++ handing out answers in the same language may not always be the best approach to reach teaching goals. Let's just agree to disagree with the best approach here - I just disliked the way you jumped at me for trying an alternative solution.

Quote:

---

Originally Posted by Negata

Pff, not about rank but the fact I've moderated every section on the board and having posted above 5000 posts should be a pretty good hint I know what I'm doing and where to post.

---

Again, I give a fuck why? You spent more time than me on these forums, in which over 90% of the threads have nothing to do with programming. RaGEZONE moderators and legends have shown me nothing but disrespect, although MentaL has been very helpful at times. I'm really sick of this whole "Legends are gods" attitude on RaGEZONE. Step off of your high horse and realize rank, moderating experience, and post count are relatively meaningless.

Quote:

---

Originally Posted by Negata

He had an assignment for C++ and his problem was with the logic, not the syntax, so pseudo code was more than appropriate. Even if the section is C++ handing out answers in the same language may not always be the best approach to reach teaching goals. Let's just agree to disagree with the best approach here - I just disliked the way you jumped at me for trying an alternative solution.

---

I still believe a beginner would have a harder time with the syntax than the logic of such a problem, but oh well.

Quote:

---

Originally Posted by Mootie

Again, I give a fuck why? You spent more time than me on these forums, in which over 90% of the threads have nothing to do with programming. RaGEZONE moderators and legends have shown me nothing but disrespect, although MentaL has been very helpful at times. I'm really sick of this whole "Legends are gods" attitude on RaGEZONE. Step off of your high horse and realize rank, moderating experience, and post count are relatively meaningless.

---

You didn't get my meaning. I don't mean to say shut up because I'm Legend but maybe it's something for you to consider before saying "wrong section/language!" I don't expect any special treatment or attitude from you or anyone else only because I've been here longer... The choice of language was intentional and my goal to give him the best help I can.

I've had no reason to give you disrespect but why do you think receive it so often, then? This is the first discussion I've had with you as far as I recall (my memory isn't that good, though) and you opened it with a line containing a curse.

Quote:

---

Originally Posted by Joocy

Could you provide some insight? Variable isn't equal to number (in your context), variable is the persons final score, while number is the last number read in from the file. The final score is the average of all scores combined and divided.

---

have some imagination, im not writing your code for you.