Re: MindCMS [PHP & MySQLi]
Its kinda to simple, but thanks anyway
Re: MindCMS [PHP & MySQLi]
Re: MindCMS [PHP & MySQLi]
Could be a nice little base for other projects to! cheers dude :)
Re: MindCMS [PHP & MySQLi]
I like it, Maybe i can code the me page further, and the news page and housekeeping
Re: MindCMS [PHP & MySQLi]
Nice Work, but id rather not use this. sorry
Re: MindCMS [PHP & MySQLi]
I will check it out, looks good so far
Re: MindCMS [PHP & MySQLi]
Edit: WORST THING I'VE SEEN: EVAL. You don't need it at all so why do you run such a dangerous command. Just do a str_replace on your file_get_contents to filter the variables with their values. You can even do a foreach on $GLOBALS if you need all variables that much, but please don't use eval for something which can be fixed in a lot easier ways.
--
Simple coding tips:
- Use an absolute path, so use a define('root') or something
- Use single quotes over double, it's quicker and more bug-free "$var" is something else than '$var', in double quotes variables will be replaced by their values, so single quotes are better
- Just use md5(value.hash) or md5(sha1(value)) because those are the most used hashes in CMSes. md5ing 3x is overkill and totally unneccesary.
- Don't keep unneeded values in memory with a variable
{
$find_sql = "SELECT null FROM users WHERE username = '{$username}' AND password = '{$password}'";
$run_login = $db->query($find_sql);
}
Use the string directly so it can be removed from memory after executing (not sure about PHPs GC though). You don't need $find_sql anymore in the code so you should just use the string directly.
That's actually pretty much is, since you didn't really give us a lot of coding except for ripped pages from Habbo. Start with OOP is all I can say and learn2tpl
BTW using $_SESSION["login_limit"] will just annoy users who try to type their passwords too fast, and hackers can easily avoid it by cleaning their $_COOKIE['PHP_SESSID']
Re: MindCMS [PHP & MySQLi]
Quote:
Originally Posted by
azaidi
Edit: WORST THING I'VE SEEN: EVAL. You don't need it at all so why do you run such a dangerous command. Just do a str_replace on your file_get_contents to filter the variables with their values. You can even do a foreach on $GLOBALS if you need all variables that much, but please don't use eval for something which can be fixed in a lot easier ways.
--
Simple coding tips:
- Use an absolute path, so use a define('root') or something
- Use single quotes over double, it's quicker and more bug-free "$var" is something else than '$var', in double quotes variables will be replaced by their values, so single quotes are better
- Just use md5(value.hash) or md5(sha1(value)) because those are the most used hashes in CMSes. md5ing 3x is overkill and totally unneccesary.
- Don't keep unneeded values in memory with a variable
{
$find_sql = "SELECT null FROM users WHERE username = '{$username}' AND password = '{$password}'";
$run_login = $db->query($find_sql);
}
Use the string directly so it can be removed from memory after executing (not sure about PHPs GC though). You don't need $find_sql anymore in the code so you should just use the string directly.
That's actually pretty much is, since you didn't really give us a lot of coding except for ripped pages from Habbo. Start with OOP is all I can say and learn2tpl
BTW using $_SESSION["login_limit"] will just annoy users who try to type their passwords too fast, and hackers can easily avoid it by cleaning their $_COOKIE['PHP_SESSID']
I have to much to learn..:(
Great effort m8. Keep improving, keep testing, keep releasing.
Re: MindCMS [PHP & MySQLi]
Can someone reupload please??
Re: MindCMS [PHP & MySQLi]
If you mixed the PHP & HTML in the document, never do that, it's bad practice and inefficient :)
Re: MindCMS [PHP & MySQLi]
Re: MindCMS [PHP & MySQLi]
Re: MindCMS [PHP & MySQLi]
link does not work you could reup.
Quote:
Originally Posted by
Vrop93
Thank you.
Re: MindCMS [PHP & MySQLi]