[Help] Negative gold and gold bug in Juver source code

[thenam]

Hello everyone,

I successfully built the bin file from juver source (from the link: https://forum.ragezone.com/threads/...game-functionalities-no-more-selling.1198375/) and use Merge client (from: https://forum.ragezone.com/threads/release-client-compatible-to-juver-source.1198280/). Thank god!
But when I deploy the game, some players have negative gold in inventory, another can earn 999 Billion gold after half day open server (while in-game items are only worth a few tens to several hundred thousand golds)
I know that is bug, but I can't find it.
So help me, please!

attach file is capture screen from GM Tool

 

[Lars]

Have you checked the GM Commands permission? --Some juver based src didn't have proper dwUserLvl verification along with the /get_item password which is another thing.

 

[thenam]

Have you checked the GM Commands permission? --Some juver based src didn't have proper dwUserLvl verification along with the /get_item password which is another thing.

Thanks for your reply. I already view the source code, it checked permission before executing the command.

//    Note : GM 명령.
DWORD dwUSERLVL = GLGaeaClient::GetInstance().GetCharacter()->m_dwUserLvl;
if ( dwUSERLVL < USER_GM3 )                        return true;

So, when I check more information in Database RanLog, table LogExchangeFlag, the player can trade with negative gold in inventory (attach file). I think they used another client to connect to my server.
What do you think???

 

[Lars]

Thanks for your reply. I already view the source code, it checked permission before executing the command.

//    Note : GM 명령.
DWORD dwUSERLVL = GLGaeaClient::GetInstance().GetCharacter()->m_dwUserLvl;
if ( dwUSERLVL < USER_GM3 )                        return true;

So, when I check more information in Database RanLog, table LogExchangeFlag, the player can trade with negative gold in inventory (attach file). I think they used another client to connect to my server.
What do you think???

Could be, you can try to change your szKey prior to this. So you can prevent other clients/old clients from connecting.

Otherwise the gold is still there.

 

[thenam]

Without the key authentication between the client and server, do you think of other possibilities?

 

[Lars]

Without the key authentication between the client and server, do you think of other possibilities?

The /get_item command.

 

[thenam]

The /get_item command.

Only GM can exec this command, I changed the password too

 

[ssodomain]

it doesn't matter about the get_item commands.
for the UserLevel , just add in in every gm commands Request code and the server process code. and its should be fine to use.
for this negative gold issue, if you cannot fix on your own, you can contact me via discord. i can fix it.
ssodomain#3366

 

[Glazier Con]

any help how to fix this Inventory slot and Character Info slot?

 

[raffy0809]

Open GLPrivateMarker.cpp
Look for
if ( sSALEPOS==SNATIVEID(false) )
{
BOOL bOK = m_invenSALE.FindInsrtable ( pITEM->sBasicOp.wInvenSizeX, pITEM->sBasicOp.wInvenSizeY, sSALEPOS.wMainID, sSALEPOS.wSubID );
if ( !bOK ) return false;
}
Add this code below

// price validation
if ( llPRICE < 0 )
{
return false;
}

 

[kaedehonjou.ph]

Open GLPrivateMarker.cpp
Look for
if ( sSALEPOS==SNATIVEID(false) )
{
BOOL bOK = m_invenSALE.FindInsrtable ( pITEM->sBasicOp.wInvenSizeX, pITEM->sBasicOp.wInvenSizeY, sSALEPOS.wMainID, sSALEPOS.wSubID );
if ( !bOK ) return false;
}
Add this code below

// price validation
if ( llPRICE < 0 )
{
return false;
}

is this really actual permanent solution??

 

[id09318]

is this really actual permanent solution??

You got a better way?

 

[kaedehonjou.ph]

You got a better way?

why you ask me