Aside from opening the ports on your firewall, you must also forward them on your router.
If, however, you did forward the ports, you might want to check with your ISP. Some have modem/routers that don't allow for port forwarding.
Lastly, please ensure you're giving others your public IP address instead of your private (typically 192.168...).