Swap bug Quick fix

[Quget]

Hi I fixed the swap bug a long time ago it got tested on my server and it worked
I posted this because someone kinda posted a youtube thingy about it :O.

Find this in DPSrv.cpp @ worldserver

void CDPSrvr::OnDoEquip( CAr & ar, DPID dpidCache, DPID dpidUser, LPBYTE lpBuf, u_long uBufSize )
{
	DWORD nId;
	int nPart;

	ar >> nId;
	ar >> nPart;		
	
	if( nPart >= MAX_HUMAN_PARTS )	
		return;

	CUser* pUser = g_UserMng.GetUser( dpidCache, dpidUser );

And put this under it

#ifdef __QUGET_SWAP_FIX

				if( pUser->GetHitPoint() >  pUser->GetMaxHitPoint() )
					 pUser->SetHitPoint( pUser->GetMaxHitPoint());

				if( pUser->GetManaPoint() >  pUser->GetMaxManaPoint() )
					 pUser->SetManaPoint( pUser->GetMaxManaPoint() );

				if( pUser->GetFatiguePoint() >  pUser->GetMaxFatiguePoint() )
					 pUser->SetFatiguePoint( pUser->GetMaxFatiguePoint() );

#endif

find this in function void CDPClient::OnDoEquip( OBJID objid, CAr & ar ) @ DPClient.cpp
and add under

if( g_WndMng.m_pWndBeautyShop && g_WndMng.m_pWndBeautyShop->m_pModel )
			{
				CMover::UpdateParts( pPlayer->GetSex(), pPlayer->m_dwSkinSet, pPlayer->m_dwFace, pPlayer->m_dwHairMesh, pPlayer->m_dwHeadMesh, pPlayer->m_aEquipInfo, g_WndMng.m_pWndBeautyShop->m_pModel, &pPlayer->m_Inventory );
			}

this

#ifdef __QUGET_SWAP_FIX
				if( pPlayer->GetHitPoint() >  pPlayer->GetMaxHitPoint() )
					 pPlayer->SetHitPoint( pPlayer->GetMaxHitPoint());

				if( pPlayer->GetManaPoint() >  pPlayer->GetMaxManaPoint() )
					 pPlayer->SetManaPoint( pPlayer->GetMaxManaPoint() );

				if( pPlayer->GetFatiguePoint() >  pPlayer->GetMaxFatiguePoint() )
					 pPlayer->SetFatiguePoint( pPlayer->GetMaxFatiguePoint() );

#endif

and then define __QUGET_SWAP_FIX in versioncommon.h @neuz and worldserver

 

[Detox]

Funny how we got further in the flyff development then eFlyFF.

Good release.

 

[cKenzy]

Good job MisterKid, Swap **** the PvP alot.

 

[Quget]

Good job MisterKid, Swap **** the PvP alot.

I know i tought of fixing it since BP alway's do this swap ****

 

[Reimniess]

already knew that personally, but it will still be a pleasant sight to see the swap bug eliminated from more servers

 

[carlos123]

how does work this swap works? it block any item usage or block any skill when ur using any skill. or just fix the bug?

 

[ShadowDragon]

it works by resetting your HP, MP, and FP every time you equip something

 

[Akerius]

thanks for the release

 

[carlos123]

are you kidding me or im failing? this source edit didnt fix anything xD...

swamp's still perfectly working

 

[ShadowDragon]

did you put #define __QUGET_SWAP_FIX in versioncommon.h of world server folder?

 

[carlos123]

ofcourse. i did all he said in the guide XD

 

[carlos123]

ofcourse. i did all he said in the guide XD

 

[ShadowDragon]

did you compile/build it and use the new worldserver program? cause that's the only thing that hasn't been said xD

 

[Quget]

Idk at my server they said it got fixed.
I don't bug abuse lol so yea...
Let me explain...

if( pUser->GetHitPoint() > pUser->GetMaxHitPoint() )//If users HitPoint is higher then users max hitpoints..
pUser->SetHitPoint( pUser->GetMaxHitPoint());//Set users hitpoints to his max hitpoints

 

[cKenzy]

This dont "Fix" swap at all.

 

[sagenessamerda]

Why don't you make just a check in the dmg formula for Psycho Bomb & Asal?

something like that:

int AsalFormula ()
{
	int nMana = pUser->GetManaPoint();

	if( nMana > pUser->GetMaxManaPoint() )
		 nMana = pUser->GetMaxManaPoint();

	return nStr*nMana*TheRest;
}

 

[Quget]

Why don't you make just a check in the dmg formula for Psycho Bomb & Asal?

something like that:

int AsalFormula ()
{
	int nMana = pUser->GetManaPoint();

	if( nMana > pUser->GetMaxManaPoint() )
		 nMana = pUser->GetMaxManaPoint();

	return nStr*nMana*TheRest;
}

Nha i would rather check when you swap the **** (OnDoEquip)
So other skills wont be effected with the bug.

This should have fixed the swap bug since it didnt work on my server atleast gms/mod/players confirmed it didnt work anymore.
When my server was still running... tt1:

nvm forgot a piece of code in the client let me update

/updated main post sorry

 

[ShadowDragon]

lol i sorta thought server side would be too simple..
either way, I did as the previous have said and fixed it in the formula

 

[Quget]

I forgot the neuz edit check the main post it should work now

 

[ShadowDragon]

So other skills wont be effected with the bug.

oh yeah, this is actually inaccurate. Spirit Bomb and Asal both have completely separate damage functions, so modifying them to prevent swapping, has no effect on any other skills.