[Fix] No more cm.dispose();

[FateJiki]

I coded this a few months ago and I decided to release a fix to completely obliterate cm.dispose() problems.

Put this in NPCTalkHandler under "int oid = slea.readInt();"

        if(NPCScriptManager.getInstance().getCM(c) != null){
        dispose(c);
        }

Here's the dispose method:

    public void dispose(MapleClient c){
        c.announce(MaplePacketCreator.enableActions());
        NPCScriptManager.getInstance().getCM(c).dispose();
    }

If you decide to migrate this release anywhere else, please provide credits. If you don't, then you're a poopoo head.

 

[Soulfist]

Nice job Mr.Jikian, but I'm not really sure what you are trying to accomplish with this. Are you changing the dispose method? Are you making it so it automatically disposes?

If its #2 then I really like this .

 

[iAkira]

If it's the second option then I'll love you


---------- Post added at 02:51 AM ---------- Previous post was at 02:49 AM ----------

Sorry on double post but before I had something similar to this and it caused some errors on npcs

 

[hindie]

I believed I was the first to release something similar to this on my old account( shall not mention who)

 

[Soulfist]

If it's the second option then I'll love you


---------- Post added at 02:51 AM ---------- Previous post was at 02:49 AM ----------

Sorry on double post but before I had something similar to this and it caused some errors on npcs

Hey hey hey, Don't steal my line mofo :/:

 

[FateJiki]

What this does, is that before the NPC is launched, it checks if your session is already talking to an NPC. If it is, then it 'auto-disposes' you, then launches the NPC.


So yes, it's the second option!

 

[Sparrow]

What this does, is that before the NPC is launched, it checks if your session is already talking to an NPC. If it is, then it 'auto-disposes' you, then launches the NPC.


So yes, it's the second option!

I don't see how that needed to be explained, but yes, thanks alot!

 

[AuroX]

The way you put the title -> No more cm.dispose() make makes everyone think that you do not need the cm.dispose() for the NPC. This is just a temporary fix, but you still need the cm.dispose() for your NPC. If you didn't do so, your NPC will keep on talking till the last time of the code. Means you won't be able to have different status.

 

[Soulfist]

What this does, is that before the NPC is launched, it checks if your session is already talking to an NPC. If it is, then it 'auto-disposes' you, then launches the NPC.


So yes, it's the second option!

I love you

 

[Expedia]

I've seriously never had this npc dispose problem, unless it was like a super crappy script. But nice job anyways

 

[Soulfist]

I've seriously never had this npc dispose problem, unless it was like a super crappy script. But nice job anyways

No no Kevin you don't understand. Yes teh crappy scripts cause problems, but thats not the point. This makes it unnecessary to even use dispose, shortening scripts and removing problems :O:

 

[SharpAceX]

I'm pretty sure that even with this fix you can't go around removing all the cm.dispose()'s from your NPC scripts.

The REAL fix is to just learn to code proper NPC scripts.

 

[Soulfist]

I'm pretty sure that even with this fix you can't go around removing all the cm.dispose()'s from your NPC scripts.

The REAL fix is to just learn to code proper NPC scripts.

You actually can remove all the cm.dispose()'s from your scripts.

The REAL fix will never happen. People will always make the same mistakes.

 

[Vintage]

oh ragezone...
I was wondering how I could do this, nice

 

[iJFAC]

Good job man ... awesome fix

 

[Xuraz]

this is.... AWESOME!!! :

Nice work dude!

 

[Fraysa]

Okay so I feel no one of you we're getting what it does.
It will first dispose any NPC chats you had, then open
a new one, what fixing the problem when you clicked an npc
2 times and got a d/c (cant' handle 2 windows).

 

[kevintjuh93]

Really nice, never thought about this. But I'm not using it. Because I don't need it and because you always want your idiotic credits for something simple like this.

 

[Shawn]

@Aurox and Sparky: No, this does remove any need for cm.dispose. Yes, you can add a return to the mode definitions, but otherwise it removes the cm.dispose dependency. When you first talk to an NPC, it checks if your "stuck" and disposes you, then it launches the NPC, exactly as he stated.

@Everyone else (you know who you are): Keep the mindless chit-chat out of here please.

 

[xPerpetual]

@Aurox and Sparky: No, this does remove any need for cm.dispose. Yes, you can add a return to the mode definitions, but otherwise it removes the cm.dispose dependency. When you first talk to an NPC, it checks if your "stuck" and disposes you, then it launches the NPC, exactly as he stated.

@Everyone else (you know who you are): Keep the mindless chit-chat out of here please.

No it doesn't.
It will only work if the player clicked the NPC, but if you're using a command to open the npc it won't work.
to really fix it you have to go to NPCConversationManager, find the start method, and put this:

  if (cms.containsKey(c)) {
            dispose(c);
        }

in the beggining of the method.