[Help] is there something worng with my php code?

[andsnake]

<?php

// Connects to your Database
mysql_connect("127.0.0.1", "root", "") or die(mysql_error()); 
mysql_select_db("fakedb") or die(mysql_error()); 

$username = stripslashes($_POST['u_name']);
$password = stripslashes($_POST['u_pass']);


$query = mysql_query("INSERT INTO Accounts (username, password) VALUES ('$username','$password')");
mysql_query($query) or die(mysql_error());
?>

i wrote this simple code to be able to just insert the two values into the database. The problem is that an empty query error occurs . What am i doing wrong?

 

[username1]

You're doing it wrong. Always use mysql_real_escape_string() to prevent MySQL injection, and it also helps if you make sure that the two variables are not blank...

 

[=XEO=]

<?php

// Connects to your Database
mysql_connect("127.0.0.1", "root", "") or die(mysql_error()); 
mysql_select_db("fakedb") or die(mysql_error()); 

$username = stripslashes($_POST['u_name']);
$password = stripslashes($_POST['u_pass']);


$query = mysql_query("INSERT INTO Accounts (username, password) VALUES ('$username','$password')");
mysql_query($query) or die(mysql_error());
?>

i wrote this simple code to be able to just insert the two values into the database. The problem is that an empty query error occurs . What am i doing wrong?

you made another query
remove last "mysql_query($query) or die(mysql_error());" should be only this in last line.

mysql_query("INSERT INTO Accounts (username, password) VALUES ('$username','$password')");

 

[username1]

sage

Thanks for the solution, but didn't you read the date on this thread?

 

[Matt]

$connect = mysql_connect("127.0.0.1", "root", "") or die(mysql_error());
$select = mysql_select_db("fakedb", $connect) or die(mysql_error());

Misssing the conn id in the selection.

 

[FragFrog]

Thanks for the solution, but didn't you read the date on this thread?

Less then 2 weeks old, nothing wrong with that for future reference :smile:

He's right about the using mysql_real_escape_string btw