[PHP]A way of shortening this huuuge code :P

[EliteGM]

This is the code I use for smileys, and I'd like to shorten it:

		$smileys = array('01', '02', '03', '04', '05', '06', '07', '08', '09', '10');
		
		$text = str_replace(":)", "<img src='images/smileys/". $smileys[0] .".gif' />", $text);
		$text = str_replace(":-)", "<img src='images/smileys/". $smileys[0] .".gif' />", $text);
		$text = str_replace("=)", "<img src='images/smileys/". $smileys[0] .".gif' />", $text);
		
		$text = str_replace(":D", "<img src='images/smileys/". $smileys[1] .".gif' />", $text);
		$text = str_replace(":d", "<img src='images/smileys/". $smileys[1] .".gif' />", $text);
		$text = str_replace("=D", "<img src='images/smileys/". $smileys[1] .".gif' />", $text);
		$text = str_replace("=d", "<img src='images/smileys/". $smileys[1] .".gif' />", $text);
		$text = str_replace(":-D", "<img src='images/smileys/". $smileys[1] .".gif' />", $text);
		$text = str_replace(":-d", "<img src='images/smileys/". $smileys[1] .".gif' />", $text);
		
		$text = str_replace(":O", "<img src='images/smileys/". $smileys[2] .".gif' />", $text);
		$text = str_replace(":o", "<img src='images/smileys/". $smileys[2] .".gif' />", $text);
		$text = str_replace("=O", "<img src='images/smileys/". $smileys[2] .".gif' />", $text);
		$text = str_replace("=o", "<img src='images/smileys/". $smileys[2] .".gif' />", $text);
		$text = str_replace(":-O", "<img src='images/smileys/". $smileys[2] .".gif' />", $text);
		$text = str_replace(":-o", "<img src='images/smileys/". $smileys[2] .".gif' />", $text);
		
		$text = str_replace(":p", "<img src='images/smileys/". $smileys[3] .".gif' />", $text);
		$text = str_replace(":P", "<img src='images/smileys/". $smileys[3] .".gif' />", $text);
		$text = str_replace(";p", "<img src='images/smileys/". $smileys[3] .".gif' />", $text);
		$text = str_replace(";P", "<img src='images/smileys/". $smileys[3] .".gif' />", $text);
		$text = str_replace("=p", "<img src='images/smileys/". $smileys[3] .".gif' />", $text);
		$text = str_replace("=P", "<img src='images/smileys/". $smileys[3] .".gif' />", $text);
		$text = str_replace(":-p", "<img src='images/smileys/". $smileys[3] .".gif' />", $text);
		$text = str_replace(":-P", "<img src='images/smileys/". $smileys[3] .".gif' />", $text);
		
		$text = str_replace(":(", "<img src='images/smileys/". $smileys[4] .".gif' />", $text);
		$text = str_replace("=(", "<img src='images/smileys/". $smileys[4] .".gif' />", $text);
		$text = str_replace(":-(", "<img src='images/smileys/". $smileys[4] .".gif' />", $text);
		
		$text = str_replace(":'(", "<img src='images/smileys/". $smileys[5] .".gif' />", $text);
		$text = str_replace("='(", "<img src='images/smileys/". $smileys[5] .".gif' />", $text);
		$text = str_replace(":'-(", "<img src='images/smileys/". $smileys[5] .".gif' />", $text);
		$text = str_replace(":cry:", "<img src='images/smileys/". $smileys[5] .".gif' />", $text);
		
		$text = str_replace(":|", "<img src='images/smileys/". $smileys[6] .".gif' />", $text);
		$text = str_replace(":-|", "<img src='images/smileys/". $smileys[6] .".gif' />", $text);
		
		$text = str_replace(":@", "<img src='images/smileys/". $smileys[7] .".gif' />", $text);
		$text = str_replace(":-@", "<img src='images/smileys/". $smileys[7] .".gif' />", $text);
		
		$text = str_replace("(l)", "<img src='images/smileys/". $smileys[8] .".gif' />", $text);
		$text = str_replace("(L)", "<img src='images/smileys/". $smileys[8] .".gif' />", $text);
		
		$text = str_replace(":police:", "<img src='images/smileys/". $smileys[9] .".gif' />", $text);
		$text = str_replace(":cop:", "<img src='images/smileys/". $smileys[9] .".gif' />", $text);

I've tried something with more arrays but I got confused
Any suggestions ?

 

[Pieman]

Holy duck.

First of all, only use 1 command for a smiley instead of 7. Second of all, use preg_replace.

function replace_smiley($str) {

$spattern = array(
"/:\)/",
"/:\(/",
"/:(P|p)/"
//etc...
);

$replace = array(
"smileycodehere",
"smileycodehere",
"smileycodehere"
);

$str = preg_replace($spattern, $replace, $str);

return $str;
}

Normally I'd use indentation but I can't use the tab key in this text editor.

Read

You must be registered to see links

if you have trouble with the regular expressions used in the search pattern.

 

[admLoki]

Holy Molly...
That part of code is rather slow, isn't it?

You can use preg_replace as Pieman said, or you can use str_replace with arrays as variables. And i doesn't see any reasons to use preg_replace when you haven't a regexp-patterns :

function replaceSmiley($string)
{
$smilies = array(':-)',':-(',':-D');
$replacement = array('codehere','codehere','codehere');
return str_replace($smilies,$replacement,$string);
}

 

[EliteGM]

@pie:
instead of doing "/P|p)/" can't you do "//i" ?

 

[admLoki]

instead of doing "/P|p)/" can't you do "//i" ?

Instead of "/P|p)/" required to use "//i".

 

[Pieman]

Oh dear, that was a stupid error. :x

 

[EliteGM]

Ty guys, fixed it up ;P